Merge pull request 'Minor cleanup in ViewLatestWorkflowRun' (#2343) from algernon/b/actions/view-latest-run-for-workflow/ctx.ServerError into forgejo

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2343
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
This commit is contained in:
Gusted 2024-02-14 09:02:30 +00:00
commit 2cf242344e

View file

@ -22,7 +22,6 @@ import (
"code.gitea.io/gitea/modules/actions" "code.gitea.io/gitea/modules/actions"
"code.gitea.io/gitea/modules/base" "code.gitea.io/gitea/modules/base"
context_module "code.gitea.io/gitea/modules/context" context_module "code.gitea.io/gitea/modules/context"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/storage" "code.gitea.io/gitea/modules/storage"
"code.gitea.io/gitea/modules/timeutil" "code.gitea.io/gitea/modules/timeutil"
"code.gitea.io/gitea/modules/util" "code.gitea.io/gitea/modules/util"
@ -75,8 +74,7 @@ func ViewLatestWorkflowRun(ctx *context_module.Context) {
if errors.Is(err, util.ErrNotExist) { if errors.Is(err, util.ErrNotExist) {
ctx.NotFound("GetLatestRunForBranchAndWorkflow", err) ctx.NotFound("GetLatestRunForBranchAndWorkflow", err)
} else { } else {
log.Error("GetLatestRunForBranchAndWorkflow: %v", err) ctx.ServerError("GetLatestRunForBranchAndWorkflow", err)
ctx.Error(http.StatusInternalServerError, "Unable to get latest run for workflow on branch")
} }
return return
} }