From 81cc944cdaab468e456f3e53fb4b511e1c6a863b Mon Sep 17 00:00:00 2001 From: Otto Richter Date: Wed, 17 Apr 2024 19:32:18 +0200 Subject: [PATCH 1/2] Fix unlabelled button in code review (cherry picked from commit 187e10d8c9d8cd3edeb953e520ba370f2f1c73b3) --- options/locale/locale_en-US.ini | 1 + templates/repo/diff/box.tmpl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index 9198847235..18a396b715 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -99,6 +99,7 @@ disabled = Disabled locked = Locked copy = Copy +copy_generic = Copy to clipboard copy_url = Copy URL copy_hash = Copy hash copy_content = Copy content diff --git a/templates/repo/diff/box.tmpl b/templates/repo/diff/box.tmpl index 6b343e4ee0..71154f9768 100644 --- a/templates/repo/diff/box.tmpl +++ b/templates/repo/diff/box.tmpl @@ -130,7 +130,7 @@ {{if $file.IsRenamed}}{{$file.OldName}} → {{end}}{{$file.Name}} {{if .IsLFSFile}} ({{ctx.Locale.Tr "repo.stored_lfs"}}){{end}} - + {{if $file.IsGenerated}} {{ctx.Locale.Tr "repo.diff.generated"}} {{end}} From 4eefb64b12d379fa539ae33135f87105c16ea36b Mon Sep 17 00:00:00 2001 From: Otto Richter Date: Wed, 17 Apr 2024 19:40:16 +0200 Subject: [PATCH 2/2] Rename button to "Finish Review" Motivation: The meaning of the button is apparent from the visual position and the number icon. This is not exposed to a screenreader. Naming it to "Finish Review" helps with to provide the meaning of the button as well as the number in the label. (cherry picked from commit 87d4746f5e3acb55d6469b33e96e774ad0179420) --- options/locale/locale_en-US.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index 18a396b715..25ecb91d37 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -2596,7 +2596,7 @@ diff.comment.add_single_comment = Add single comment diff.comment.add_review_comment = Add comment diff.comment.start_review = Start review diff.comment.reply = Reply -diff.review = Review +diff.review = Finish review diff.review.header = Submit review diff.review.placeholder = Review comment diff.review.comment = Comment