From 1ebf4abddc05bb74d3187d01eda2384bba4e70f5 Mon Sep 17 00:00:00 2001 From: Gusted Date: Thu, 28 Mar 2024 22:27:53 +0100 Subject: [PATCH] [BUG] Use correct format - `%w` is to wrap errors, but can only be used by `fmt.Errorf`. Instead use `%v` to display the error. - Regression of #2763 Before: [E] failed to run attr-check. Error: %!w(*exec.ExitError=&{0xc006568e28 []}) Stderr: fatal: this operation must be run in a work tree After: [E] failed to run attr-check. Error: exit status 128 Stderr: fatal: this operation must be run in a work tree --- modules/git/repo_attribute.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/git/repo_attribute.go b/modules/git/repo_attribute.go index 7651a4434c..0008fcfe11 100644 --- a/modules/git/repo_attribute.go +++ b/modules/git/repo_attribute.go @@ -268,7 +268,7 @@ func (repo *Repository) GitAttributeChecker(treeish string, attributes ...string if err != nil && // If there is an error we need to return but: cmd.parentContext.Err() != err && // 1. Ignore the context error if the context is cancelled or exceeds the deadline (RunWithContext could return c.ctx.Err() which is Canceled or DeadlineExceeded) err.Error() != "signal: killed" { // 2. We should not pass up errors due to the program being killed - log.Error("failed to run attr-check. Error: %w\nStderr: %s", err, stdErr.String()) + log.Error("failed to run attr-check. Error: %v\nStderr: %s", err, stdErr.String()) } }()