Forgejo/models/issues
Gusted 8fb027fea5
[BUG] Ensure HasIssueContentHistory takes into account comment_id
- Backport of #2518
- The content history table contains the content history of issues and
comments. For issues they are saved with an comment id of zero.
- If you want to check if the issue has an content history, it should
take into account that SQL has `comment_id = 0`, as it otherwise could
return incorrect results when for example the issue already has an
comment that has an content history.
- Fix the code of `HasIssueContentHistory` to take this into account, it
relied on XORM to generate the SQL from the non-default values of the
struct, this wouldn't generate the `comment_id = 0` SQL as `0` is the
default value of an integer.
- Remove an unncessary log (it's not the responsibility of `models`
code to do logging).
- Adds unit test.
- Resolves #2513

(cherry picked from commit 331fa44956)
2024-03-01 15:48:42 +01:00
..
assignees.go Make more functions use ctx instead of db.DefaultContext (#24068) 2023-04-14 14:18:28 -04:00
assignees_test.go Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) 2023-09-14 02:59:53 +00:00
comment.go Dont load Review if Comment is CommentTypeReviewRequest (#28551) (#29160) 2024-02-20 09:22:26 +01:00
comment_code.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
comment_list.go Use ghost user if user was not found (#29161) (#29169) 2024-02-20 09:26:13 +01:00
comment_test.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
content_history.go [BUG] Ensure HasIssueContentHistory takes into account comment_id 2024-03-01 15:48:42 +01:00
content_history_test.go [BUG] Ensure HasIssueContentHistory takes into account comment_id 2024-03-01 15:48:42 +01:00
dependency.go Add API to manage issue dependencies (#17935) 2023-03-28 13:23:25 -04:00
dependency_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
issue.go [FEAT] allow setting the update date on issues and comments 2023-11-13 12:33:49 +01:00
issue_index.go Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
issue_label.go Don't let API add 2 exclusive labels from same scope (#27433) (#27460) 2023-10-06 05:06:31 +08:00
issue_label_test.go Don't let API add 2 exclusive labels from same scope (#27433) (#27460) 2023-10-06 05:06:31 +08:00
issue_list.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_list_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_lock.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
issue_project.go Use more IssueList instead of []*Issue (#26369) 2023-08-07 19:26:40 +00:00
issue_search.go Fix review request number and add more tests (#27104) (#27168) 2023-09-21 17:01:37 +00:00
issue_stats.go Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
issue_test.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
issue_update.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
issue_user.go Add index to issue_user.issue_id (#27154) (#27158) 2023-09-21 11:42:34 +08:00
issue_user_test.go Fix bug with sqlite load read (#26305) 2023-08-05 10:40:27 +08:00
issue_watch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_watch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_xref.go [FEAT] allow setting the update date on issues and comments 2023-11-13 12:33:49 +01:00
issue_xref_test.go Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) 2023-09-14 02:59:53 +00:00
label.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
label_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
main_test.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
milestone.go [FEAT] allow setting the update date on issues and comments 2023-11-13 12:33:49 +01:00
milestone_list.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
milestone_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
pull.go [BUG] Correct changed files for codeowners 2024-02-28 20:13:20 +01:00
pull_list.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
pull_test.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
reaction.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
reaction_test.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
review.go Workaround to clean up old reviews on creating a new one (#28554) (#29264) 2024-02-20 09:39:02 +01:00
review_list.go Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
review_test.go Fix 500 when deleting a dismissed review (#27903) (#27910) 2023-11-05 13:59:11 +00:00
stopwatch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
stopwatch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
tracked_time.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
tracked_time_test.go Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) 2023-09-14 02:59:53 +00:00