mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-08-21 12:08:54 +02:00
The 4 functions are duplicated, especially as interface methods. I think we just need to keep `MustID` the only one and remove other 3. ``` MustID(b []byte) ObjectID MustIDFromString(s string) ObjectID NewID(b []byte) (ObjectID, error) NewIDFromString(s string) (ObjectID, error) ``` Introduced the new interfrace method `ComputeHash` which will replace the interface `HasherInterface`. Now we don't need to keep two interfaces. Reintroduced `git.NewIDFromString` and `git.MustIDFromString`. The new function will detect the hash length to decide which objectformat of it. If it's 40, then it's SHA1. If it's 64, then it's SHA256. This will be right if the commitID is a full one. So the parameter should be always a full commit id. @AdamMajer Please review.
48 lines
1.2 KiB
Go
48 lines
1.2 KiB
Go
// Copyright 2015 The Gogs Authors. All rights reserved.
|
|
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
//go:build gogit
|
|
|
|
package git
|
|
|
|
import "github.com/go-git/go-git/v5/plumbing"
|
|
|
|
func (repo *Repository) getTree(id ObjectID) (*Tree, error) {
|
|
gogitTree, err := repo.gogitRepo.TreeObject(plumbing.Hash(id.RawValue()))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
tree := NewTree(repo, id)
|
|
tree.gogitTree = gogitTree
|
|
return tree, nil
|
|
}
|
|
|
|
// GetTree find the tree object in the repository.
|
|
func (repo *Repository) GetTree(idStr string) (*Tree, error) {
|
|
if len(idStr) != repo.objectFormat.FullLength() {
|
|
res, _, err := NewCommand(repo.Ctx, "rev-parse", "--verify").AddDynamicArguments(idStr).RunStdString(&RunOpts{Dir: repo.Path})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(res) > 0 {
|
|
idStr = res[:len(res)-1]
|
|
}
|
|
}
|
|
id, err := NewIDFromString(idStr)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
resolvedID := id
|
|
commitObject, err := repo.gogitRepo.CommitObject(plumbing.Hash(id.RawValue()))
|
|
if err == nil {
|
|
id = ParseGogitHash(commitObject.TreeHash)
|
|
}
|
|
treeObject, err := repo.getTree(id)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
treeObject.ResolvedID = resolvedID
|
|
return treeObject, nil
|
|
}
|