From 15877ddf1f63b7e69edb46bd77b296fad8276145 Mon Sep 17 00:00:00 2001
From: shenlong <139912620+shenlong-tanwen@users.noreply.github.com>
Date: Fri, 23 May 2025 01:43:16 +0530
Subject: [PATCH] fix: translations from background service (#18473)
* fix: translations from background service
* test: generate translation before running tests
---------
Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
---
.github/workflows/test.yml | 5 +++++
mobile/lib/services/localization.service.dart | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e19f9db6fc..dc7d22fc57 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -504,6 +504,11 @@ jobs:
with:
channel: 'stable'
flutter-version-file: ./mobile/pubspec.yaml
+
+ - name: Generate translation file
+ run: make translation
+ working-directory: ./mobile
+
- name: Run tests
working-directory: ./mobile
run: flutter test -j 1
diff --git a/mobile/lib/services/localization.service.dart b/mobile/lib/services/localization.service.dart
index c8ef662896..8bee710544 100644
--- a/mobile/lib/services/localization.service.dart
+++ b/mobile/lib/services/localization.service.dart
@@ -1,10 +1,10 @@
// ignore_for_file: implementation_imports
-import 'package:flutter/foundation.dart';
-import 'package:easy_localization/src/asset_loader.dart';
import 'package:easy_localization/src/easy_localization_controller.dart';
import 'package:easy_localization/src/localization.dart';
+import 'package:flutter/foundation.dart';
import 'package:immich_mobile/constants/locales.dart';
+import 'package:immich_mobile/generated/codegen_loader.g.dart';
/// Workaround to manually load translations in another Isolate
Future<bool> loadTranslations() async {
@@ -14,7 +14,7 @@ Future<bool> loadTranslations() async {
supportedLocales: locales.values.toList(),
useFallbackTranslations: true,
saveLocale: true,
- assetLoader: const RootBundleAssetLoader(),
+ assetLoader: const CodegenLoader(),
path: translationsPath,
useOnlyLangCode: false,
onLoadError: (e) => debugPrint(e.toString()),