Backupppert/jellyfin
0
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2024-07-08 23:00:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Minor improvements

Browse source
This commit is contained in:
Bond_009 2020-09-20 14:02:41 +02:00
parent 3b006cd674
commit 228b33a23b
7 changed files with 46 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Emby.Naming/AudioBook/AudioBookFilePathParser.cs
View file

@ -1,6 +1,6 @@
#nullable enable
#pragma warning disable CS1591 #pragma warning disable CS1591
using System;
using System.Globalization; using System.Globalization;
using System.IO; using System.IO;
using System.Text.RegularExpressions; using System.Text.RegularExpressions;
@ -19,12 +19,7 @@ namespace Emby.Naming.AudioBook
public AudioBookFilePathParserResult Parse(string path) public AudioBookFilePathParserResult Parse(string path)
{ {
if (path == null) AudioBookFilePathParserResult result = default;
{
throw new ArgumentNullException(nameof(path));
}
var result = new AudioBookFilePathParserResult();
var fileName = Path.GetFileNameWithoutExtension(path); var fileName = Path.GetFileNameWithoutExtension(path);
foreach (var expression in _options.AudioBookPartsExpressions) foreach (var expression in _options.AudioBookPartsExpressions)
{ {

3
Emby.Naming/AudioBook/AudioBookFilePathParserResult.cs
View file

@ -1,8 +1,9 @@
#nullable enable
#pragma warning disable CS1591 #pragma warning disable CS1591
namespace Emby.Naming.AudioBook namespace Emby.Naming.AudioBook
{ {
public class AudioBookFilePathParserResult public struct AudioBookFilePathParserResult
{ {
public int? PartNumber { get; set; } public int? PartNumber { get; set; }

6
MediaBrowser.Controller/Extensions/StringExtensions.cs
View file

@ -1,3 +1,4 @@
#nullable enable
#pragma warning disable CS1591 #pragma warning disable CS1591
using System; using System;
@ -15,11 +16,6 @@ namespace MediaBrowser.Controller.Extensions
{ {
public static string RemoveDiacritics(this string text) public static string RemoveDiacritics(this string text)
{ {
if (text == null)
{
throw new ArgumentNullException(nameof(text));
}
var chars = Normalize(text, NormalizationForm.FormD) var chars = Normalize(text, NormalizationForm.FormD)
.Where(ch => CharUnicodeInfo.GetUnicodeCategory(ch) != UnicodeCategory.NonSpacingMark); .Where(ch => CharUnicodeInfo.GetUnicodeCategory(ch) != UnicodeCategory.NonSpacingMark);

3
MediaBrowser.Controller/Library/NameExtensions.cs
View file

@ -1,3 +1,4 @@
#nullable enable
#pragma warning disable CS1591 #pragma warning disable CS1591
using System; using System;
@ -9,7 +10,7 @@ namespace MediaBrowser.Controller.Library
{ {
public static class NameExtensions public static class NameExtensions
{ {
private static string RemoveDiacritics(string name) private static string RemoveDiacritics(string? name)
{ {
if (name == null) if (name == null)
{ {

30
tests/Jellyfin.Naming.Tests/AudioBook/AudioBookFileInfoTests.cs Normal file
View file

@ -0,0 +1,30 @@
using Emby.Naming.AudioBook;
using Xunit;
namespace Jellyfin.Naming.Tests.AudioBook
{
public class AudioBookFileInfoTests
{
[Fact]
public void CompareTo_Same_Success()
{
var info = new AudioBookFileInfo();
Assert.Equal(0, info.CompareTo(info));
}
[Fact]
public void CompareTo_Null_Success()
{
var info = new AudioBookFileInfo();
Assert.Equal(1, info.CompareTo(null));
}
[Fact]
public void CompareTo_Empty_Success()
{
var info1 = new AudioBookFileInfo();
var info2 = new AudioBookFileInfo();
Assert.Equal(0, info1.CompareTo(info2));
}
}
}

16
tests/Jellyfin.Naming.Tests/Video/ExtraTests.cs
View file

@ -44,14 +44,14 @@ namespace Jellyfin.Naming.Tests.Video
} }
[Theory] [Theory]
[InlineData(ExtraType.BehindTheScenes, "behind the scenes" )] [InlineData(ExtraType.BehindTheScenes, "behind the scenes")]
[InlineData(ExtraType.DeletedScene, "deleted scenes" )] [InlineData(ExtraType.DeletedScene, "deleted scenes")]
[InlineData(ExtraType.Interview, "interviews" )] [InlineData(ExtraType.Interview, "interviews")]
[InlineData(ExtraType.Scene, "scenes" )] [InlineData(ExtraType.Scene, "scenes")]
[InlineData(ExtraType.Sample, "samples" )] [InlineData(ExtraType.Sample, "samples")]
[InlineData(ExtraType.Clip, "shorts" )] [InlineData(ExtraType.Clip, "shorts")]
[InlineData(ExtraType.Clip, "featurettes" )] [InlineData(ExtraType.Clip, "featurettes")]
[InlineData(ExtraType.Unknown, "extras" )] [InlineData(ExtraType.Unknown, "extras")]
public void TestDirectories(ExtraType type, string dirName) public void TestDirectories(ExtraType type, string dirName)
{ {
Test(dirName + "/300.mp4", type, _videoOptions); Test(dirName + "/300.mp4", type, _videoOptions);

1
tests/Jellyfin.Server.Implementations.Tests/Library/PathExtensionsTests.cs
View file

@ -10,6 +10,7 @@ namespace Jellyfin.Server.Implementations.Tests.Library
[InlineData("Superman: Red Son [imdbid=tt10985510]", "imdbid", "tt10985510")] [InlineData("Superman: Red Son [imdbid=tt10985510]", "imdbid", "tt10985510")]
[InlineData("Superman: Red Son - tt10985510", "imdbid", "tt10985510")] [InlineData("Superman: Red Son - tt10985510", "imdbid", "tt10985510")]
[InlineData("Superman: Red Son", "imdbid", null)] [InlineData("Superman: Red Son", "imdbid", null)]
[InlineData("Superman: Red Son", "something", null)]
public void GetAttributeValue_ValidArgs_Correct(string input, string attribute, string? expectedResult) public void GetAttributeValue_ValidArgs_Correct(string input, string attribute, string? expectedResult)
{ {
Assert.Equal(expectedResult, PathExtensions.GetAttributeValue(input, attribute)); Assert.Equal(expectedResult, PathExtensions.GetAttributeValue(input, attribute));