From 262dc6d8cd26a7d4c3be6a01621a98067d92bd57 Mon Sep 17 00:00:00 2001
From: Luke Pulverenti <luke.pulverenti@gmail.com>
Date: Wed, 25 Sep 2013 18:36:48 -0400
Subject: [PATCH] ease up on artist task concurrency

---
 .../Library/Validators/ArtistsValidator.cs    | 62 ++++++-------------
 1 file changed, 19 insertions(+), 43 deletions(-)

diff --git a/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs b/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs
index 73909de27a..7c964eacb7 100644
--- a/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs
+++ b/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs
@@ -185,7 +185,7 @@ namespace MediaBrowser.Server.Implementations.Library.Validators
         /// <param name="cancellationToken">The cancellation token.</param>
         /// <param name="progress">The progress.</param>
         /// <returns>Task{Artist[]}.</returns>
-        private async Task<ConcurrentBag<Artist>> GetAllArtists(IEnumerable<Audio> allSongs, CancellationToken cancellationToken, IProgress<double> progress)
+        private async Task<List<Artist>> GetAllArtists(IEnumerable<Audio> allSongs, CancellationToken cancellationToken, IProgress<double> progress)
         {
             var allArtists = allSongs
                 .SelectMany(i =>
@@ -203,60 +203,36 @@ namespace MediaBrowser.Server.Implementations.Library.Validators
                 .Distinct(StringComparer.OrdinalIgnoreCase)
                 .ToList();
 
-            const int maxTasks = 3;
-
-            var tasks = new List<Task>();
-
-            var returnArtists = new ConcurrentBag<Artist>();
+            var returnArtists = new List<Artist>(allArtists.Count);
 
             var numComplete = 0;
             var numArtists = allArtists.Count;
 
             foreach (var artist in allArtists)
             {
-                if (tasks.Count > maxTasks)
-                {
-                    await Task.WhenAll(tasks).ConfigureAwait(false);
-                    tasks.Clear();
+                cancellationToken.ThrowIfCancellationRequested();
 
-                    // Safe cancellation point, when there are no pending tasks
-                    cancellationToken.ThrowIfCancellationRequested();
+                try
+                {
+                    var artistItem = _libraryManager.GetArtist(artist);
+
+                    await artistItem.RefreshMetadata(cancellationToken).ConfigureAwait(false);
+
+                    returnArtists.Add(artistItem);
+                }
+                catch (IOException ex)
+                {
+                    _logger.ErrorException("Error validating Artist {0}", ex, artist);
                 }
 
-                // Avoid accessing the foreach variable within the closure
-                var currentArtist = artist;
+                // Update progress
+                numComplete++;
+                double percent = numComplete;
+                percent /= numArtists;
 
-                tasks.Add(Task.Run(async () =>
-                {
-                    cancellationToken.ThrowIfCancellationRequested();
-
-                    try
-                    {
-                        var artistItem = _libraryManager.GetArtist(currentArtist);
-
-                        await artistItem.RefreshMetadata(cancellationToken).ConfigureAwait(false);
-
-                        returnArtists.Add(artistItem);
-                    }
-                    catch (IOException ex)
-                    {
-                        _logger.ErrorException("Error validating Artist {0}", ex, currentArtist);
-                    }
-
-                    // Update progress
-                    lock (progress)
-                    {
-                        numComplete++;
-                        double percent = numComplete;
-                        percent /= numArtists;
-
-                        progress.Report(100 * percent);
-                    }
-                }));
+                progress.Report(100 * percent);
             }
 
-            await Task.WhenAll(tasks).ConfigureAwait(false);
-
             return returnArtists;
         }