From 9eaf22e54ef03e9df56fcff87f0685ddd8ecf4ac Mon Sep 17 00:00:00 2001
From: Shaun <shaun@bluebit.com.au>
Date: Tue, 12 Jan 2016 13:22:52 +1100
Subject: [PATCH] add a new endpoint param IsFavorite and use it for reports

---
 MediaBrowser.Api/Reports/ReportsService.cs       | 4 +---
 MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs | 7 +++++++
 MediaBrowser.Api/UserLibrary/ItemsService.cs     | 1 +
 MediaBrowser.Model/Querying/ItemFilter.cs        | 6 +-----
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/MediaBrowser.Api/Reports/ReportsService.cs b/MediaBrowser.Api/Reports/ReportsService.cs
index b8709a499e..6cbe2fd892 100644
--- a/MediaBrowser.Api/Reports/ReportsService.cs
+++ b/MediaBrowser.Api/Reports/ReportsService.cs
@@ -215,6 +215,7 @@ namespace MediaBrowser.Api.Reports
 
                 Filter = i => ApplyAdditionalFilters(request, i, user, _libraryManager),
 
+                IsFavorite = request.IsFavorite,
                 Limit = request.Limit,
                 StartIndex = request.StartIndex,
                 IsMissing = request.IsMissing,
@@ -275,9 +276,6 @@ namespace MediaBrowser.Api.Reports
                     case ItemFilter.IsFavorite:
                         query.IsFavorite = true;
                         break;
-                    case ItemFilter.IsNotFavorite:
-                        query.IsFavorite = false;
-                        break;
                     case ItemFilter.IsFavoriteOrLikes:
                         query.IsFavoriteOrLiked = true;
                         break;
diff --git a/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs b/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs
index 4d844e6cbe..23d4da60c3 100644
--- a/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs
+++ b/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs
@@ -168,6 +168,13 @@ namespace MediaBrowser.Api.UserLibrary
         [ApiMember(Name = "Filters", Description = "Optional. Specify additional filters to apply. This allows multiple, comma delimeted. Options: IsFolder, IsNotFolder, IsUnplayed, IsPlayed, IsFavorite, IsResumable, Likes, Dislikes", IsRequired = false, DataType = "string", ParameterType = "query", Verb = "GET", AllowMultiple = true)]
         public string Filters { get; set; }
 
+        /// <summary>
+        /// Gets or sets the Isfavorite option
+        /// </summary>
+        /// <value>IsFavorite</value>
+        [ApiMember(Name = "IsFavorite", Description = "Optional filter by items that are marked as favorite, or not.", IsRequired = false, DataType = "bool", ParameterType = "query", Verb = "GET")]
+        public bool? IsFavorite { get; set; }
+
         /// <summary>
         /// Gets or sets the media types.
         /// </summary>
diff --git a/MediaBrowser.Api/UserLibrary/ItemsService.cs b/MediaBrowser.Api/UserLibrary/ItemsService.cs
index f1168ab7f4..97d0ad7ab0 100644
--- a/MediaBrowser.Api/UserLibrary/ItemsService.cs
+++ b/MediaBrowser.Api/UserLibrary/ItemsService.cs
@@ -181,6 +181,7 @@ namespace MediaBrowser.Api.UserLibrary
 
                 Filter = i => ApplyAdditionalFilters(request, i, user, _libraryManager),
 
+                IsFavorite = request.IsFavorite,
                 Limit = request.Limit,
                 StartIndex = request.StartIndex,
                 IsMissing = request.IsMissing,
diff --git a/MediaBrowser.Model/Querying/ItemFilter.cs b/MediaBrowser.Model/Querying/ItemFilter.cs
index 3a1786a156..83d61ae514 100644
--- a/MediaBrowser.Model/Querying/ItemFilter.cs
+++ b/MediaBrowser.Model/Querying/ItemFilter.cs
@@ -45,10 +45,6 @@ namespace MediaBrowser.Model.Querying
         /// <summary>
         /// The is favorite or likes
         /// </summary>
-        IsFavoriteOrLikes = 10,
-        /// <summary>
-        /// The item is not a favorite
-        /// </summary>
-        IsNotFavorite = 11
+        IsFavoriteOrLikes = 10
     }
 }