Backupppert/jellyfin
0
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2024-07-22 13:40:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Log a warning if an attempt is made to register an invalid service type

Browse source
This commit is contained in:
Mark Monteiro 2020-03-21 23:19:24 +01:00
parent 72c822513f
commit dc2b8c4646
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Emby.Server.Implementations/Services/ServiceController.cs
View file

@ -3,6 +3,7 @@ using System.Collections.Generic;
using System.Threading.Tasks; using System.Threading.Tasks;
using Emby.Server.Implementations.HttpServer; using Emby.Server.Implementations.HttpServer;
using MediaBrowser.Model.Services; using MediaBrowser.Model.Services;
using Microsoft.Extensions.Logging;
namespace Emby.Server.Implementations.Services namespace Emby.Server.Implementations.Services
{ {
@ -11,6 +12,13 @@ namespace Emby.Server.Implementations.Services
public class ServiceController public class ServiceController
{ {
private readonly ILogger _log;
public ServiceController(ILogger<ServiceController> log)
{
_log = log;
}
public void Init(HttpListenerHost appHost, IEnumerable<Type> serviceTypes) public void Init(HttpListenerHost appHost, IEnumerable<Type> serviceTypes)
{ {
foreach (var serviceType in serviceTypes) foreach (var serviceType in serviceTypes)
@ -21,6 +29,13 @@ namespace Emby.Server.Implementations.Services
public void RegisterService(HttpListenerHost appHost, Type serviceType) public void RegisterService(HttpListenerHost appHost, Type serviceType)
{ {
// Make sure the provided type implements IService
if (!serviceType.IsAssignableFrom(typeof(IService)))
{
_log.LogWarning("Tried to register a service that does not implement IService: {ServiceType}", serviceType);
return;
}
var processedReqs = new HashSet<Type>(); var processedReqs = new HashSet<Type>();
var actions = ServiceExecGeneral.Reset(serviceType); var actions = ServiceExecGeneral.Reset(serviceType);