Merge pull request #4638 from crobibero/migration-guid

Don't die if folder doesn't have id
This commit is contained in:
Claus Vium 2020-12-04 15:24:17 +01:00 committed by GitHub
commit f07a6c3c3e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -35,8 +35,14 @@ namespace Jellyfin.Server.Migrations.Routines
_logger.LogInformation("Removing 'RemoveDownloadImagesInAdvance' settings in all the libraries");
foreach (var virtualFolder in virtualFolders)
{
// Some virtual folders don't have a proper item id.
if (!Guid.TryParse(virtualFolder.ItemId, out var folderId))
{
continue;
}
var libraryOptions = virtualFolder.LibraryOptions;
var collectionFolder = (CollectionFolder)_libraryManager.GetItemById(virtualFolder.ItemId);
var collectionFolder = (CollectionFolder)_libraryManager.GetItemById(folderId);
// The property no longer exists in LibraryOptions, so we just re-save the options to get old data removed.
collectionFolder.UpdateLibraryOptions(libraryOptions);
_logger.LogInformation("Removed from '{VirtualFolder}'", virtualFolder.Name);