From f80343bf9dfa6d79df85b12cdd66d3602c269ebc Mon Sep 17 00:00:00 2001
From: Anthony Lavado <anthony@lavado.ca>
Date: Wed, 16 Oct 2019 01:43:53 -0400
Subject: [PATCH] Fix the Setup Type dialog titles

I had put the title and subtitle in the wrong order. This corrects the issue.
---
 deployment/windows/dialogs/setuptype.nsddef | 2 +-
 deployment/windows/dialogs/setuptype.nsdinc | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/deployment/windows/dialogs/setuptype.nsddef b/deployment/windows/dialogs/setuptype.nsddef
index ff59f62152..b55ceeaaa6 100644
--- a/deployment/windows/dialogs/setuptype.nsddef
+++ b/deployment/windows/dialogs/setuptype.nsddef
@@ -4,7 +4,7 @@ This file was created by NSISDialogDesigner 1.4.4.0
 http://coolsoft.altervista.org/nsisdialogdesigner
 Do not edit manually!
 -->
-<Dialog Name="setuptype" Title="This controls how Jellyfin is installed." Subtitle="Setup Type">
+<Dialog Name="setuptype" Title="Setup Type" Subtitle="Control how Jellyfin is installed.">
   <Label Name="InstallasaServiceLabel" Location="12, 115" Size="426, 46" Text="Install Jellyfin as a service. This method is recommended for Advanced Users. Additional setup is required to access network shares." TabIndex="0" />
   <RadioButton Name="InstallasaService" Location="12, 88" Size="426, 24" Text="Install as a Service (Advanced Users)" TabIndex="1" />
   <Label Name="BasicInstallLabel" Location="12, 39" Size="426, 46" Text="The basic install will run Jellyfin in your current user account.$\nThis is recommended for new users and those with existing Jellyfin installs older than 10.4." TabIndex="2" />
diff --git a/deployment/windows/dialogs/setuptype.nsdinc b/deployment/windows/dialogs/setuptype.nsdinc
index 6c30119331..edc907ad0e 100644
--- a/deployment/windows/dialogs/setuptype.nsdinc
+++ b/deployment/windows/dialogs/setuptype.nsdinc
@@ -26,7 +26,7 @@ Function fnc_setuptype_Create
   ${If} $hCtl_setuptype == error
     Abort
   ${EndIf}
-  !insertmacro MUI_HEADER_TEXT "This controls how Jellyfin is installed." "Setup Type"
+  !insertmacro MUI_HEADER_TEXT "Setup Type" "Control how Jellyfin is installed."
   
   ; === InstallasaServiceLabel (type: Label) ===
   ${NSD_CreateLabel} 8u 71u 280u 28u "Install Jellyfin as a service. This method is recommended for Advanced Users. Additional setup is required to access network shares."
@@ -49,4 +49,8 @@ Function fnc_setuptype_Create
   
 FunctionEnd
 
-
+; dialog show function
+Function fnc_setuptype_Show
+  Call fnc_setuptype_Create
+  nsDialogs::Show
+FunctionEnd