From f91c30a4071291cb11f193da3cd435114cd43aba Mon Sep 17 00:00:00 2001
From: Luke Pulverenti <luke.pulverenti@gmail.com>
Date: Sun, 22 Mar 2015 19:41:58 -0400
Subject: [PATCH] fixes #1048

---
 .../Library/Validators/ArtistsValidator.cs            |  5 -----
 .../Playlists/PlaylistManager.cs                      |  2 --
 .../Sync/SyncManager.cs                               | 11 +----------
 3 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs b/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs
index 7636833e4d..a964738e6b 100644
--- a/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs
+++ b/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs
@@ -2,7 +2,6 @@
 using MediaBrowser.Controller.Library;
 using MediaBrowser.Model.Logging;
 using System;
-using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using System.Threading;
@@ -53,8 +52,6 @@ namespace MediaBrowser.Server.Implementations.Library.Validators
                 .Distinct(StringComparer.OrdinalIgnoreCase)
                 .ToList();
 
-            var returnArtists = new List<MusicArtist>(allArtists.Count);
-
             var numComplete = 0;
             var numArtists = allArtists.Count;
 
@@ -67,8 +64,6 @@ namespace MediaBrowser.Server.Implementations.Library.Validators
                     var artistItem = _libraryManager.GetArtist(artist);
 
                     await artistItem.RefreshMetadata(cancellationToken).ConfigureAwait(false);
-
-                    returnArtists.Add(artistItem);
                 }
                 catch (IOException ex)
                 {
diff --git a/MediaBrowser.Server.Implementations/Playlists/PlaylistManager.cs b/MediaBrowser.Server.Implementations/Playlists/PlaylistManager.cs
index c511f40e0f..a5cc0e0de3 100644
--- a/MediaBrowser.Server.Implementations/Playlists/PlaylistManager.cs
+++ b/MediaBrowser.Server.Implementations/Playlists/PlaylistManager.cs
@@ -181,7 +181,6 @@ namespace MediaBrowser.Server.Implementations.Playlists
             }
 
             var list = new List<LinkedChild>();
-            var itemList = new List<BaseItem>();
 
             var items = GetPlaylistItems(itemIds, playlist.MediaType, user)
                 .Where(i => i.SupportsAddingToPlaylist)
@@ -189,7 +188,6 @@ namespace MediaBrowser.Server.Implementations.Playlists
 
             foreach (var item in items)
             {
-                itemList.Add(item);
                 list.Add(LinkedChild.Create(item));
             }
 
diff --git a/MediaBrowser.Server.Implementations/Sync/SyncManager.cs b/MediaBrowser.Server.Implementations/Sync/SyncManager.cs
index dc539b4083..d489ac8d3f 100644
--- a/MediaBrowser.Server.Implementations/Sync/SyncManager.cs
+++ b/MediaBrowser.Server.Implementations/Sync/SyncManager.cs
@@ -825,17 +825,8 @@ namespace MediaBrowser.Server.Implementations.Sync
 
                 if (item != null)
                 {
-                    var usersWithAccess = new List<User>();
-
-                    foreach (var user in users)
-                    {
-                        if (IsUserVisible(item, user))
-                        {
-                            usersWithAccess.Add(user);
-                        }
-                    }
-
                     response.ItemUserAccess[itemId] = users
+                        .Where(i => IsUserVisible(item, i))
                         .Select(i => i.Id.ToString("N"))
                         .OrderBy(i => i)
                         .ToList();