Commit graph

806 commits

Author SHA1 Message Date
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009 556cc8062d Investigate some TODO comments 2022-11-27 14:13:31 +01:00
Shadowghost 2e639c77c7 Apply review suggestions 2022-11-17 18:54:35 +01:00
Shadowghost 072651c4be Add xmldocs for TMDb provider, correct provider spelling 2022-11-17 11:16:20 +01:00
Claus Vium 263a1663ae
Merge pull request #8521 from 1337joe/fix-missing-symlink-scan
Skip missing symlink instead of breaking out of directory scan
2022-10-12 22:47:41 +02:00
Claus Vium 99e31846bf
Merge pull request #8541 from Bond-009/minor 2022-10-12 16:36:12 +02:00
Claus Vium fc78a6c35c
Merge pull request #8472 from jgriff6/subs
Fix subtitle selection behaviour
2022-10-12 07:22:47 +02:00
Bond_009 f6af28cf96 Fix some things that slipped through the cracks 2022-10-11 23:37:29 +02:00
jgriff6 a83d4b03dc Make 'Always' subtitle mode prioritise full tracks 2022-10-11 18:36:19 +01:00
Joe Rogers c38052a753
Skip missing symlink instead of breaking out of directory scan 2022-10-09 18:56:25 -04:00
Claus Vium b137d0cc2b
Merge pull request #7514 from Shadowghost/music-extend 2022-10-07 15:21:00 +02:00
jgriff6 fbeec04da7 Polish smart subtitle selection logic 2022-10-07 14:17:20 +01:00
Shadowghost 6c6f89acc3 Apply review suggestions 2022-10-07 14:14:21 +02:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
jgriff6 b9abc004a7 Fix subtitle selection behaviour 2022-09-28 22:26:42 +01:00
Hannes Braun 4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
LogicalPhallacy e8893f3d41 Backport pull request #8399 from jellyfin/release-10.8.z
Respect visibility for people items (rebased)

Original-merge: e6124bc154

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:09:38 -04:00
Shadowghost 42fc02cab6 Add xmldocs 2022-09-13 17:20:22 +02:00
Shadowghost cfd1db1638 Prevent MusicArtist creation for artist subfolders 2022-09-13 17:20:22 +02:00
Shadowghost 61fa325ef0 Extend music parsing 2022-09-13 17:20:22 +02:00
luz paz 9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero 8ba83e41ae
Merge pull request #7845 from utkuozdemir/fix/photos-lib-dir-with-single-video 2022-08-14 09:49:27 -07:00
Joshua Boniface e251f1483f Backport pull request #8167 from jellyfin/release-10.8.z
Add back library scan from library manager

Authored-by: Cody Robibero <cody@robibe.ro>

Merged-by: Bond-009 <bond.009@outlook.com>

Original-merge: f9dffa767f
2022-08-01 14:25:44 -04:00
Utku Ozdemir 9ec42f8cf5 fix: single video folder during photos lib scan
Prevent a directory with a single video file to be detected as a movie directory when the library type is "Photos". Closes jellyfin/jellyfin#7825

Signed-off-by: Utku Ozdemir <uoz@protonmail.com>
2022-06-30 13:36:46 +02:00
Cody Robibero 7f1223016d Merge pull request #7946 from cvium/svg
(cherry picked from commit 4ebe70cf6a)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Cody Robibero b35d608b19 Merge pull request #7892 from cvium/fix_tv_multi
(cherry picked from commit 21afec3225)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-14 19:30:59 -04:00
Bond-009 a881733377
Merge pull request #7682 from 1337joe/test-preferred-audio-language 2022-06-14 15:23:40 +02:00
Bond-009 2b1a915ead Merge pull request #7604 from Jellifi007/fixes-diactritics
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero efcdab116f Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fix
(cherry picked from commit 60affd0965)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Joe Rogers 644e774040
Fix default audio selection ignoring type 2022-05-17 21:03:51 +02:00
Cody Robibero e086eebb71 Merge pull request #7525 from 1337joe/fix-duplicate-library-media-paths
(cherry picked from commit bebe1808ce)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
jakobkukla 75475285da Fix supportsTranscoding not reflecting user permissions sometimes 2022-03-17 17:24:30 +01:00
Claus Vium 53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Stanislav Ionascu 554d1b2ca8 Fix #7100 by catching the exception on opening invalid UDF images
When an invalid UDF image is opened by the UdfReader, it may throw
and exception. This change is to catch and log the exception.
2022-02-20 13:30:55 +00:00
Bond_009 adad13b865 Remove some dead code 2022-02-17 08:15:26 +01:00
Bond_009 5732e6188c Fix some warnings 2022-02-15 18:59:46 +01:00
Bond_009 5d28c5547e Fix indentation 2022-02-14 16:31:07 +01:00
Bond_009 dbd7be091d Fix MediaStreamSelector 2022-02-14 15:03:08 +01:00
Bond_009 1c14c86b20 Fix some warnings 2022-02-14 14:46:04 +01:00
Cody Robibero b6489e73ab
Merge pull request #7241 from Bond-009/async5 2022-02-06 15:25:48 -07:00
SenorSmartyPants 2b769aae69
TV extras (#7178) 2022-02-04 20:44:38 +01:00
Cody Robibero e5701c396a
Merge pull request #6436 from daullmer/splashscreen 2022-01-28 08:12:21 -07:00
Claus Vium 488ce51032
Remove some allocations (#7246) 2022-01-28 12:21:40 +01:00
Bond_009 e7be01d7a5 Flush to disk async where possible 2022-01-22 23:36:42 +01:00
Cody Robibero a60cb280a3 Properly populate QueryResult 2022-01-20 08:53:06 -07:00
Joe Rogers e762454787
Restore resolver that handles alternate videos
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-01-16 22:59:14 +01:00
Dmitry Lyzo ea1f3fe6bd Fix SA1642 warning 2022-01-15 15:33:54 +03:00
Cody Robibero 0d335082c8 suggestions from review 2022-01-10 10:59:32 -07:00
Cody Robibero 6520ad03f0 Fix release build 2022-01-10 08:30:55 -07:00
Cody Robibero ecb73168b3 Suggestions from review 2022-01-10 08:26:30 -07:00
Joe Rogers a26509a98a
Keep from serializing trailers into database 2022-01-07 22:33:31 +01:00
Bond_009 77c615ba42 Error on SA1316 2022-01-05 10:58:57 +01:00
Bond-009 11d0c6827f
Merge pull request #7058 from cvium/the_most_important_feature 2022-01-02 12:31:20 +01:00
cvium 28c2ac9cc0 Remove file extension filter and fix build 2022-01-01 20:07:03 +01:00
Claus Vium 58b9e5af79
Update Emby.Server.Implementations/Library/Resolvers/GenericVideoResolver.cs
Co-authored-by: Joe Rogers <1337joe@users.noreply.github.com>
2022-01-01 14:52:54 +01:00
Cody Robibero 25abe479eb Add ability to search by - 2021-12-31 08:51:50 -07:00
cvium 2749509f00 Use dedicated resolvers for extras 2021-12-28 00:37:40 +01:00
Cody Robibero 7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009 ea8f40e84a More cleanup 2021-12-27 14:20:05 +00:00
Cody Robibero a615f87680
Merge pull request #7044 from 1337joe/fix-trailers-v2
Fix trailers v2
2021-12-25 23:31:46 +00:00
Joe Rogers c0ab54f0bd Fix resolved type for Trailers 2021-12-24 21:21:19 +00:00
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero 076a13abeb
Merge pull request #7029 from cvium/allocations_maybe 2021-12-24 01:59:25 +00:00
Cody Robibero 00211ca056
Merge pull request #7028 from cvium/everything_went_wrong 2021-12-22 17:57:00 +00:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
cvium 83a94aa612 Fix extras folders 2021-12-20 12:15:20 +01:00
Joe Rogers 077f13ae4c
Increment library number instead of appending 2021-12-18 20:50:36 +01:00
Claus Vium 9a0618552b
Merge branch 'master' into what_could_go_wrong 2021-12-15 08:38:39 +01:00
Claus Vium 4a58582ad5
Merge pull request #6912 from crobibero/filename-tvmaze
Add additional provider id parsing to file name
2021-12-15 08:37:34 +01:00
Cody Robibero 32629cd7da Use BaseItemKind where possible 2021-12-12 06:11:27 -07:00
Cody Robibero a04f8f5efb Fix new test 2021-12-11 20:35:43 -07:00
Cody Robibero eeb8192602 Add StringComparison 2021-12-09 08:38:00 -07:00
Cody Robibero 593b2fd359 Add more speed and more tests 2021-12-09 08:06:06 -07:00
Cody Robibero 3513f5a84b Search for attribute text 2021-12-07 17:10:27 -07:00
cvium 6030946d78 Fixes 2021-12-07 19:23:30 +01:00
cvium fde84a1e00 Refactor extras parsing 2021-12-07 15:24:57 +01:00
Claus Vium 065d3fa837 performance++ 2021-11-27 16:10:43 -07:00
Cody Robibero 4890454935 Add additional provider parsing to series file name 2021-11-27 07:44:12 -07:00
Cody Robibero 0009e5cc27
Merge pull request #6850 from PetrusZ/collection-validator 2021-11-19 07:54:41 -07:00
Petrus.Z acb86066ff
Replace library option to AutomaticallyAddToCollection
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-18 16:00:14 +08:00
Petrus.Z 263bbf897a
Reduce one query
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-18 15:34:35 +08:00
Petrus.Z 6565b0cfbe
Fix style issues
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-18 13:33:44 +08:00
Petrus.Z b635b5a7e3
Paginate movies query
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-18 13:08:56 +08:00
Petrus.Z 6d74c83ddb
Fix issues mentioned in review, except for option name
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-18 12:07:27 +08:00
Petrus.Z 989013c974
Add new line at end of file
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-17 22:22:52 +08:00
Petrus.Z c09e999916
Use List<Gid> instead of List<Movie>
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-17 22:18:59 +08:00
Petrus.Z 52e9dc66f5
Remove extra blank line
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-17 21:07:02 +08:00
Petrus.Z 3c8f7d380f
Improve performance
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-17 20:56:14 +08:00
Petrus.Z 0a0ddb0eaf
Add AutoCollection option
it can determine whether auto create/add movies to collection

Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-17 14:02:07 +08:00
cvium b50c3852ef Remove unused dependencies 2021-11-16 12:24:17 +01:00
Petrus.Z 1924d0740d
Fix style and performance issues mentioned in review
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-16 19:03:18 +08:00
Petrus.Z 74459ec403
Fix issues mentioned in review
Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-16 11:50:04 +08:00
Petrus.Z 5eb1fde88c
Add Collection Validator, create collection based on nfo
Based on nfo's set element, automatically add movie to collection.

Signed-off-by: Petrus.Z <silencly07@gmail.com>
2021-11-16 00:17:14 +08:00
cvium 4f45c52674 Remove ILibraryManager as a dependency in resolvers etc. 2021-11-15 15:56:02 +01:00
Bond_009 1d19a5be61 Fix some warnings
down to 580
2021-11-09 22:29:33 +01:00
Bond_009 5726535a26 Fix some warnings
609 left
2021-11-09 13:14:31 +01:00
Bond_009 4dfb7b18ae Add some docs and tests 2021-11-07 22:32:08 +01:00
Claus Vium 2c42d75288
Merge pull request #6027 from fredriklindberg/improve-series-matching 2021-11-02 20:17:49 +01:00
Bond-009 2d4066748d
Merge pull request #6446 from Deathspike/master 2021-10-27 09:01:00 +02:00
Deathspike 2410b3a3cf Resolve subtitle selection feedback (#6446) 2021-10-26 20:51:35 +02:00
Roel van Uden b830d38a34 Rework subtitle selection to reduce code clutter 2021-10-26 12:59:11 +02:00
Dmitry Lyzo 2b004e1f76 Add more sorting to Latest 2021-10-09 21:36:39 +03:00
Bond_009 03f933aaa0 Fix the last few warnings
Enables TreatWarningsAsErrors for all projects
2021-10-06 11:30:45 +02:00
Patrick Barron e0db541381
Update indentation 2021-10-05 22:07:16 -04:00
Patrick Barron 876a902356 Fix warnings in Library 2021-10-03 21:41:22 -04:00
Bond_009 79642af3b8 Fix some warnings 2021-09-25 20:32:53 +02:00
Bond_009 4d1d9f23d5 Use new Enum.TryParse(ReadOnlySpan<char>) overload 2021-09-24 20:15:46 +02:00
Bond-009 32ea4806f8
Merge pull request #6538 from cvium/livetv_oh_no 2021-09-20 22:38:44 +02:00
Dixin dc8420c7a2 Fix extra folder type resolving. 2021-09-19 16:54:00 -07:00
Fredrik Lindberg ea439c5ccf Improve series name matching
Add a series path resolver that attempts to extract only the series
name from a path that contains more information that just the name.
2021-09-13 17:59:33 +02:00
cvium ff328fefc5 Replace GetDirectStreamProviderByUniqueId with GetLiveStreamInfoByUniqueId 2021-09-10 12:53:45 +02:00
cvium 026a7af0e8 Don't throw when livestream file isn't found 2021-09-10 11:54:26 +02:00
cvium f3573b061c Remove the unused arg 2021-09-10 09:56:48 +02:00
cvium 1603d1928e Kill ProgressiveFileCopier and seek to end for ongoing livetv 2021-09-10 09:29:14 +02:00
Claus Vium c794e48562
Merge pull request #6522 from ferferga/efcore-improvements 2021-09-07 19:40:03 +02:00
Bond-009 71ab4a5754
Fix it for real(tm) this time 2021-09-07 14:18:04 +02:00
Bond-009 8dc0911374
Fix log message 2021-09-07 14:03:32 +02:00
Fernando Fernández 3d0b1ccae6
Remove all unused usings 2021-09-06 21:15:30 +02:00
Claus Vium 74fef6c05b
Merge pull request #6177 from Bond-009/async
Use async FileStreams where it makes sense
2021-09-06 13:55:34 +02:00
Bond_009 637e86478f Fix some warnings 2021-09-03 19:32:11 +02:00
Cody Robibero 611c20dba8 Fix indentation 2021-09-03 06:57:33 -06:00
Cody Robibero ec13412155 Merge remote-tracking branch 'upstream/master' into warn-259810 2021-09-03 06:56:45 -06:00
Bond_009 e3dac4fda2 Use async FileStreams where it makes sense 2021-09-02 14:02:04 +02:00
Claus Vium 4cd372109d
Merge pull request #6473 from Bond-009/nullable7
Enable nullable for more files
2021-09-01 09:28:19 +02:00
Claus Vium 442e756395
Merge pull request #6183 from stanionascu/bdiso-playback 2021-08-30 19:54:06 +02:00
Cody Robibero ecb4b8e0aa Apply suggestions from code review
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-08-30 07:11:34 -06:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Bond_009 645825db36 Enable nullable for more files 2021-08-28 17:32:09 +02:00
Deathspike 95988ce33d Fix embedded subtitles taking priority over external ones 2021-08-17 20:15:16 +02:00
Bond_009 915141f196 Fix some warnings 2021-07-11 22:51:36 +02:00
Bond_009 981cf4cfa0 Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net 2021-06-22 09:48:40 +02:00
Bond_009 6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
Stanislav Ionascu 351ae66509 Better detection of the ISO DVD/BD types
The ISO image will be opened and checked for disc-type specific
folders.
Can be overridden using NAME.dvd.iso / NAME.bluray.iso
2021-06-13 19:24:06 +02:00
Bond-009 cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram 2021-06-12 00:20:54 +02:00
Cody Robibero d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) (#6078)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
Claus Vium 9f2e8063ec
Merge pull request #5997 from JKI12/master
Fixes for Book Progress
2021-05-24 08:52:38 +02:00
cvium 42a2cc1747 Remove some unnecessary allocations 2021-05-24 00:30:41 +02:00
Bond_009 7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
cvium 1b49435a0e Reduce some allocations 2021-05-16 14:49:11 +02:00
Jake King bc017737e6 Changed condition for readbility
- Refactored check if item is not audio book or book to be more readable
2021-05-07 10:35:03 +01:00
Bond_009 4367b97a54 Fix build 2021-05-07 00:52:06 +02:00
Jake King 3cd57cb287 Fixes for Book Progress
- Ignore Books when checking for minium progress
2021-05-06 19:50:00 +01:00
Bond-009 95b1cf532b
Merge pull request #5985 from Bond-009/minor11 2021-05-05 19:22:01 +02:00
Bond_009 47e7c1356c PathExtensions: Fix index out of bounds in TryReplaceSubPath
Fixes #5977
2021-05-05 16:45:04 +02:00
Bond_009 bcb4010db6 More improvements 2021-05-05 15:30:32 +02:00
BaronGreenback 2e98de9062
Code Clean up: Convert to null-coalescing operator ?? (#5845)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
BaronGreenback f2c10471bf
Code Clean up: Use Pattern Matching (#5838)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:37:36 +02:00
Bond-009 48e81e65e8
Merge pull request #5938 from cvium/allocationz 2021-05-05 09:35:30 +02:00
Bill Thornton cd543f7e50
Merge pull request #5738 from cvium/resolve-from-path
Resolve name from episode folder
2021-05-05 00:08:40 -04:00