Commit graph

314 commits

Author SHA1 Message Date
BaronGreenback ebd589aa86 Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).

Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)

All these changes are related.

Changes

1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986. Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:57:39 +01:00
BaronGreenback a3140f83c6 Revert "Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored."
This reverts commit 2aaecb8e14.
2020-04-28 21:51:49 +01:00
BaronGreenback 2aaecb8e14 Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).

Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)

All these changes are related.

Changes

1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986. Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:45:46 +01:00
Bond_009 2be394089e Enable Microsoft.CodeAnalysis.FxCopAnalyzers for Jellyfin.Common 2020-04-02 20:12:18 +02:00
Bond_009 4419587c2a Minor improvements 2020-04-01 15:30:53 +02:00
Bond_009 07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009 2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
Bond-009 6f45d95951 Minor improvements to network code 2019-11-28 17:46:06 +01:00
Bond_009 9d4ce82ab9 Enable TreatWarningsAsErrors for MediaBrowser.Common and Emby.Photos
Adds `#pragma warning disable CS1591` to all files in
MediaBrowser.Common containing undocumented members.
2019-10-09 17:14:15 +02:00
Bond-009 ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond_009 5eaf5465a5 Check checksum for plugin downloads
* Compare the MD5 checksum when downloading plugins
* Reduced log spam due to http requests
* Removed 'GetTempFileResponse' function from HttpClientManager
* Fixed caching for HttpClientManager
2019-08-11 15:54:58 +02:00
Bond_009 2a58c643d2 Fix more warnings 2019-08-09 23:16:24 +02:00
Bond_009 ddd1a282ea Remove IpAddressInfo and IpEndPointInfo classes 2019-07-25 00:15:06 +02:00
Bond-009 e8028de4d7
Merge pull request #1560 from jellyfin/release-10.3.z
Backmerge for 10.3.7
2019-07-24 19:10:04 +02:00
Joshua M. Boniface cf2f5b2026
Merge pull request #1538 from joshuaboniface/epg
Try to fix XmlTvListingsProvider
2019-07-14 17:09:00 -04:00
Bond_009 b294b802a8 Try to fix XmlTvListingsProvider 2019-07-13 17:18:27 -04:00
Bond_009 b1bd062709 Properly set content type 2019-07-13 17:12:06 -04:00
Bond-009 82f041d050
Merge branch 'master' into release-10.3.z 2019-07-06 23:08:52 +02:00
Bond_009 5fc4ad6c4e Address comments 2019-07-06 20:04:45 +02:00
Bond_009 3603c64fa6 Use HttpResponseHeaders instead of a dictionary 2019-07-06 20:04:45 +02:00
Bond_009 d405a400aa Fixes issues with HttpClientManager 2019-07-06 20:04:42 +02:00
Claus Vium 7eb94e9674 Update MediaBrowser.Common/Net/IHttpClient.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-06-18 22:21:07 -04:00
Bond-009 0a5550b13d Remove more unused stuff 2019-06-18 22:20:34 -04:00
Bond-009 067200be83 Remove usage of depricated 'WebRequest'
Ref: https://docs.microsoft.com/en-us/dotnet/api/system.net.webrequest?view=netframework-4.7.2
2019-06-17 19:35:05 -04:00
Anthony Lavado d4a42a1680
Merge pull request #1080 from Bond-009/httpclient
Remove usage of deprecated 'WebRequest'
2019-06-14 09:19:56 -04:00
VooDooS ba12d96d23 Removed wrapping of HeaderNames fields 2019-04-12 15:25:18 +02:00
VooDooS 5f6ab836de Extend Microsoft.Net.Http.Headers.HeaderNames 2019-04-11 15:35:06 +02:00
Claus Vium be86ea2982
Update MediaBrowser.Common/Net/IHttpClient.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-03-27 16:34:56 +01:00
Bond-009 7f42dcc60f Remove more unused stuff 2019-03-08 20:32:14 +01:00
Bond-009 369785c184 Remove usage of depricated 'WebRequest'
Ref: https://docs.microsoft.com/en-us/dotnet/api/system.net.webrequest?view=netframework-4.7.2
2019-03-08 20:17:17 +01:00
Claus Vium 0abe57e930 Merge remote-tracking branch 'remotes/upstream/master' into kestrel_poc 2019-03-07 20:16:51 +01:00
Claus Vium 78742b8e4c Switch to HeaderNames instead of hardcoded strings (and other header related fixes) 2019-03-05 19:20:28 +01:00
Xu Fasheng cbd0e71c07 Send DLNA devices message to only the matched interface
This will be the right way for multiple interfaces, or the client will
receive all devices message with different IP addresses and could not
detect which one could access.

And provide one option DlnaOptions.SendOnlyMatchedHost to fallback to old
behaviour if this commit missed something.
2019-02-22 20:18:34 +08:00
Xu Fasheng cf4e64f430 Add option to toggle if ignore virtual interfaces
Some VPN like ZerotierOne owns IP address but no gateway, and there is no
good idea in NetworkManager.GetIPsDefault() to filter such virtual interfaces,
so just provide one option to let user decide it.
2019-02-22 20:13:17 +08:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan a36658f6f0 ReSharper Reformat: Properties to expression bodied form. 2019-01-13 21:31:14 +01:00
Erwin de Haan ba610b5094 Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.Controller 2019-01-13 21:01:16 +01:00
Erwin de Haan 51ed47f4c4 EditorConfig reformat: Emby.XmlTv, Jellyfin.Server. MediaBrowser.Api, MediaBrowser.Common 2019-01-13 20:30:41 +01:00
Erwin de Haan 106d1d18ed Visual Studio Reformat: MediaBrowser.Common 2019-01-13 20:25:11 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Bond_009 a1b96a3135 Clean up HttpClientManager, LiveTvManager and InstallationManager 2019-01-03 18:24:26 +01:00
Andrew Rabert a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti 5207067811 fix live tv over dlna 2017-11-29 15:50:18 -05:00
Luke Pulverenti 2f758676d0 support sharing m3u tuner streams 2017-11-14 02:41:21 -05:00
Luke Pulverenti ca2e7a4195 deprecate localized guids config switch 2017-10-26 23:49:56 -04:00
Luke Pulverenti b54046a6de adjust header values 2017-10-22 19:36:22 -04:00
Luke Pulverenti c2361db772 separate encoding from content type values 2017-10-22 19:27:09 -04:00
Luke Pulverenti 060215143f improve httpclient resource disposal 2017-10-20 12:16:56 -04:00
Luke Pulverenti 49b799adbe 3.2.30.8 2017-09-05 15:49:02 -04:00
Luke Pulverenti b9c12ca4a7 update legacy stream 2017-03-02 23:36:20 -05:00
Luke Pulverenti 8deb423883 restore config settings for now 2017-02-08 13:50:33 -05:00
Luke Pulverenti 8c8f2aaba5 first pass at binding to multiple network addresses 2016-12-04 16:55:02 -05:00
Luke Pulverenti 00cbadea2c update core project 2016-11-11 02:24:36 -05:00
Luke Pulverenti a8b340cbb2 update portable projects 2016-11-08 13:44:23 -05:00
Luke Pulverenti 72aaecb279 move classes to new server project 2016-11-04 14:56:47 -04:00
Luke Pulverenti 8fd3bf4217 change pcl's to .netstandard 2016-11-03 15:07:48 -04:00
Luke Pulverenti 345ad10665 don't buffer responses by default 2016-10-31 14:39:41 -04:00
Luke Pulverenti c7f559f8ce make model project portable 2016-10-21 22:08:34 -04:00
Luke Pulverenti 37d7db4bc4 support xmltv gzip 2016-06-15 22:37:06 -04:00
Luke Pulverenti 22730746eb ipv6 update 2016-03-25 01:39:49 -04:00
Luke 0ffc5ebace update ulna interface binding 2015-12-25 22:23:02 -05:00
Luke Pulverenti d27cd521b5 rework dialog 2015-12-14 09:45:42 -05:00
Luke Pulverenti b1859d41e8 update collection menus 2015-10-07 17:42:29 -04:00
Luke Pulverenti ee00f8bf72 added HasSyncJob 2015-01-24 14:03:55 -05:00
Mike f6d6d57983 Create self signed cert if one does not exist 2015-01-18 23:49:06 -05:00
Luke Pulverenti 0840bb9ba2 move web socket classes to server project 2014-12-27 13:06:32 -05:00
Luke Pulverenti 2e53ff1fd0 move files out of common 2014-12-26 14:34:39 -05:00
Luke Pulverenti 0ec3d217e7 sync updates 2014-12-26 12:45:06 -05:00
Luke Pulverenti 576768de59 update translations 2014-11-25 23:12:29 -05:00
Luke Pulverenti 9f3891d418 render movies as folders with dlna 2014-10-22 00:42:26 -04:00
Luke Pulverenti ab3c26c564 update connect 2014-10-13 16:14:53 -04:00
Luke Pulverenti cce120d8d3 refresh connect authorizations 2014-10-12 13:31:41 -04:00
Luke Pulverenti 314a51dff3 add more device options 2014-10-11 21:46:02 -04:00
Luke Pulverenti f3539686bd add device upload options 2014-10-11 16:38:13 -04:00
Luke Pulverenti 0690b4f2e0 Add user cinema mode setting 2014-10-01 20:28:16 -04:00
Luke Pulverenti c05cb1dcb1 fix mac ffmpeg build 2014-09-28 12:50:33 -04:00
Luke Pulverenti b314199319 resolve wtv transcoding 2014-09-09 20:28:59 -04:00
Luke Pulverenti a3d553a7fb set connect access token 2014-09-02 22:30:05 -04:00
Luke Pulverenti 21d88faa18 added json subtitle output 2014-08-22 11:47:44 -04:00
Luke Pulverenti e3c8694471 3.0.5340.20849 2014-08-15 12:35:41 -04:00
Luke Pulverenti e3c52b6f73 support srt in didl 2014-08-05 22:26:12 -04:00
Luke Pulverenti 51e964dae3 support channels with dlna 2014-07-29 23:31:35 -04:00
Luke Pulverenti ce20066bc0 update translations 2014-07-20 00:46:29 -04:00
Luke Pulverenti bc657237aa consolidate web socket onto one port 2014-07-18 21:28:40 -04:00
Luke Pulverenti ea559a6e27 create http listener abstraction 2014-07-18 18:14:59 -04:00
Luke Pulverenti 06118307dd disable chunked encoding for images 2014-07-17 18:21:35 -04:00
Luke Pulverenti e2052c771d added new device profiles 2014-07-16 23:17:14 -04:00
Luke Pulverenti 7fa9b14f56 fixes #762 - Marking unwatched doesn't update display 2014-07-03 22:22:57 -04:00
Luke Pulverenti 933443c2b9 added modular configuration 2014-06-29 13:35:05 -04:00
Luke Pulverenti 77ad0fc336 fixes #674 - Support converting subtitles to webvtt 2014-06-11 10:42:03 -04:00
Luke Pulverenti 3640f62086 create collections from movies page 2014-06-03 23:34:36 -04:00
Luke Pulverenti 858c37b860 add channel downloading settings 2014-06-02 15:32:41 -04:00
Luke Pulverenti 715119b525 updated nuget 2014-05-17 14:37:40 -04:00
Luke Pulverenti 92cadc4323 update translations 2014-05-16 13:11:07 -04:00
Luke Pulverenti 4e81655239 updated mono build 2014-05-10 13:28:03 -04:00
Luke Pulverenti dce9093ba1 split files into separate classes 2014-05-08 17:23:24 -04:00
Luke Pulverenti 0d025f7fb6 beginning remote subtitle downloading 2014-05-06 22:28:19 -04:00
Luke Pulverenti ac69327f1f check in open subtitles stub 2014-05-05 00:36:45 -04:00
Luke Pulverenti 4331700747 support sending upnp events 2014-04-21 12:02:30 -04:00
Luke Pulverenti 2c6a9892f2 update translations 2014-04-08 00:17:18 -04:00
Luke Pulverenti 501dedb13c stub out dlna server 2014-03-24 08:47:39 -04:00
Luke Pulverenti 30496c1168 made dlna logging optional 2014-03-14 13:09:22 -04:00
Luke Pulverenti 13563b6047 Add upnp configuration 2014-02-25 23:38:21 -05:00
Luke Pulverenti aef805efb9 fix directory not found error in episode organization 2014-02-25 10:40:16 -05:00
Luke Pulverenti a4b40ad9d9 handle year in name when searching 2014-02-13 23:00:13 -05:00
Luke Pulverenti be1ce0f802 convert static remote streaming to use internal interfaces 2014-02-13 11:38:43 -05:00
MrSmoke 6657ce2145 Added missing method to IHttpClient 2014-02-12 09:24:22 +11:00
Luke Pulverenti ec4000404d rework text subtitles 2014-01-10 08:52:01 -05:00
Luke Pulverenti 247a40fa61 add console logging during startup 2014-01-08 23:44:51 -05:00
Luke Pulverenti b9d17c9bc7 add more methods to file system interface 2014-01-01 13:26:31 -05:00
Luke Pulverenti 74f0d8bdbe minor dashboard cleanup 2013-12-25 22:44:26 -05:00
Luke Pulverenti cb9b570a2a live tv updates 2013-12-16 13:44:03 -05:00
Luke Pulverenti f32212d160 update to service stack v4 2013-12-07 10:52:38 -05:00
Luke Pulverenti 0bdc8a49d5 switch from httpclient to plain httpwebrequest 2013-11-30 01:07:25 -05:00
Luke Pulverenti 05378c82cb fixes #582 - support tbn image files. 2013-10-13 01:56:44 -04:00
Luke Pulverenti 478be44dd6 create platform-specific network manager implementation 2013-10-05 13:13:32 -04:00
Luke Pulverenti eb72c2db51 updated nuget 2013-10-02 21:22:50 -04:00
Luke Pulverenti 755d98edc0 improved messages with startup failures 2013-09-20 11:37:05 -04:00
Luke Pulverenti 60780399c5 allow request header overrides 2013-09-17 22:43:34 -04:00
Luke Pulverenti ebec1e159c update default theme endpoints 2013-09-15 13:34:37 -04:00
Luke Pulverenti 0d59941539 restored network browser 2013-09-06 16:25:03 -04:00
Luke Pulverenti 98e7eeeff9 reduce byte conversions with alchemy web socket 2013-09-05 17:34:46 -04:00
Luke Pulverenti 7b6bf545da removed network option from directory picker due to unreliability 2013-09-05 10:42:17 -04:00
Mark Linton 64f06c2a1b One last mime type 2013-08-31 11:20:10 -07:00
Mark Linton bceac2ff26 Add document mime types. 2013-08-31 11:04:06 -07:00
Luke Pulverenti 7e5bdc837a added GetTempFileResponse 2013-07-20 17:36:59 -04:00
Luke Pulverenti 8a1b12b7d8 tightened up image saving to reduce knowledge of file names 2013-06-28 16:25:58 -04:00
Luke Pulverenti 847d6f6ba3 removed unused methods 2013-06-08 13:03:21 -04:00
Luke Pulverenti 085e597a2e improve accuracy of local ip address discovery 2013-05-27 14:34:03 -04:00
Luke Pulverenti 390f165332 #280 - avoid an extra request to last fm by taking data from the MusicArtist entity 2013-05-27 11:02:16 -04:00
Luke Pulverenti 3a587a5d08 updated browse to command 2013-05-25 20:53:51 -04:00
Luke Pulverenti a3ecf6c2b7 localize library changed messages per user 2013-05-21 23:42:25 -04:00
Luke Pulverenti c11c8bfdb4 re-enable http compression for all providers except for last fm 2013-05-20 14:03:09 -04:00
Luke Pulverenti c568f352eb replaced http client cache with longer lived cache 2013-05-06 15:31:57 -04:00
Luke Pulverenti 87598ca6d0 add customizable accept header to http client interface 2013-05-04 00:07:27 -04:00
Luke Pulverenti 58c77529d2 removed superfluous GetMemoryStream 2013-04-20 18:19:55 -04:00
Luke Pulverenti 9f06eb781f fixes #97 and creates a library dictionary cache to avoid FindById recursion 2013-03-31 13:39:28 -04:00
Luke Pulverenti 31bb5b5cb3 removed udp server layer 2013-03-27 18:13:46 -04:00
Luke Pulverenti 62521eabc2 update to latest js api client 2013-03-26 00:33:47 -04:00
Luke Pulverenti a6c9fdd0f2 Moved some web socket classes to the model 2013-03-25 23:01:47 -04:00
Luke Pulverenti e2dcddc5ac made compression and caching available to plugin api endpoints 2013-03-23 22:45:00 -04:00
LukePulverenti bae89ee824 fix duplicate connections on the dashboard 2013-03-16 12:41:49 -04:00
LukePulverenti fe1834e6be Add resume capability to GetTempFile 2013-03-14 15:52:53 -04:00
LukePulverenti f9e760cd90 removed object disposed catch 2013-03-11 15:27:25 -04:00
LukePulverenti fe91772f18 fixed semaphore dispose issue 2013-03-11 12:54:52 -04:00
LukePulverenti 332f635939 Added IHttpResultFactory 2013-03-08 12:25:25 -05:00
LukePulverenti 4f67fc4aef removed base kernel and ikernel 2013-03-07 00:34:00 -05:00
LukePulverenti 2ca4b7d03a Created IConfigurationManager 2013-03-04 00:43:06 -05:00