BaronGreenback
ebd589aa86
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:57:39 +01:00
BaronGreenback
a3140f83c6
Revert "Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored."
...
This reverts commit 2aaecb8e14
2020-04-28 21:51:49 +01:00
BaronGreenback
2aaecb8e14
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:45:46 +01:00
Mark Monteiro
bc4e72b29b
Create ApplicationHost logger correctly
2020-04-20 20:48:39 -04:00
Mark Monteiro
f815059698
Merge remote-tracking branch 'upstream/master' into register-services-correctly
2020-04-20 20:11:33 -04:00
Vasily
07143bcb68
Merge pull request #2466 from dkanada/plugin
...
Update plugin classes for nightly builds
2020-04-21 01:45:52 +03:00
dkanada
eda208e258
Merge pull request #2829 from Bond-009/warn19
...
Fix some warnings
2020-04-19 12:04:02 +09:00
Bond_009
d6daac5064
Fix build
2020-04-15 11:12:58 +02:00
Mark Monteiro
9728aa8b0a
Merge branch 'master' into register-services-correctly
2020-04-13 17:06:24 -04:00
dkanada
cb2523e2ef
merge branch master into plugin
2020-04-13 14:38:19 +09:00
Bond-009
3d611743ed
Merge pull request #2680 from mark-monteiro/remove-common-process
...
Remove CommonProcess and ProcessFactory
2020-04-11 20:30:20 +02:00
Mark Monteiro
7152b55747
Use a separate line for each property initializer
2020-04-11 13:28:21 -04:00
Mark Monteiro
17e8813378
Use ActivatorUtilities to construct MediaEncoder and update constructor to inject EncodingHelper correctly
2020-04-11 10:53:13 -04:00
Mark Monteiro
1e1295bebf
Merge remote-tracking branch 'upstream/master' into register-services-correctly
2020-04-11 10:00:39 -04:00
dkanada
bd55bdb4e3
merge branch master into plugin
2020-04-11 20:10:16 +09:00
dkanada
8e9aeb84b1
remove release channel from plugin classes
2020-04-11 19:33:36 +09:00
Bond_009
49fe5e0a21
Fix some warnings
2020-04-11 12:03:10 +02:00
dkanada
0cd7cd611e
Merge pull request #2758 from Bond-009/plugininstalled
...
Remove PluginInstalled
2020-04-06 19:01:15 +09:00
Mark Monteiro
f91f2ef328
Merge remote-tracking branch 'upstream/master' into register-services-correctly
2020-04-05 10:07:17 -04:00
Mark Monteiro
f2760cb055
Register IImageEncoder in Jellyfin.Server instead of Emby.Server.Implementations
2020-04-05 10:03:53 -04:00
Bond-009
29539174a3
Merge pull request #2636 from mark-monteiro/development-https
...
Use ASP.NET Core HTTPS Development Certificate
2020-04-05 15:09:27 +02:00
Mark Monteiro
bc91445b5d
Use correct naming convention for _relevantEnvVarPrefixes
2020-04-05 09:05:23 -04:00
Mark Monteiro
735d6c8ad5
Convert properties in ApplicationHost to private readonly fields, where possible
2020-04-04 23:18:47 -04:00
Mark Monteiro
241d0ae65c
Inject IStartupOptions into StartupWizard
2020-04-04 23:14:35 -04:00
Mark Monteiro
809cf3a0c2
Register IJsonSerializer correctly
2020-04-04 21:33:57 -04:00
Mark Monteiro
710767fbf2
Add deprecation warning message for injecting ILogger
2020-04-04 21:27:48 -04:00
Mark Monteiro
e16c16dd51
Register and construct IHttpClient correctly
2020-04-04 21:18:09 -04:00
Mark Monteiro
adf0e8d3fd
Register and construct ITaskManager and IIsoManager correctly
2020-04-04 21:00:11 -04:00
Mark Monteiro
3f2f95d877
Register IProcessFactory, ICryptoProvider and ISocketFactory correctly
2020-04-04 20:42:11 -04:00
Mark Monteiro
aee6a1b476
Remove unnecessary async and parameter from ApplicationHost initialization method
2020-04-04 20:40:50 -04:00
Mark Monteiro
5d648bf54f
Register and construct ILocalizationManager correctly
2020-04-04 20:21:48 -04:00
Mark Monteiro
cbc0224aaf
Register IStreamHelper, IInstallationManager, IZipClient, IHttpResultFactory and IBlurayExaminer correctly
2020-04-04 20:00:55 -04:00
Mark Monteiro
615717e562
Register and construct IUserDataManager and IUserDataRepository correctly
2020-04-04 19:57:26 -04:00
Mark Monteiro
5827f0f5a9
Register IDisplayPreferencesRepository correctly
2020-04-04 19:40:53 -04:00
Mark Monteiro
a5234dfd88
Register and construct IAuthenticationRepository correctly
2020-04-04 19:36:27 -04:00
Mark Monteiro
4daa5436fc
Register and construct IUserManager and IUserRepository correctly
2020-04-04 19:31:14 -04:00
Mark Monteiro
84b48eb69c
Convert MediaEncoder property to field
2020-04-04 19:01:21 -04:00
Mark Monteiro
fe9f4e06d1
Register and construct LibraryManager correctly
2020-04-04 18:28:46 -04:00
Mark Monteiro
7fd25f94f3
Inject and construct ISearchEngine and IMusicManager correctly
2020-04-04 18:22:29 -04:00
Mark Monteiro
c2b21ce553
Register and construct ILibraryMonitor correctly
2020-04-04 17:33:00 -04:00
Mark Monteiro
d173358065
Move ApplicationHost certificate initialization to constructor
2020-04-04 17:19:16 -04:00
Mark Monteiro
07cebbeae2
Register and construct IImageProcessor, SqliteItemRepository and IImageEncoder correctly
2020-04-04 17:12:24 -04:00
Mark Monteiro
efe3ebaab8
Eliminate circular dependency between LibraryManager and ImageProcessor
2020-04-04 16:01:10 -04:00
Mark Monteiro
11693d6024
Register ITvManagerService correctly
2020-04-04 15:44:44 -04:00
Mark Monteiro
71c84905de
Register IDeviceManager correctly
2020-04-04 15:40:06 -04:00
Mark Monteiro
573da63d41
Register and construct IMediaSourceManager correctly
2020-04-04 15:28:21 -04:00
Mark Monteiro
dd5a55aeba
Register ISubtitleManager correctly
2020-04-04 15:12:02 -04:00
Mark Monteiro
0ce82ab332
Remove unnecessary fields in ApplicationHost
2020-04-04 15:05:50 -04:00
Mark Monteiro
51b9a6e94b
Register IProviderManager correctly
2020-04-04 14:56:50 -04:00
Mark Monteiro
75b05ca1e6
Register and construct DtoService correctly
2020-04-04 14:41:03 -04:00
