Commit graph

1851 commits

Author SHA1 Message Date
cvium 0835b26889 review 2021-05-31 13:55:54 +02:00
Claus Vium 2d5ed7cb95
Apply suggestions from code review
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-05-28 19:01:08 +02:00
cvium 42a2cc1747 Remove some unnecessary allocations 2021-05-24 00:30:41 +02:00
Bond-009 a7b7ff000b
Merge branch 'master' into tmdb-person-language 2021-05-20 22:46:40 +02:00
David Ullmer ee7a95e088 Move GetMetadataLanguage 2021-05-18 13:44:38 +02:00
David Ullmer 6353966abd Fix cache key 2021-05-18 13:17:34 +02:00
David Ullmer 96e05e5b66 Add tests for NoralizeLanguage 2021-05-17 12:55:27 +02:00
cvium 81ac11828b Fix ArrayIndexOutOfBounds 2021-05-16 20:16:47 +02:00
cvium 1b49435a0e Reduce some allocations 2021-05-16 14:49:11 +02:00
Bond-009 f06f3450c1
Merge pull request #5307 from barronpm/using-declarations 2021-05-16 09:58:10 +00:00
Patrick Barron 81992ef205 Fix build 2021-05-13 10:47:00 -04:00
David Ullmer c584d36fd4 Fix Tmdb person language 2021-05-12 14:57:58 +02:00
David Ullmer cb01dd8684 Use TMDb parental rating building from movies for shows 2021-05-10 20:56:20 +02:00
Patrick Barron e55f35b62e
Merge branch 'master' into using-declarations 2021-05-10 09:05:12 -04:00
wehrstedt ad1d9d9a23
fixed no channel icons when using tvheadend (#5996)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Maximilian Wehrstedt <wehrstedt.coding@outlook.de>
2021-05-06 23:07:32 +02:00
Bond_009 ddb04dc12b Use new ReadAllLines extensions 2021-05-06 14:12:43 +02:00
Bond_009 e432796f6f Minor improvements 2021-05-05 14:39:50 +02:00
BaronGreenback 2e98de9062
Code Clean up: Convert to null-coalescing operator ?? (#5845)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
BaronGreenback f2c10471bf
Code Clean up: Use Pattern Matching (#5838)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:37:36 +02:00
Bond_009 e128b6d997 TmdbUtils: Use ordinal string compare 2021-05-01 15:59:21 +02:00
cvium 77261a8445 add UpdatePeopleAsync and add people to both tables 2021-04-24 20:22:23 +02:00
Bond-009 e19d89bb4f
Merge pull request #5881 from cvium/tmdb-episode-externalids
Add tvrage and imdb ids for episodes
2021-04-21 16:15:53 +02:00
Bond-009 aa992efd31
Update MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeProvider.cs 2021-04-21 16:15:31 +02:00
Bond-009 86a2e6eeda
Merge pull request #5867 from Bond-009/provider
ProviderManager: fix discard and 2 warnings
2021-04-21 13:53:53 +02:00
Bond-009 6b103f7ab2
Merge pull request #5870 from cvium/fix-tmdbpersonprovider 2021-04-21 13:53:41 +02:00
Bond-009 da78a96312
Merge pull request #5807 from Bond-009/refreshdelay
Remove throttle in refresh code
2021-04-21 13:52:05 +02:00
cvium 96348ed744 Add tvrage and imdb ids for episodes 2021-04-21 08:33:29 +02:00
cvium c0ea56a10d use int.Parse 2021-04-20 13:35:08 +02:00
Bond-009 94d339cf12
Merge pull request #5744 from mohd-akram/absolute-dvd-order 2021-04-20 13:29:31 +02:00
cvium 06b8cf42d1 Fix TMDb Person Provider 2021-04-20 08:59:15 +02:00
Bond_009 dcd6ab769b ProviderManager: fix discard and 2 warnings 2021-04-19 23:52:58 +02:00
Bond-009 4c915f5edf
Merge pull request #5683 from jellyfin/dependabot/nuget/Newtonsoft.Json-13.0.1
Bump Newtonsoft.Json from 12.0.3 to 13.0.1
2021-04-19 15:11:11 +02:00
Mohamed Akram 64071873a0 Use StringComparison.Ordinal 2021-04-19 16:51:44 +04:00
Mohamed Akram 90b941b3f6 Add review changes 2021-04-19 14:59:24 +04:00
cvium 351b987982 Add Person to TypedBaseItems if it's new 2021-04-18 12:34:33 +02:00
BaronGreenback bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
Bond_009 3d0a42da9e Remove throttle in refresh code 2021-04-13 20:09:50 +02:00
dependabot[bot] d459f625d5
Bump Newtonsoft.Json from 12.0.3 to 13.0.1
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](https://github.com/JamesNK/Newtonsoft.Json/compare/12.0.3...13.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-13 17:11:49 +00:00
Bond-009 51af569159
Merge pull request #5802 from jellyfin/dependabot/nuget/TMDbLib-1.8.1
Bump TMDbLib from 1.7.3-alpha to 1.8.1
2021-04-13 19:10:59 +02:00
Bond_009 2b948aead9 Fix possible ArgumentNullException
```
System.ArgumentNullException: Value cannot be null. (Parameter 'source')
   at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.GetImages(BaseItem
           item, IRemoteImageProvider provider, IReadOnlyCollection`1
           preferredLanguages, CancellationToken cancellationToken,
           Nullable`1 type) in
   /home/bond/dev/jellyfin/MediaBrowser.Providers/Manager/ProviderManager.cs:line
   280
```
2021-04-13 19:53:09 +02:00
dependabot[bot] f1c4b541c1
Bump TMDbLib from 1.7.3-alpha to 1.8.1
Bumps [TMDbLib](https://github.com/LordMike/TMDbLib) from 1.7.3-alpha to 1.8.1.
- [Release notes](https://github.com/LordMike/TMDbLib/releases)
- [Commits](https://github.com/LordMike/TMDbLib/compare/v1.7.3-alpha...v1.8.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-13 13:09:28 +00:00
cvium 35cfd760d4 Do not touch "old" local artwork unless saving locally 2021-04-11 00:27:53 +02:00
Mohamed Akram ce4f730221 Add support for TMDB series absolute and DVD order 2021-04-09 20:02:23 +04:00
Bond_009 2ed0801be2 Fix possible nullref
when `ProviderManager.SaveMetadata` gets called before
`ProviderManager.AddParts`

```
Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'source')
  Stack Trace:
     at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 674
   at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in D:\a\1\s\MediaBrowser.Providers\Manager\ProviderManager.cs:line 655
   at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 2012
   at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 1970
   at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 775
   at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in D:\a\1\s\Emby.Server.Implementations\Library\LibraryManager.cs:line 180
   at Emby.Server.Implementations.IO.LibraryMonitor.Start() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitor.cs:line 135
   at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in D:\a\1\s\Emby.Server.Implementations\IO\LibraryMonitorStartup.cs:line 26
   at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 541
   at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
   at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in D:\a\1\s\Emby.Server.Implementations\ApplicationHost.cs:line 525
   at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\JellyfinApplicationFactory.cs:line 101
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
   at Jellyfin.Server.Integration.Tests.OpenApiSpecTests.GetSpec_ReturnsCorrectResponse() in D:\a\1\s\tests\Jellyfin.Server.Integration.Tests\OpenApiSpecTests.cs:line 26
--- End of stack trace from previous location ---
```
2021-04-04 01:45:15 +02:00
Bond-009 7c51d0a50e
Merge pull request #5671 from jellyfin/tmdbmovieprovider-originaltitle
set original title in tmdbmovieprovider
2021-04-01 17:39:22 +02:00
Claus Vium df60d176b8
ensure only valid images are saved in ItemImageProvider 2021-04-01 15:27:28 +02:00
Claus Vium 28a0eb6d53
set original title in tmdbmovieprovider 2021-04-01 14:28:03 +02:00
Bond-009 16011d96a0
Merge pull request #5321 from Ullmie02/nfo-thumb 2021-03-25 01:10:37 +01:00
David a4cac09d5b Use |= 2021-03-23 19:25:32 +01:00
Erwin de Haan 470305f75e Authenticated arbitrary file overwrite in SubtitleController -> SubtitleManager
GHSL-2021-050: Issue 5 Arbitrary file overwrite.
2021-03-20 01:14:59 +01:00