Commit graph

25 commits

Author SHA1 Message Date
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Cody Robibero 13df026f6b Merge pull request #7654 from Shadowghost/nfo-provider-fix
Prefer MetadataProvider enum as provider id key over arbitrary strings

(cherry picked from commit a2abae3014)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-28 09:26:45 -04:00
BaronGreenback 2e98de9062
Code Clean up: Convert to null-coalescing operator ?? (#5845)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
cvium 8b72b902f5 fix HasProviderId and add tests 2021-03-03 12:28:40 +01:00
cvium a49f5d2a44 revert removal of null check 2021-03-03 09:37:21 +01:00
cvium 664c5da317 return false when providerid is null or empty 2021-03-03 09:09:57 +01:00
Bond_009 ba62d9d1fe Revert breaking change 2021-03-01 20:35:38 +01:00
Bond_009 02848189e3 MaybeNullWhen(false) -> NotNullWhen(true) 2021-02-28 00:10:36 +01:00
Bond_009 941d3f6217 Add tests for ProviderIdsExtensions 2021-02-19 17:01:52 +01:00
Bond_009 b2700ecf44 TMDB: Also search with IMDB or TVDB Id if specified 2021-02-19 16:09:23 +01:00
crobibero ca5f87c7eb Fix get provider id extension 2020-12-14 07:20:16 -07:00
crobibero d5e2369dd6 Fix nullability errors in MediaBrowser.Model 2020-11-13 09:36:17 -07:00
aled 22a860a806 Fix a small number of compile warnings 2020-06-06 20:17:49 +01:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Bond_009 f47ad85011 Fix warnings MediaBrowser.Model 2020-02-04 01:49:27 +01:00
Erwin de Haan 38f96af079 Reformat JustAMan review pt2 changes
Refs #575
2019-01-17 20:24:39 +01:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 382e8699a2 EditorConfig reformat: MediaBrowser.Model 2019-01-13 20:31:15 +01:00
Erwin de Haan e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Andrew Rabert a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti bb031f553b fix portable and 3.5 project references 2014-05-08 16:26:20 -04:00