BaronGreenback
d99db543da
Update DescriptionXmlBuilder.cs
2020-09-16 12:08:37 +01:00
BaronGreenback
a6400d12c9
Update DescriptionXmlBuilder.cs
2020-09-16 12:08:23 +01:00
BaronGreenback
c2e2e5ac0c
Update DescriptionXmlBuilder.cs
2020-09-16 12:03:17 +01:00
BaronGreenback
86ad04b657
Update DescriptionXmlBuilder.cs
2020-09-16 12:02:00 +01:00
Jim Cartlidge
38b8110a3e
Removing blank lines.
2020-09-14 15:55:25 +01:00
Jim Cartlidge
b44455ad0d
Update based on PR1 changes.
2020-09-14 15:46:38 +01:00
Jim Cartlidge
c41ed13b3d
Commenting.
2020-09-13 14:36:10 +01:00
Jim Cartlidge
c1b3f2c136
ContentDirectory
2020-09-13 14:31:12 +01:00
Jim Cartlidge
3ad320175d
ConnectionManager - static implementation
2020-09-13 14:18:15 +01:00
Jim Cartlidge
68de105dc2
Comments part 1
2020-09-13 13:49:11 +01:00
Jim Cartlidge
9ef79d190b
Large number of files
2020-09-12 16:41:37 +01:00
Bond-009
18fe328979
Merge pull request #4084 from BaronGreenback/PlayTo-url-corruption-fix
...
Unstable: PlayTo corruption url fix
2020-09-10 15:35:06 +00:00
BaronGreenback
c84aabe954
Update PlayToManager.cs
...
Fixed name violation
2020-09-08 09:27:44 +01:00
BaronGreenback
fde5afc36b
Update PlayToManager.cs
...
removed tab
2020-09-08 09:26:52 +01:00
BaronGreenback
544db8cc06
Update PlayToManager.cs
...
made code more readable.
2020-09-08 07:53:53 +01:00
Anthony Lavado
3aee338066
Merge pull request #4073 from Bond-009/useafterdispose
...
Fix ObjectDisposedException
2020-09-07 19:39:42 -04:00
BaronGreenback
ed9021f40b
Update PlayToManager.cs
2020-09-07 21:43:48 +01:00
Bond-009
c750632cfc
Merge pull request #4065 from BaronGreenback/dlna_serverfix
...
Bug Fix : DLNA Server advertising
2020-09-07 12:36:03 +00:00
BaronGreenback
a2687fac5e
Merge branch 'master' into simplified_dlnamanager
2020-09-07 12:29:31 +01:00
BaronGreenback
03d8f6f43b
Update DlnaManager.cs
...
removed space.
2020-09-07 12:27:55 +01:00
BaronGreenback
b673f5bcde
Update DlnaManager.cs
2020-09-07 12:27:26 +01:00
BaronGreenback
eedb520af1
Removed code that wasn't used.
2020-09-07 12:14:02 +01:00
BaronGreenback
6a5df73151
Update DlnaManager.cs
...
Changed function name to IsRegexOrSubstringMatch
2020-09-07 12:09:15 +01:00
BaronGreenback
12d0f29dea
Update Emby.Dlna/DlnaManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-09-07 12:07:57 +01:00
Bond_009
343fc8c668
Fix ObjectDisposedException
...
```
System.Net.Http.HttpRequestException: An error occurred while sending the request.
---> System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Http.StringContent'.
at System.Net.Http.HttpContent.CheckDisposed()
at System.Net.Http.HttpContent.CopyToAsync(Stream stream, TransportContext context, CancellationToken cancellationToken)
at System.Net.Http.HttpConnection.SendRequestContentAsync(HttpRequestMessage request, HttpContentWriteStream stream, CancellationToken cancellationToken)
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.FinishSendAsyncUnbuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
at Emby.Dlna.PlayTo.SsdpHttpClient.SendCommandAsync(String baseUrl, DeviceService service, String command, String postData, String header, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/SsdpHttpClient.cs:line 41
at Emby.Dlna.PlayTo.Device.GetTransportInfo(TransportCommands avCommands, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/Device.cs:line 629
at Emby.Dlna.PlayTo.Device.TimerCallback(Object sender) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/Device.cs:line 445
```
2020-09-07 12:22:33 +02:00
BaronGreenback
babdd30a46
Renamed IsRegExMatch to IsPropertyMatch
2020-09-05 21:49:30 +01:00
BaronGreenback
ebad504f3b
Fixed profile
2020-09-05 21:25:47 +01:00
BaronGreenback
e3fdea2ec9
Update DlnaManager.cs
...
Fix for #4060
2020-09-05 19:48:37 +01:00
crobibero
2a8653b309
Merge remote-tracking branch 'upstream/master' into http-client-migrate
2020-09-04 08:16:49 -06:00
crobibero
d8a0edc511
Revert "Remove ResponseHeadersRead where applicable"
...
This reverts commit 85844a84b6
.
2020-09-03 07:20:33 -06:00
crobibero
85844a84b6
Remove ResponseHeadersRead where applicable
2020-09-03 06:48:19 -06:00
crobibero
b398c35068
use UserAgent.ParseAdd where possible
2020-09-01 13:16:19 -06:00
crobibero
4038d15c83
Properly migrate all HttpCompletionOption
2020-09-01 07:51:06 -06:00
Bond_009
e653eef44f
Fix some warnings
2020-08-31 22:20:19 +02:00
crobibero
c02d0ceb57
Add missing using
2020-08-31 12:45:23 -06:00
crobibero
8215f15c45
migrate to IHttpClientFactory in Emby.Dlna
2020-08-31 11:26:42 -06:00
Patrick Barron
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Bond_009
170e434f92
Fix all warnings in Emby.Dlna
2020-08-20 21:04:57 +02:00
Bond-009
6292a9e4e9
Merge branch 'master' into warn24
2020-08-20 18:50:15 +02:00
David
1337a0dcec
Code review
2020-08-20 17:59:27 +02:00
David
ca2b36bdb0
Reduce warnings in Emby.Dlna
2020-08-20 17:08:33 +02:00
Bond_009
6123e2e848
Fix build
2020-08-20 12:24:34 +02:00
Bond_009
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
2020-08-20 12:16:24 +02:00
Patrick Barron
98ed90c4a2
Merge branch 'master' into event-rewrite-1
2020-08-19 18:11:17 -04:00
Bond_009
2b400c99ef
Fix warnings
2020-08-19 17:50:50 +02:00
crobibero
09c8597461
inheritdoc
2020-08-16 08:40:43 -06:00
crobibero
7d2ad3e0fc
Fix DlnaControlResponse string return
2020-08-16 08:32:03 -06:00
Patrick Barron
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
2020-08-13 20:52:55 -04:00
Patrick Barron
da9bcc5fb3
Rename IEventManager to IDlnaEventManager
2020-08-13 15:47:31 -04:00
crobibero
f915c3e5d9
Merge remote-tracking branch 'upstream/master' into api-migration
2020-08-03 11:24:13 -06:00
Patrick Barron
3a0bccb941
Merge pull request #2957 from crobibero/api-dlna-server
...
Migrate DlnaServerController to Jellyfin.Api
2020-08-03 17:00:46 +00:00
Bond-009
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
2020-08-01 21:51:49 +02:00
crobibero
3d5f89ebf9
Merge remote-tracking branch 'upstream/api-migration' into api-dlna-server
2020-07-31 10:17:51 -06:00
crobibero
f516cf9c4c
Merge remote-tracking branch 'upstream/api-migration' into api-dlna
2020-07-31 10:05:27 -06:00
Bond_009
d4092846e4
Optimize Substring and StringBuilder usage
2020-07-29 13:17:01 +02:00
Bond-009
3ff110984a
Merge branch 'master' into readonlyspan
2020-07-24 09:40:44 +02:00
Patrick Barron
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore
2020-07-23 23:50:12 +00:00
Joshua M. Boniface
8960d6256f
Merge pull request #3659 from Bond-009/stringbuilder
...
Optimize StringBuilder.Append calls
2020-07-23 18:08:09 -04:00
Joshua M. Boniface
fd82ecd18e
Merge pull request #3595 from Bond-009/xml
...
Improve DescriptionXmlBuilder
2020-07-23 18:06:15 -04:00
Bond-009
89ff865d40
Merge pull request #3508 from BaronGreenback/nullable
...
Part 1: nullable Emby.DLNA
2020-07-22 18:41:58 +02:00
Bond_009
4d681e3cad
Optimize StringBuilder.Append calls
2020-07-22 14:34:51 +02:00
Bond_009
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Bond_009
65453c0a84
Fix build and more Append calls
2020-07-19 21:32:54 +02:00
Bond_009
39be99504f
Improve DescriptionXmlBuilder
...
* Replace XML escape code with SecurityElement.Escape
* Optimize StringBuilder.Append calls
2020-07-19 21:20:18 +02:00
BaronGreenback
672a35db94
Update DlnaServerService.cs
2020-07-19 17:54:09 +01:00
BaronGreenback
f9b0816b80
Changes a suggested.
2020-07-18 16:54:23 +01:00
Patrick Barron
ab396225ea
Migrate Display Preferences to EF Core
2020-07-17 16:11:53 -04:00
BaronGreenback
0f696104ac
using missing.
2020-07-17 16:23:47 +01:00
BaronGreenback
c7c28db17b
Update DlnaServerService.cs
2020-07-17 16:08:26 +01:00
BaronGreenback
d9f9412955
Update DlnaServerService.cs
2020-07-17 12:58:23 +01:00
Patrick Barron
6d1b00da64
Use Array.Empty
2020-07-04 11:54:25 -04:00
Cody Robibero
43221fc26b
Merge branch 'master' into SSDP
2020-06-20 15:33:13 -06:00
telans
7f307f9082
brace multiline if statements
2020-06-20 21:12:36 +12:00
telans
98db8f72e0
fix SA1503 for one line if statements
2020-06-20 20:35:29 +12:00
telans
8e3d874802
remove regions
2020-06-20 18:20:33 +12:00
dkanada
215ab39e00
Merge pull request #3342 from BaronGreenback/BugFix2
...
Fix for [DLNA] Many log messages from Media Renderers trying to see old events
2020-06-16 19:02:16 +09:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629)
2020-06-16 10:37:52 +12:00
BaronGreenback
6d6793151a
Null pointer check added for subscription as 2nd param is false.
2020-06-15 10:10:52 +01:00
telans
3d9049ef08
fix SA1508
2020-06-15 10:45:55 +12:00
telans
acd4389653
fix SA1005
2020-06-15 10:41:00 +12:00
telans
726e116d5b
fix SA1510
2020-06-15 10:40:57 +12:00
Patrick Barron
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
BaronGreenback
4d9171f691
Update DlnaEntryPoint.cs
...
Left a _config behind.
2020-06-11 22:40:43 +01:00
BaronGreenback
5cf44e7736
Removed spaces
2020-06-09 22:11:23 +01:00
BaronGreenback
93568be3e7
Updates
2020-06-09 22:05:22 +01:00
crobibero
57d1dbfe7b
undo erroneous changes
2020-06-05 18:29:58 -06:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Vasily
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
2020-06-03 12:26:54 +03:00
Bond_009
7439e095e2
Merge branch 'master' into nullable3
2020-05-27 20:49:18 +02:00
Bond_009
10e381f66f
Fix some 'bugs' flagged by sonarcloud
2020-05-25 23:52:51 +02:00
Patrick Barron
c464f700db
Remove redundant qualifiers
2020-05-20 13:07:53 -04:00
Patrick Barron
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
2020-05-15 17:20:07 -04:00
Patrick Barron
9ad839c776
Initial migration code
2020-05-12 22:10:35 -04:00
Bond_009
15634a1913
Merge branch 'master' into websocket
2020-05-02 00:54:04 +02:00
BaronGreenback
8a69300bf5
Changes styles as suggested by @barronpm
...
Added addtional comments & source type as per intellisense suggestion
change code as per sonacloud
2020-04-29 12:24:01 +01:00
BaronGreenback
ebd589aa86
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:57:39 +01:00
BaronGreenback
a3140f83c6
Revert "Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored."
...
This reverts commit 2aaecb8e14
.
2020-04-28 21:51:49 +01:00
BaronGreenback
2aaecb8e14
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
2020-04-28 21:45:46 +01:00
Joshua M. Boniface
4fa6d1ccee
Merge pull request #2940 from balu92/master
...
Fix missing colons
2020-04-26 15:22:38 -04:00
Joshua M. Boniface
ca4b6836c1
Merge pull request #2906 from randrey/dlna-nullref-fix
...
Fix InvalidOperationException while browsing via DLNA client.
2020-04-26 15:02:34 -04:00
Bond_009
118f30059c
Merge branch 'master' into nullable4
2020-04-23 11:29:19 +02:00
crobibero
461b298be7
Migrate DlnaServerController to Jellyfin.Api
2020-04-21 19:15:27 -06:00
crobibero
f5385e4735
Move Emby.Dlna DlnaService.cs to Jellyfin.Api
2020-04-21 18:12:46 -06:00
Bond-009
c0b3c11b2e
Merge pull request #2846 from jellyfin/azure
...
Remove requirement to build web during server builds
2020-04-22 00:17:44 +02:00
Mark Monteiro
c5f163293f
Add <ProjectGuid> properties to all project files
...
This is required for SonarCloud analysis to run
2020-04-21 16:21:09 -04:00
Unknown
80f5dd1e59
Fixed missing colons
...
some colons were missing from the default ProtocolInfo string
2020-04-20 13:52:50 +01:00
randrey
0bef4eef87
Fix InvalidOperationException while browsing via DLNA client.
2020-04-17 14:45:56 -07:00
a1
eba781eac5
Fix DLNA clients displaying wrong album art.
2020-04-16 23:36:43 -07:00
Bond_009
2fcbc2a5b8
Enable nullabe reference types for Emby.Drawing and Jellyfin.Drawing.Skia
2020-04-05 21:19:04 +02:00
Bond_009
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
2020-04-05 18:10:56 +02:00
Vasily
d5cc10d7e1
Merge pull request #2741 from Bond-009/dlnawarnings2
...
Fix some warnings
2020-04-04 01:38:09 +03:00
Bond-009
64692af1a2
Update Device.cs
2020-04-04 00:24:36 +02:00
Bond-009
91b17e7289
Update Device.cs
2020-04-04 00:21:26 +02:00
Bond-009
4cacfd5997
Update DidlBuilder.cs
2020-04-03 23:20:04 +02:00
Bond-009
ad0e2e42e6
Update Device.cs
2020-04-03 23:13:45 +02:00
Bond_009
3161e85f76
Address comments
2020-04-03 17:30:01 +02:00
Bond-009
f6c9a44703
Update Device.cs
2020-04-03 16:46:14 +02:00
Bond-009
231c1e519f
Update Emby.Dlna.csproj
2020-04-03 16:44:40 +02:00
Vasily
a37b69a493
Merge pull request #2559 from whooo/295-fix
...
Add descriptive TV episode titles for DLNA browsing
2020-04-03 17:39:33 +03:00
Bond_009
8a566dfe73
Fix build
2020-04-02 17:07:37 +02:00
Bond_009
be8ba96183
Fix some warnings
2020-04-02 16:52:11 +02:00
Bond-009
62a18af17a
Update Emby.Dlna/Main/DlnaEntryPoint.cs
...
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
2020-04-01 18:50:19 +02:00
Erik Larsson
b63ed35238
Add descriptive TV episode titles for DLNA browsing
...
When browsing TV episodes in Next Up, etc via DLNA a more descriptive
title should be used to easier identify the right episode.
2020-03-27 06:34:22 +01:00
Bond_009
e9d1eabd53
Remove unused usings
2020-03-24 16:12:06 +01:00
Bond-009
94fe9b8f6d
Merge branch 'master' into warn17
2020-03-11 20:26:43 +01:00
Mark Monteiro
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Bond_009
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Claus Vium
241e351a61
Merge branch 'master' into dlnawarnings
2020-02-03 13:51:34 +01:00
dkanada
b7a9900556
Merge pull request #2357 from Bond-009/warn13
...
Fix warnings
2020-02-03 17:15:03 +09:00
Bond_009
87d2479b78
Fix warnings
2020-01-31 22:26:53 +01:00
dkanada
cd13f718fb
Merge pull request #2247 from Bond-009/stringhelper
...
Remove StringHelper functions
2020-02-01 03:29:16 +09:00
Bond-009
d69870680b
Close xmlwriter first
2020-01-29 17:30:27 +01:00
Bond_009
6ee04855cd
Style
2020-01-28 21:54:51 +01:00
Bond-009
ae9c1e29e7
My bad
2020-01-28 17:50:25 +01:00
Bond-009
36d62c3093
Fix?
2020-01-28 13:19:25 +01:00
Bond_009
6b68521bae
Try again
2020-01-27 23:34:40 +01:00
Bond_009
fc578de3b3
Try possible solutions
2020-01-27 22:43:58 +01:00
Bond-009
bade35958a
Fix
2020-01-26 17:41:34 +01:00
Bond-009
3a338c1899
Address comments
2020-01-26 17:37:47 +01:00
Bond-009
c8409d2ea1
Remove FileSystem.GetStream
2020-01-22 22:20:35 +01:00
Bond_009
82112b6788
Improvements to dlna server
...
* Improve response writer
* Add analyzers
* Error on warnings in release mode
* Disable doc warnings
2020-01-22 21:00:07 +01:00
dkanada
1dd4abebbd
Merge pull request #2297 from Bond-009/asyncio
...
Kestrel doesn't like sync IO operations
2020-01-23 01:59:52 +09:00
Bond-009
5340eb9363
Update Emby.Dlna/Service/BaseControlHandler.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2020-01-22 17:46:26 +01:00
Bond-009
ac3b958c67
Use async methods
2020-01-21 17:59:41 +01:00
Carey Metcalfe
f2eea89ff0
Fix pagination for DLNA root folder list
...
Previously, when responding to a DLNA "Browse" request, the
`StartingIndex` was not respected and all of the root items were
returned each time. This caused infinite loops with in DLNA clients that
ignored the `TotalMatches` data in the response and just continued
asking for the next page until they got an empty response.
This fix makes the root folder list respect the `StartingIndex` and
`RequestedCount` parameters like all other responses.
Fixes issue #2303
2020-01-19 01:37:52 -05:00
Bond_009
2610f377c0
Kestrel doesn't like sync IO operations
2020-01-18 00:09:25 +01:00
Bond_009
976459d3e8
Rewrite WebSocket handling code
2020-01-13 20:06:08 +01:00
Bond-009
fdbb329118
Remove StringHelper functions
2020-01-09 17:07:13 +01:00
Bond-009
49330e3082
Fix a couple of TODOs
2019-12-30 16:03:20 +01:00
dkanada
dee3076eaf
Merge pull request #1923 from Bond-009/random
...
Don't shuffle some types by default
2019-12-10 22:28:44 +09:00
Bond-009
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
2019-12-06 12:06:13 +01:00
Bond-009
94edb5b9f9
Add else
2019-12-06 11:58:45 +01:00
Bond-009
a6f883345f
Reduce #lines
2019-12-05 17:44:46 +01:00
Bond_009
3221e837f9
* Add support for multi segment base urls
...
* Make baseurl case-insensitive
2019-11-25 11:55:24 +01:00
Bond-009
69d76af054
dlna GetPathValue
...
Forgot to update this last time, just copied the code from `MediaBrowser.Api/BaseApiService.cs`
2019-11-25 10:56:23 +01:00
Bond_009
5ee070eb29
Remove leading / from baseurl
2019-11-17 19:53:12 +01:00
Bond-009
d161b9cbfc
Fix GetPathValue function for DLNA service
2019-11-13 16:40:34 +01:00
dkanada
0b02c77691
Merge pull request #1864 from Bond-009/installationmanager
...
Improve IInstallationManager interface
2019-11-13 21:12:52 +09:00
Bond-009
983d38a43b
Merge branch 'master' into installationmanager
2019-11-07 10:50:55 +01:00
Bond_009
b0a25c4237
Use Mono.Nat Nuget package
2019-11-01 21:22:35 +01:00
Bond_009
d529f81cd9
Improve IInstallationManager interface
2019-11-01 17:57:19 +01:00
Bond_009
a245f5a0d4
Rewrite hex encoder/decoder
2019-11-01 17:52:29 +01:00
Bond_009
bbc0875387
Don't shuffle some types by default
2019-10-20 16:08:40 +02:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
marius
3deeca43a1
- use streamInfo.StartPositionTicks if provided over userdata.PlaybackPositionTicks when creating the Samsung Bookmark Info
2019-08-29 02:38:53 +03:00
Bond_009
237db8ae92
Clean up livestreaming code
2019-08-16 21:13:18 +02:00
dkanada
bb04545068
Merge pull request #1614 from Bond-009/docs2
...
Document all public/internal members of Emby.Drawing
2019-08-15 21:01:44 -07:00
Bond_009
838e5d05d5
Document all public/internal members of Emby.Drawing
...
Forces all new public/internal members to be documented.
Enables TreatWarningsAsErrors for Emby.Drawing
2019-08-11 16:52:37 +02:00
Bond_009
5eaf5465a5
Check checksum for plugin downloads
...
* Compare the MD5 checksum when downloading plugins
* Reduced log spam due to http requests
* Removed 'GetTempFileResponse' function from HttpClientManager
* Fixed caching for HttpClientManager
2019-08-11 15:54:58 +02:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Bond-009
8b1bd7ac6b
Use a dictionary to look up mimetypes
2019-07-28 20:20:03 +02:00
Bond_009
ddd1a282ea
Remove IpAddressInfo and IpEndPointInfo classes
2019-07-25 00:15:06 +02:00
Bond_009
b1bd062709
Properly set content type
2019-07-13 17:12:06 -04:00
Bond_009
d405a400aa
Fixes issues with HttpClientManager
2019-07-06 20:04:42 +02:00
bugfixin
87c8f19f19
Move DLNA thumbnail element to after larger image elements
2019-05-16 18:00:38 +00:00
Andrew Rabert
608fd873de
Optimize images with image_optim
2019-04-03 22:58:52 -04:00
Bond-009
d623f616fa
Improved dispose method
2019-03-25 17:32:27 +01:00
Bond-009
fc8de8aead
Check if disposed first
2019-03-25 17:27:24 +01:00
Erwin de Haan
21cc38fcf4
Adjusted AssemblyCopyright attribute values.
2019-03-14 22:17:56 +01:00
Erwin de Haan
ee7bf86e0f
Adjusted the Product Name so the User Agent is correct/better.
2019-03-14 22:11:47 +01:00
Vasily
297f25cfc2
Merge pull request #1059 from Bond-009/os
...
Remove EnvironmentInfo
2019-03-13 00:01:00 +03:00
Bond-009
3ddbda9aca
Merge branch 'master' into xml
2019-03-12 16:37:18 +01:00
Bond-009
decaffed86
Remove EnvironmentInfo
...
This moved the last bit of usefulness of EnvironmentInfo into a static
class.
2019-03-07 22:41:41 +01:00
Vasily
e04a152ed0
Merge pull request #996 from Bond-009/libscan
...
Reduce the amount of exceptions thrown
2019-03-08 00:11:53 +03:00
Vasily
75996476a7
Merge pull request #1061 from Bond-009/dead
...
Remove dead code
2019-03-07 23:57:51 +03:00
Bond_009
37ea50a572
Reduce the amount of exceptions thrown
2019-03-07 21:42:56 +01:00
Claus Vium
0abe57e930
Merge remote-tracking branch 'remotes/upstream/master' into kestrel_poc
2019-03-07 20:16:51 +01:00
Bond-009
65c0b486aa
Remove dead code
...
What it says on the tin
2019-03-07 19:27:43 +01:00
Claus Vium
8c609bc9ce
Reduce aspnet imports
2019-03-07 19:04:09 +01:00
Bond_009
ffd6dac03a
Remove useless comments
2019-03-07 12:24:44 +01:00
Bond_009
a9302b8b53
Remove useless abstraction around XmlReaderSettings
...
This removes the amount of stuff that needs to be passed around
Also removes some unneeded `ManagedFileSystem` usage
2019-03-07 12:04:14 +01:00
Claus Vium
318e0d4a24
Add GetValueOrDefault dictionary extension
2019-03-05 10:27:25 +01:00
Claus Vium
040871459b
Remove some unused references
2019-03-03 14:35:54 +01:00
Bond-009
9993dafe54
Don't mix LINQ and roreach loops for readability
2019-03-01 17:12:22 +01:00
Claus Vium
27e7e792b3
Replace some usage of QueryParamCollection
2019-02-27 14:23:39 +01:00
Claus Vium
91afaaf8fe
Cleanup in QueryParamCollection
2019-02-27 12:45:06 +01:00
Claus Vium
333bd2107a
Remove HttpUtility
2019-02-27 12:40:18 +01:00
Xu Fasheng
0c49079c16
Update comments for DLNA IPv6
2019-02-23 09:56:55 +08:00
Xu Fasheng
1eb26bdf08
Ignore IPv6 DLNA devices
...
DLNA is not ready for IPv6 now, uncomment the code will be fine.
2019-02-22 20:18:34 +08:00
Xu Fasheng
cbd0e71c07
Send DLNA devices message to only the matched interface
...
This will be the right way for multiple interfaces, or the client will
receive all devices message with different IP addresses and could not
detect which one could access.
And provide one option DlnaOptions.SendOnlyMatchedHost to fallback to old
behaviour if this commit missed something.
2019-02-22 20:18:34 +08:00
Xu Fasheng
2db1826ed8
Enable DLNA multi socket binding for linux
...
If not, DLNA on multiple interfaces not works for linux, for
example ZerotierOne VPN.
2019-02-22 20:13:17 +08:00
Xu Fasheng
cf4e64f430
Add option to toggle if ignore virtual interfaces
...
Some VPN like ZerotierOne owns IP address but no gateway, and there is no
good idea in NetworkManager.GetIPsDefault() to filter such virtual interfaces,
so just provide one option to let user decide it.
2019-02-22 20:13:17 +08:00
Joshua M. Boniface
6c6e9ca9f2
Merge pull request #889 from Bond-009/xmlex
...
Fix uncaught xml error
2019-02-19 21:31:16 -05:00
Bond-009
a35ea49c99
Merge remote-tracking branch 'upstream/release-10.2.z' into newmaser
2019-02-17 10:38:44 +01:00
Anders Thomsen
7bb8985f11
Fix race condition in adding dlna devices to session when the device is discovered repeatedly
2019-02-14 21:53:04 +01:00
Bond-009
a82303ccd1
Fix uncaught xml error
2019-02-13 21:41:24 +01:00
Bond_009
81a8ebde22
Move to Microsoft.Extensions.DependencyInjection
...
This PR replaces SimpleInjector with
Microsoft.Extensions.DependencyInjection.
2019-02-12 20:52:23 +01:00
Bond-009
be89a5e719
Don't rename method
2019-02-05 18:16:10 +01:00
Bond_009
84d56976ba
Some small changes in Device.cs and DidlBuilder.cs
...
Device.cs:
* Improve dispose function
* Style fixes
* Remove unused field
DidlBuilder.cs:
* Remove unused field
* Replace giant if chain with a switch statement
2019-02-05 17:37:38 +01:00
Claus Vium
0ef2b46106
Remove custom Threading
2019-02-05 16:47:50 +01:00
Joshua M. Boniface
c4f51e16a5
Merge pull request #736 from Bond-009/startasync
...
Start startup tasks async
2019-02-03 22:23:54 -05:00
Joshua M. Boniface
c713824bf9
Merge pull request #734 from Bond-009/culture
...
Fix more analyzer warnings
2019-01-31 21:11:13 -05:00
Claus Vium
8985fb8d58
Remove support for games as a media type
2019-01-31 19:04:47 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Vasily
ffcf6bdd3a
Merge pull request #713 from EraYaN/fix-emtpy-statement
...
Fix empty statement in DidlBuilder.cs
2019-01-30 17:17:38 +03:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Bond_009
85a58fd655
Start startup tasks async
2019-01-27 15:40:37 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Andrew Rabert
05fd76c0fa
Merge pull request #723 from Bond-009/dbperf
...
Minor improvements to db code
2019-01-26 14:21:31 -05:00
Andrew Rabert
7165868509
Merge pull request #709 from Bond-009/null
...
Fix always null expressions
2019-01-26 14:14:23 -05:00
Bond_009
07f163a4c3
Minor improvements to db code
2019-01-26 18:21:41 +01:00
Bond_009
883575893b
Change image dimentions from double to int
...
Rename ImageSize -> ImageDimensions
2019-01-26 13:16:47 +01:00
Erwin de Haan
e8f6a61131
Fix empty statement in DidlBuilder.cs
2019-01-25 22:51:34 +01:00
Bond_009
8af256f9c2
Fix always null expressions
2019-01-25 21:52:10 +01:00
Bond_009
722120af74
Remove conditions that are always true/false
2019-01-22 23:49:51 +01:00
William Taylor
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Andrew Rabert
8de4eb7d19
Rename ApplicationSemanticVersion to ApplicationVersion
2019-01-19 21:35:33 -05:00
Erwin de Haan
924ec0c191
Revert Jellyfin.Versioning, Update all versions and user agents.
2019-01-20 01:12:44 +01:00
Erwin de Haan
bb8df8dfa0
Updates reported version in System/Info*
set of endpoints.
...
Added ProductName and ServerVersion to API.
Added build version and build step. Addressed issues wtih indentation.
Made the BuildVersion an actual object. This lets up link to the github page of that commit.
Fixed class method type and styled link.
Fixed languages and split out the information in the UI.
Moved update-version script and gave it executable permissions. Windows correctly finds the .bat file. And linux takes the one without extension.
Removed tempfiles from replace sessions from csproj.
Updated version generation scripts. Will also work with pre existing version files. (Source tarballs etc.)
Added simple replace for ssh github links.
Add execute rights to update-version.
Wrapped long line in ApplicationHost.cs
Fixed some small issues.
Fixed some small issues, and flipped some if's around.
Converted parameter names to camelBack casing.
Sealed the attribute class.
Removed MPLv2 license.
Fixed file headers.
Added newline.
Moved links in *.csproj files as well.
Fix issues caused by rebase auto merging.
Removed default constructor and added init values to properties, also hid the Remote value form API.
2019-01-20 00:28:48 +01:00
Erwin de Haan
c5430f86b0
Fixed csproj and xml identation.
2019-01-19 15:01:16 +01:00
Erwin de Haan
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
e867446437
ReSharper format: conform inline 'out' parameters.
2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
a36658f6f0
ReSharper Reformat: Properties to expression bodied form.
2019-01-13 21:31:14 +01:00
Erwin de Haan
089ad8e7c2
Find+Sed BOM removal *.xml,*.csproj,*,json,*.sln,*.txt
2019-01-13 21:10:15 +01:00
Erwin de Haan
e566d9a231
Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv
2019-01-13 20:54:44 +01:00
Erwin de Haan
742bef5b5f
EditorConfig reformat: Non-CS files.
2019-01-13 20:45:51 +01:00
Erwin de Haan
cc719fd77c
EditorConfig reformat: BDInfo, DvdLib, Emby.Dlna
2019-01-13 20:29:23 +01:00
Erwin de Haan
8bfb54a41b
Visual Studio Reformat: Emby.Dlna
2019-01-13 20:16:19 +01:00
Erwin de Haan
846456b41e
Reformatted the files with notes.
2019-01-12 21:41:08 +01:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00
Sparky
d6d8c40450
Change UI accents, update artwork
...
Replaced "Emby Green" with blue taken from artwork.
Replaced artwork.
Kept old "Emby Green" themes for future reuse and renamed them "classic".
Removed CSS element that was making the Jellyfin banner too small.
2019-01-06 20:47:58 -05:00
Bond_009
391b48614d
Remove FireEventIfNotNull
...
It's a pretty useless "helper" class
2019-01-05 01:49:52 +03:00
Bond_009
79d18cf5a5
Clean up some catch statements
2018-12-30 22:44:39 +01:00
Bond_009
ea4c914123
Fix exception logging
2018-12-30 22:44:39 +01:00