Commit graph

693 commits

Author SHA1 Message Date
Bond-009 5b493e14ac
Improve alternate ordering (#9336) 2023-02-20 08:07:51 -07:00
Bond_009 b119c6d868 StringComparison.Ordinal instead of StringComparison.OrdinalIgnoreCase 2023-02-20 10:14:08 +01:00
Bond_009 24a7e210c3 Optimize tryparse
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Cody Robibero 32eccc139c LiveTV fixes 2023-02-11 07:46:52 -07:00
Bond_009 65d605b17d Improve ffprobe json parsing and don't log error for Codec Type attachment 2023-02-01 14:58:04 +01:00
Bond-009 43c3a465e6
Merge pull request #8775 from SenorSmartyPants/DVRMetadata
Fixes https://github.com/jellyfin/jellyfin/issues/5178
2023-01-03 12:01:32 +01:00
Bond_009 6481376b81 Use DistinctBy introduced in .NET 6 2022-12-19 15:21:42 +01:00
Bond_009 b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond-009 210a4921f2
Fix some warnings and only disable TreatWarningsAsErrors for CodeAnalysis (#8709) 2022-12-05 13:54:28 +01:00
SenorSmartyPants 8f4ac1cb81 Call GetConfiguration just once in function 2022-11-27 13:13:11 -06:00
SenorSmartyPants 75c96e6e76
DVR: Prefer HD channels then earliest showing when handling duplicate showings. (#8768)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2022-11-22 22:02:00 +01:00
SenorSmartyPants 159a244654 Add Options to disable DVR NFO and image saving
- SaveRecordingNFO and SaveRecordingImages default to true. Maintains current behavior.
- Episode.FillMissingEpisodeNumbersFromPath for live tv so external metadata can be pulled when recording starts.
2022-11-19 14:14:41 -06:00
SenorSmartyPants b5f9a093dd
Don't cancel DVR recordings when adjusting settings (#8752)
Fixes https://github.com/jellyfin/jellyfin/issues/3523
2022-11-19 15:12:24 +01:00
Michael Powers 84d1b07849
Fix incorrect starting offset of buffer span in CheckTunerAvailability.
Resolves #7154
2022-11-10 23:29:21 -05:00
Bond_009 ba3e7027fe Add regression test for #8696 2022-11-05 14:11:49 +01:00
Cody Robibero 55c115b7b1 Don't throw exception if program.Title is null 2022-11-04 11:45:29 -06:00
Anthony Lavado f9221c9a64 Backport pull request #8609 from jellyfin/release-10.8.z
Use Token for SchedulesDirect Images and Image Index

Original-merge: a6740bf51e

Merged-by: Anthony Lavado <anthonylavado@me.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-28 22:39:00 -04:00
Bond_009 6a6ea7fa13 Switch branches if statement 2022-10-12 10:00:40 +02:00
Bond_009 f6af28cf96 Fix some things that slipped through the cracks 2022-10-11 23:37:29 +02:00
adrez99 3736e360e7
Merge branch 'jellyfin:master' into gzip 2022-10-11 18:18:21 +02:00
Aaron d50c1b2d4b
Skip generic shows from duplicate removal actions (#8370)
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-10-10 22:25:49 +02:00
Claus Vium 719e5eae16
Merge pull request #8503 from Bond-009/ThrowIfNull 2022-10-07 07:50:39 +02:00
Jan Sommer 0b8faf5db4 Fix minor warnings in Emby.Server.Implementations (#2149) 2022-10-06 21:43:44 +02:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond-009 2d57e71b44
Don't allow throwing System.Exception (#8378) 2022-09-11 17:56:41 -06:00
Bond-009 e1e4ac75e4
Merge pull request #8267 from luzpaz/typos 2022-08-22 17:50:42 +02:00
knackebrot c3405d25fd Make IgnoreDts configurable for M3U tuner 2022-08-18 01:08:03 +02:00
luz paz 9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
adrez99 72893da4d8
Use System.IO.Compression instead of SharpCompress for gzips 2022-06-19 00:06:40 +02:00
Cody Robibero e263e9c2b1 Merge pull request #7544 from jaantaponen/long-filename-fix
(cherry picked from commit 8a1eca0913)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero 2e3c5ed346 Merge pull request #7625 from crobibero/xml-cache-delete
(cherry picked from commit ec6f7bdcff)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-28 09:26:45 -04:00
Cody Robibero 8203e933d5 Merge pull request #7592 from 1337joe/live-tv-fixes
(cherry picked from commit cd93f49fa8)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:51 -04:00
Cody Robibero 435fc7ade9 Merge pull request #7567 from cvium/fix_xmltv_caching
(cherry picked from commit 385a0b9437)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:11 -04:00
Cody Robibero 1425ef3cb4 Merge pull request #7542 from 1337joe/make-recording-stop
Make recording stop at scheduled stop time

(cherry picked from commit 132c85e554)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Bond_009 adad13b865 Remove some dead code 2022-02-17 08:15:26 +01:00
Bond_009 5732e6188c Fix some warnings 2022-02-15 18:59:46 +01:00
Bond_009 1c14c86b20 Fix some warnings 2022-02-14 14:46:04 +01:00
Cody Robibero b6489e73ab
Merge pull request #7241 from Bond-009/async5 2022-02-06 15:25:48 -07:00
Cody Robibero ea3d79c0eb
Merge pull request #7235 from Bond-009/async4 2022-01-22 15:52:12 -07:00
Cody Robibero 3c746f2743
Merge pull request #7236 from Bond-009/taskcompletionsource 2022-01-22 15:46:19 -07:00
Bond_009 e7be01d7a5 Flush to disk async where possible 2022-01-22 23:36:42 +01:00
Niels van Velzen 2afcaa6ae1 Use Guid for BaseItemDto parent ids 2022-01-22 22:29:02 +01:00
Bond_009 832da133d8 Always create TaskCompletionSource<T> with TaskCreationOptions.RunContinuationsAsynchronously 2022-01-22 17:06:57 +01:00
Bond_009 2dcb2f8a9f Ban the usage of Task.Result
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Cody Robibero a60cb280a3 Properly populate QueryResult 2022-01-20 08:53:06 -07:00
Bond_009 05836c8cd3 Fix warning SA1414 and CA1849 2022-01-10 10:57:32 +01:00
Bond_009 3ab0afdc6b Remove task cancellation hacks 2022-01-07 11:24:36 +01:00