Commit graph

540 commits

Author SHA1 Message Date
PloughPuff 8104e739d5 Address review comments from Bond 2019-03-05 21:29:15 +00:00
PloughPuff ed69e690b8 Review comments
Address review comments from JustAMan, Bond-009 and cvium.
2019-03-05 21:29:15 +00:00
PloughPuff 20775116f7 Reworked FFmpeg path discovery and always display to user
1) Reworked FFmpeg and FFprobe path discovery (CLI switch, Custom xml, system $PATH, UI update trigger).  Removed FFMpeg folder from Emby.Server.Implementations.  All path discovery now in MediaEncoder.

2) Always display FFmpeg path to user in Transcode page.

3) Allow user to remove a Custome FFmpeg path and return to using system $PATH (or --ffmpeg if available).

4) Remove unused code associated with 'prebuilt' FFmpeg.

5) Much improved logging during path discovery.
2019-03-05 21:24:54 +00:00
Joshua M. Boniface 5587dd8bfb
Merge pull request #900 from ploughpuff/validator
Implement proper FFmpeg version checking
2019-03-05 11:07:49 -05:00
Vasily f1086a72bf
Improve logic when determining return value
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
2019-02-28 15:58:41 +00:00
PloughPuff 7668ecf9c9 Use Version Class to ease comparisons 2019-02-27 18:20:48 +00:00
Claus Vium aafed63c3f Set EnableRaisingEvents to true for processes that require it 2019-02-24 16:33:05 +01:00
Claus Vium 139807719c Add missing base64 conversion 2019-02-20 11:09:10 +01:00
Claus Vium 1e2050f106 Rename functions to match functionality 2019-02-20 11:09:10 +01:00
Claus Vium a23f04623e Remove IEncryptionManager 2019-02-20 11:09:06 +01:00
PloughPuff 69ea15f73a Use string interpolation
Two further review comments from JustAMan.
2019-02-16 00:47:38 +00:00
PloughPuff d8d237f6f2 Review comments
Addressed review comments from JustAMan.  Removed code to determine experimental version.  Store major and minor as two ints.  Allow control of a min and max recommended version.
2019-02-15 23:51:22 +00:00
PloughPuff a6bde0943e Implement proper FFmpeg version checking
Three routes to determine FFmpeg version:
1) Grab the 'ffmpeg version x.y' from from the -version output.  This should work for all pre-built binaries.
2) Compare the library versions against known contents of FFmpeg versions.  This is fallback aimed at custom builds.
3) Compare libavcodec version to determine if newer than latest known release.  This suggests user is running within latest/HEAD/master build.
2019-02-14 22:08:48 +00:00
Bond_009 1cdcace061 Remove dead code 2019-02-02 15:58:39 +01:00
Bond_009 95ee3c72e3 Properly dispose Tasks 2019-02-02 15:56:54 +01:00
Bond_009 66eabcdd39 Minor changes to encoding code
* Don't wait in intervals of 100ms for the file to exist
2019-02-02 15:56:54 +01:00
Bond-009 1ea219bf3f
Merge branch 'master' into culture 2019-01-30 16:57:15 +01:00
Vasily 91e99effc9
Apply suggestions from code review for flipped conditions.
Co-Authored-By: EraYaN <EraYaN@users.noreply.github.com>
2019-01-29 14:45:07 +01:00
Erwin de Haan b9a111432a Unwrapped all /(Write|Read)All(Text|Bytes)/ functions. 2019-01-28 22:10:50 +01:00
Erwin de Haan 581a7fe078 Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile 2019-01-28 22:10:00 +01:00
Erwin de Haan a430568082 Unwrapped OpenRead and CopyFile 2019-01-28 22:09:58 +01:00
Erwin de Haan d7c6d16250 Unwrapped CreateDirectory and DeleteDirectory 2019-01-28 22:09:56 +01:00
Erwin de Haan 3a831994f6 Unwrapped GetDirectoryName and DirectorySeperatorChar 2019-01-28 22:06:34 +01:00
Bond_009 a709cbdc64 Fix more analyzer warnings 2019-01-27 12:12:44 +01:00
Tthecreator 0b80902cc8 Set EnableRaisingEvents correctly for SubtitleEncoder 2019-01-22 16:52:26 +01:00
Andrew Rabert d16f38dbe1 Merge pull request #623 from wtayl0r/inject-logger-factories
Replaced injections of ILogger with ILoggerFactory
2019-01-20 18:12:50 -05:00
Andrew Rabert a1fcf4ea0d Merge pull request #613 from MatMaul/mediaencoding-dev
Update MediaEncoding
2019-01-20 18:11:51 -05:00
Mathieu Velten da16de48aa Revert back to 10e57ce8d21b4516733894075001819f3cd6db6b for MediaEncoding
Remove some duplicate code that were causing warnings
2019-01-20 22:50:09 +01:00
William Taylor 65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Claus Vium e8cf72e925 Change CanExtractSubtitles to true to allow conversion during direct streaming 2019-01-20 21:03:18 +01:00
Andrew Rabert 3a6624f701 Merge pull request #629 from cvium/fix_subtitleencoder
Fix subtitle converter misinterpreting 0 valued endTimeTicks
2019-01-20 11:35:20 -05:00
Claus Vium 2b47006662 Remove unneeded variable 2019-01-20 17:06:40 +01:00
Claus Vium 2dc14aa85d Remove CodePages from csproj 2019-01-20 11:41:33 +01:00
Claus Vium 26e20d1cd5 Fix subtitle converter misinterpreting 0 valued endTimeTicks 2019-01-20 08:17:31 +01:00
cvium 790266d314 Add package ref for codepages 2019-01-20 06:30:52 +01:00
cvium b35dcbb9f0 Remove MediaBrowser.Text since it violates licenses and is overall hacky 2019-01-20 06:30:50 +01:00
Erwin de Haan c5430f86b0 Fixed csproj and xml identation. 2019-01-19 15:01:16 +01:00
Erwin de Haan 38f96af079 Reformat JustAMan review pt2 changes
Refs #575
2019-01-17 20:24:39 +01:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan a36658f6f0 ReSharper Reformat: Properties to expression bodied form. 2019-01-13 21:31:14 +01:00
Erwin de Haan 9fa60ec934 Find+Sed BOM removal all toher files, except test files. 2019-01-13 21:20:44 +01:00
Erwin de Haan 089ad8e7c2 Find+Sed BOM removal *.xml,*.csproj,*,json,*.sln,*.txt 2019-01-13 21:10:15 +01:00
Erwin de Haan 8f41ba4d3a Find+Sed BOM removal *.cs: MediaBrowser.LocalMetadata-MediaBrowser.Model 2019-01-13 21:02:23 +01:00
Erwin de Haan 742bef5b5f EditorConfig reformat: Non-CS files. 2019-01-13 20:45:51 +01:00
Erwin de Haan f2e50f50bd Visual Studio Reformat: MediaBrowser.MediaEncoding 2019-01-13 20:26:04 +01:00
Erwin de Haan e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Andrew Rabert e5c2dbdf23 Merge pull request #540 from joshuaboniface/api-keys
Update Emby API keys to our own
2019-01-10 23:02:29 -05:00
Joshua M. Boniface 15c89d281e Merge pull request #506 from hawken93/linting
Removing tabs and trailing whitespace
2019-01-10 19:54:18 -05:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Anthony Lavado 5900ab8c68 Update OpenSubtitles User Agent to our own 2019-01-10 13:26:52 -05:00
Bond_009 f520ddc966 Remove useless properties from IEnvironmentInfo 2019-01-08 17:35:56 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Andrew Rabert 237187bfc0 Merge pull request #456 from Bond-009/subencoder
SubtitleEncoder: stop using tuples for clarity
2019-01-06 18:29:12 -05:00
Anthony Lavado 0a715f9196 Merge pull request #435 from Bond-009/ffmpeglogs
Reduce log spam from ffmpeg info
2019-01-06 16:59:37 -05:00
Bond_009 73fd0cd8c6 SubtitleEncoder: stop using tuples for clarity
* Replace Tuples with a ValueTuple or a struct
2019-01-06 21:02:25 +01:00
Bond_009 abddc4786c Reduce log spam from ffmpeg info 2019-01-05 22:40:33 +01:00
Bond_009 59d8d9a82c Fix nullrefexception in SubtitleEncoder 2019-01-04 18:52:04 +01:00
Anthony Lavado a06a5c8d18 Merge branch 'dev' into project-updates 2019-01-02 14:02:48 -05:00
Bond_009 ec47c5b0f7 Remove unused FontConfigLoader 2019-01-02 15:12:52 +01:00
Bond_009 f3030812ea Use static regex 2019-01-02 16:21:24 +03:00
Bond_009 d6f3ca859e Change regex to multiline
ex: https://regex101.com/r/bn9IOy/12
2019-01-02 16:21:24 +03:00
Bond_009 c05e8088d6 Remove extra capture group from regex
https://regex101.com/r/bn9IOy/11/
2019-01-02 16:21:24 +03:00
Bond_009 12c43cd769 Use regex to check if ffmpeg output contains codec
Demo of the regex: https://regex101.com/r/bn9IOy/10/
2019-01-02 16:21:24 +03:00
Bond_009 0042b96c80 Use ValueTuple and Linq 2019-01-02 16:21:24 +03:00
Bond_009 96ad22a009 Reduce log spam and clean up EncoderValidator 2019-01-02 16:21:24 +03:00
Anthony Lavado 87812d1e7f Fix spacing to C#/Visual Studio standards
- This is a fix automatically applied by Visual Studio
2019-01-02 01:22:21 -05:00
Bond_009 c99b45dbe0 Remove some warnings 2019-01-02 02:35:40 +03:00
Bond_009 ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009 0c1b9d3bff Rebase 2018-12-30 22:44:38 +01:00
Bond_009 b0ca979bed MediaBrowser.MediaEncoding use same layout/style as other csprojs 2018-12-29 23:57:22 +01:00
Andrew Rabert a86b71899e Add GPL modules 2018-12-27 18:27:57 -05:00
Mathieu Velten 1d7d52ff9e Port MediaEncoding and Api.Playback from 10e57ce8d21b4516733894075001819f3cd6db6b 2018-12-14 17:32:54 +01:00
Luke Pulverenti 40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti d8e2887071 update container value 2017-08-04 16:29:34 -04:00
Luke Pulverenti b89af7af43 fixes #2121 - background roku thumbnail generation (or maybe... any scheduled task?) should be "niced" 2017-08-01 15:43:39 -04:00
Luke Pulverenti d270b10db6 move auto-organize to plugin 2017-07-27 01:18:39 -04:00
Luke Pulverenti bd32c8ba49 update lg dlna profile 2017-07-13 15:04:59 -04:00
Luke Pulverenti a759b09577 support max audio bit depth 2017-06-26 11:10:52 -04:00
Luke Pulverenti 1e5c3db9eb support individual library refreshing 2017-06-23 12:04:45 -04:00
Luke Pulverenti 6ff89eab78 fixes #2588 - OpenSubtitlesDownloader doesn't respect X-Ratelimit-Requests-Remaining 2017-06-22 15:14:58 -04:00
Luke Pulverenti ce47f63389 3.2.20.5 2017-06-18 03:11:55 -04:00
Luke Pulverenti 1663b258a7 update home sections 2017-06-13 02:33:29 -04:00
Luke Pulverenti 9f0e6d17c8 add hevc cuvid 2017-06-12 03:11:54 -04:00
Luke Pulverenti 2c54390c38 enable h264_cuvid decoder 2017-06-10 14:24:53 -04:00
Luke Pulverenti 42d0b070b4 update project files 2017-06-04 17:08:56 -04:00
Luke Pulverenti 820b4873fb move methods to base class 2017-06-04 16:28:27 -04:00
Luke Pulverenti 3e15b28b18 add IsInterlaced param 2017-05-29 08:35:59 -04:00
Luke Pulverenti 33014f77aa update GetItems method 2017-05-26 02:48:54 -04:00
Luke Pulverenti 404171023f clean up build configs 2017-05-16 01:44:06 -04:00
Luke Pulverenti 0beb803aed add sample rate condition 2017-05-13 15:31:25 -04:00
Luke Pulverenti e915ceda1b dummy up audio bitrates when needed 2017-05-10 22:57:48 -04:00
Luke Pulverenti ef41f919a6 fix movie db find by external id 2017-05-08 14:07:42 -04:00
Luke Pulverenti 696a6b34ea improve smb support 2017-05-04 14:14:45 -04:00
Luke Pulverenti 53024bd149 removed dead code 2017-05-04 03:01:35 -04:00
Luke Pulverenti fc7ab45fb3 unify audio conversion 2017-04-27 14:13:16 -04:00
Luke Pulverenti da39d9a5bf update folder queries 2017-04-27 14:12:44 -04:00
Luke Pulverenti 8755886761 switch to hwaccel auto 2017-04-21 16:03:07 -04:00
Luke Pulverenti 4d7d8961b4 update encoding detection 2017-04-18 01:53:39 -04:00
Luke Pulverenti 561028c907 update automated checkins 2017-04-17 15:01:16 -04:00