Commit graph

578 commits

Author SHA1 Message Date
Bond-009 066c19a26b
Fix possible null ref exception 2021-03-24 21:06:03 +01:00
David 14cbd22fbe Use Helper Methods for provider url parsing 2021-03-16 21:45:12 +01:00
cvium 025e351f61 add unit tests 2021-03-15 08:25:20 +01:00
cvium ab0cff8556 do not resolve episode-like files if they are in extras folders 2021-03-14 19:56:45 +01:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Bond_009 5241bd41ef Add code analysis attributes where appropriate 2021-03-09 01:28:21 +01:00
Joshua M. Boniface 82d88bdec6
Merge pull request #5409 from ikomhoog/master 2021-03-08 16:39:40 -05:00
Claus Vium 90cdd1345d
Merge pull request #5407 from Bond-009/hack 2021-03-08 21:23:14 +01:00
Bond_009 54f81c4da4 Call ToLower on CollectionTypeOptions.ToString 2021-03-08 12:08:17 +01:00
Ikomhoog d4201f812c Changed string.Length == 0 to string.IsNullOrEmpty in case of null 2021-03-08 11:02:51 +01:00
cvium 946411be8e Remove redundant check 2021-03-06 21:18:20 +01:00
cvium 67af30d1ff Remove redundant checks 2021-03-06 20:53:50 +01:00
cvium 54211b921c rider is a prick 2021-03-06 19:07:02 +01:00
cvium bc661c16e1 simplify 2021-03-06 14:01:37 +01:00
cvium 37e374d33d make sure network path substitution matches correctly 2021-03-05 14:09:23 +01:00
Bond_009 81f527f808 CollectionType can be null 2021-02-24 11:57:04 +01:00
Bond_009 1c74e2f40e Fix build 2021-02-24 02:57:10 +01:00
Bond_009 914e891689 Fix unchecked input 2021-02-24 02:05:12 +01:00
dkanada 9fcdbd4c4b remove deprecated settings from server config 2021-02-12 21:58:37 +09:00
Bond_009 a9b497720d Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.

```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

|          Method |       Mean |    Error |   StdDev |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
|  RoundTripBytes |   932.0 ns |  5.09 ns |  4.25 ns | 0.1173 |     - |     - |     368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 |     - |     - |     464 B |
```
2021-01-12 15:37:18 +01:00
Bond-009 4549c96f6d
Merge pull request #4906 from Spacetech/library_scan_ignore_inaccessible
Ignore inaccessible files & folders during library scans
2021-01-08 21:01:32 +01:00
Ian 0f4bbbc63c Fix 3169 and 2879 by making MusicArtistResolver run ahead of MusicAlbumResolver 2021-01-06 10:58:07 -08:00
Gary Wilber 1fdeac0a7d Ignore inaccessible files during library scans 2020-12-31 18:40:24 -08:00
Joshua M. Boniface 7caba04c3c
Merge pull request #4890 from nielsvanvelzen/4888-fix-search-hints
Fix search hint endpoint error
2020-12-30 19:55:57 -05:00
artiume f411353c8c
Update Emby.Server.Implementations/Library/UserDataManager.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-12-30 09:30:02 -05:00
artiume c7cb177260
Update Emby.Server.Implementations/Library/UserDataManager.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-12-30 09:12:36 -05:00
artiume 77b478c726
Update Emby.Server.Implementations/Library/UserDataManager.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-12-30 09:12:13 -05:00
artiume 99adbf0497
Split resume function for Audiobooks 2020-12-30 08:48:33 -05:00
Niels van Velzen 2bb84c0675 Fix limit parameter error for search hints endpoint 2020-12-30 11:16:09 +01:00
David 043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
David a714008b59 Add missing FileStreams 2020-12-23 21:00:50 +01:00
David 2a574914ea Use streams instead of strings 2020-12-23 19:24:58 +01:00
David 196388d607 Remove custom Json serializer from Emby.Server.Implementations 2020-12-23 13:14:40 +01:00
Claus Vium 21d2e9ff0c
Merge pull request #4771 from crobibero/typed-get-preference
Use typed UserManager GetPreference
2020-12-16 22:15:56 +01:00
crobibero ee23d06154 Use a more descriptive function name 2020-12-13 08:15:26 -07:00
artiume 297cb27ab6
remove opf extension for book types 2020-12-11 21:13:28 -05:00
crobibero b670937c3d Use typed UserManager GetPreference 2020-12-11 15:00:43 -07:00
cvium 3f6e6c4839 Simplify 2020-12-10 14:47:47 +01:00
cvium 3c5bbeb80c Remove ImageFetcherPostScanTask 2020-12-10 13:38:33 +01:00
nyanmisaka 020fe37dfe fix custom library order 2020-12-08 22:33:52 +08:00
crobibero b5a7a74e89 Use GetParentItem where applicable 2020-12-01 16:16:17 -07:00
crobibero 2055d49701 fix inverted condition 2020-12-01 11:10:56 -07:00
crobibero c083b29e29 Use Guid as API parameter type where possible 2020-12-01 11:07:41 -07:00
BaronGreenback 969b9e2a18
Update ImageFetcherPostScanTask.cs 2020-11-21 23:33:41 +00:00
Joshua M. Boniface bf54b5579c
Merge branch 'master' into defer_image_fetching 2020-11-21 17:20:31 -05:00
Joshua M. Boniface 7457c4a95d
Merge pull request #4499 from crobibero/more-param
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
2020-11-20 12:34:18 -05:00
Greenback e51ddd326c Fixes spelling. 2020-11-18 13:23:45 +00:00
crobibero 3cc0dd7e12 Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage. 2020-11-16 20:29:46 -07:00
BaronGreenback 2bbfcc264d
Merge branch 'master' into emby-namig-nullable 2020-11-16 19:47:36 +00:00
crobibero e66d79fc0c Merge remote-tracking branch 'upstream/master' into http-exception 2020-11-15 13:09:05 -07:00
crobibero 95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
Bond_009 ff49a3bb61
Missed some stuff 2020-11-14 20:28:15 +01:00
Bond_009 bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[]) 2020-11-14 20:27:48 +01:00
Stepan c0747512d6 Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable 2020-11-10 12:42:49 +01:00
cvium 584b4fa41f Fix Persons, Genres and Studios endpoints 2020-11-05 12:27:22 +01:00
Anthony Lavado 6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
Minor improvements
2020-11-02 11:10:39 -05:00
Stepan 60b49e67ea Re-Sharper inspection issues 2020-11-01 11:19:22 +01:00
Stepan 59619b6ea7 Enable nullable in Emby.Naming 2020-11-01 10:47:31 +01:00
Bond_009 49569ca0a0 Use nameof where possible 2020-10-17 16:19:57 +02:00
Bond-009 d54de29485
Merge pull request #4315 from Jan-PieterBaert/fix-warnings
Fix some warnings
2020-10-14 14:04:13 +02:00
Anthony Lavado 8b419d9ea6
Merge pull request #4199 from ryanpetris/livetv-locking
Fix stream performance when opening/closing new streams.
2020-10-13 00:02:38 -04:00
Jan-Pieter Baert ec91d3893d
Fix SA 1116 warnings 2020-10-12 20:05:11 +02:00
cvium 4a81ee43dc Add try-catch to avoid crashing the whole thing 2020-10-06 23:36:48 +02:00
cvium 1b18f86c8b Add missing parameter comments. 2020-10-03 13:52:51 +02:00
cvium 5d3449e9dc Fix xml doc comment 2020-10-03 13:39:39 +02:00
cvium 763862cbd8 Defer image pre-fetching until the end of a refresh/scan 2020-10-03 13:36:53 +02:00
Gary Wilber 3cfbe6e340 better audio file check 2020-09-27 13:28:19 -07:00
Gary Wilber 75041e7f39 interlocked increment 2020-09-27 12:56:12 -07:00
Gary Wilber 05fa95f149 Increase scan speed for music libraries 2020-09-26 19:33:59 -07:00
Ryan Petris 4db5700e18
Don't take a lock if there's no intention to manipulate the list of open streams. Instead, use a ConcurrentDictionary so that, in those situations, thread-safe access to the dictionary is ensured. 2020-09-23 14:12:26 -07:00
Bond_009 edbd4e0db6 Remove extra return statement 2020-09-11 12:57:57 +02:00
Bond_009 441301069e Fix 2020-09-11 12:56:11 +02:00
Bond_009 48e1cf9fd7 Minor performance improvements to item saving 2020-09-09 13:38:27 +02:00
Bond_009 119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
Bond_009 ab2147751f Make MediaBrowser.MediaEncoding warnings free 2020-08-20 12:16:24 +02:00
cvium 0cf75992a8 Use MemoryCache.Set since SetValue does not flush to cache automatically. 2020-08-07 11:55:22 +02:00
Bond-009 b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
Migrate Display Preferences to EF Core
2020-08-01 21:51:49 +02:00
dkanada e0d2eb8eec
remove useless order step for intros 2020-08-01 02:03:23 +09:00
Patrick Barron e5c6eec642 Use MemoryCache in LibraryManager 2020-07-29 17:28:15 -04:00
Joshua M. Boniface d7287a05ad
Merge pull request #3684 from Bond-009/warn22
Fix warnings
2020-07-27 00:16:09 -04:00
Odd Stråbø 9314a4fcc9 . 2020-07-26 23:28:25 +02:00
Odd Stråbø 7fa80ac3e0 Add more tests, update comment 2020-07-26 23:03:16 +02:00
Odd Stråbø de708d2fca Comment 2020-07-26 17:11:43 +02:00
Odd Stråbø 800260af43 Yep. I failed at copy-pasting. 2020-07-26 00:19:24 +02:00
Odd Stråbø 11d5410dbb Don't ignore dot directories.
Use `.ignore` file to hide directory from library scan.

Also, please tell me we handle sample matching somewhere else? This is a mess.
2020-07-25 23:50:49 +02:00
Bond_009 01e781035f Fix warnings 2020-07-24 16:37:54 +02:00
Bond-009 3ff110984a
Merge branch 'master' into readonlyspan 2020-07-24 09:40:44 +02:00
Patrick Barron 0aa349fe40 Remove unused dependencies. 2020-07-23 21:42:36 -04:00
Patrick Barron 3d69cea1c9
Merge branch 'master' into displaypreferences-efcore 2020-07-23 23:50:12 +00:00
Joshua M. Boniface 0d446c8755
Merge pull request #3609 from Bond-009/warn21
Fix warnings
2020-07-23 18:06:34 -04:00
Bill Thornton e973757485 Simplify logic 2020-07-22 11:32:29 -04:00
Bond_009 febb6bced6 Review usage of string.Substring (part 1)
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Bill Thornton 2fa2952791 Skip image processing for live tv sources 2020-07-21 16:40:38 -04:00
Bond_009 7324b44c43 Fix warnings 2020-07-20 11:01:37 +02:00
Patrick Barron b53bf2cd16 Remove obsolete network path code 2020-07-18 16:21:01 -04:00
crobibero e152a6c82f Increase delete logging 2020-07-17 15:53:10 -06:00
Patrick Barron ab396225ea Migrate Display Preferences to EF Core 2020-07-17 16:11:53 -04:00
Bond-009 cb193b6afd Add support for ReadOnlySpan<char> in IgnorePatterns 2020-06-27 11:34:33 +02:00
crobibero 9772749d8f Add more ignorepatterns and tests 2020-06-26 11:04:35 -06:00
dkanada bb7444db07
Merge pull request #3439 from cvium/ignore_application_folders
Never ignore application folders
2020-06-26 06:14:19 +09:00