Tristan McCann
5c1fbfca03
Stop path substitution in SubtitleEncoder
...
This fixes jellyfin/jellyfin#1446 . I am not an expert in this section of
code, but I cannot think of a need to do path substitution during
subtitle encoding.
2019-06-11 21:36:42 -04:00
Bond-009
91cd7d2f6b
Limit amount of ffmpeg processes extracting images at once
2019-04-30 23:35:39 +02:00
Phallacy
a7e31ef31f
applied changes to just also search jellyfin base dir
2019-04-09 00:27:41 -07:00
redSpoutnik
480a6607e2
Merge branch 'master' into subtitle-display-title
2019-03-16 17:54:57 +01:00
redSpoutnik
427688a0a0
Change subtitles DisplayTitle behavior
2019-03-14 22:31:51 +01:00
Erwin de Haan
21cc38fcf4
Adjusted AssemblyCopyright attribute values.
2019-03-14 22:17:56 +01:00
Erwin de Haan
ee7bf86e0f
Adjusted the Product Name so the User Agent is correct/better.
2019-03-14 22:11:47 +01:00
Vasily
605bf0e8c3
Merge pull request #1100 from ploughpuff/rmprobeswitch
...
Finalise removal of --ffprobe switch
2019-03-13 01:42:07 +03:00
Vasily
89e2af6b57
Merge pull request #1096 from dkanada/opensubs
...
Remove open subtitles from the server
2019-03-13 01:22:55 +03:00
PloughPuff
b864e9da2a
Finalise removal of --ffprobe switch
...
Removed --ffprobe from src files and server/docker scripts.
2019-03-12 22:09:18 +00:00
Bond-009
3ddbda9aca
Merge branch 'master' into xml
2019-03-12 16:37:18 +01:00
dkanada
715ddbb3b0
remove open subtitles from the server
2019-03-11 18:10:31 -07:00
Bond-009
ab9859ecef
Address comment
2019-03-07 21:42:56 +01:00
Bond_009
37ea50a572
Reduce the amount of exceptions thrown
2019-03-07 21:42:56 +01:00
Vasily
a4b52b7264
Merge pull request #844 from ploughpuff/ffmpeg
...
Reworked FFmpeg path discovery and always display to user
2019-03-07 17:23:06 +03:00
Bond_009
ffd6dac03a
Remove useless comments
2019-03-07 12:24:44 +01:00
Vasily
2242c8d793
Merge pull request #915 from cvium/remove_encryptionmanager
...
Remove IEncryptionManager
2019-03-06 15:56:15 +03:00
PloughPuff
2617a49b78
Renamed Init() to SetFFmpegPath()
2019-03-05 21:29:15 +00:00
PloughPuff
656bffbbb2
Remove --ffprobe logic
2019-03-05 21:29:15 +00:00
PloughPuff
8104e739d5
Address review comments from Bond
2019-03-05 21:29:15 +00:00
PloughPuff
ed69e690b8
Review comments
...
Address review comments from JustAMan, Bond-009 and cvium.
2019-03-05 21:29:15 +00:00
PloughPuff
20775116f7
Reworked FFmpeg path discovery and always display to user
...
1) Reworked FFmpeg and FFprobe path discovery (CLI switch, Custom xml, system $PATH, UI update trigger). Removed FFMpeg folder from Emby.Server.Implementations. All path discovery now in MediaEncoder.
2) Always display FFmpeg path to user in Transcode page.
3) Allow user to remove a Custome FFmpeg path and return to using system $PATH (or --ffmpeg if available).
4) Remove unused code associated with 'prebuilt' FFmpeg.
5) Much improved logging during path discovery.
2019-03-05 21:24:54 +00:00
Joshua M. Boniface
5587dd8bfb
Merge pull request #900 from ploughpuff/validator
...
Implement proper FFmpeg version checking
2019-03-05 11:07:49 -05:00
Vasily
f1086a72bf
Improve logic when determining return value
...
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
2019-02-28 15:58:41 +00:00
PloughPuff
7668ecf9c9
Use Version Class to ease comparisons
2019-02-27 18:20:48 +00:00
Claus Vium
aafed63c3f
Set EnableRaisingEvents to true for processes that require it
2019-02-24 16:33:05 +01:00
Claus Vium
139807719c
Add missing base64 conversion
2019-02-20 11:09:10 +01:00
Claus Vium
1e2050f106
Rename functions to match functionality
2019-02-20 11:09:10 +01:00
Claus Vium
a23f04623e
Remove IEncryptionManager
2019-02-20 11:09:06 +01:00
PloughPuff
69ea15f73a
Use string interpolation
...
Two further review comments from JustAMan.
2019-02-16 00:47:38 +00:00
PloughPuff
d8d237f6f2
Review comments
...
Addressed review comments from JustAMan. Removed code to determine experimental version. Store major and minor as two ints. Allow control of a min and max recommended version.
2019-02-15 23:51:22 +00:00
PloughPuff
a6bde0943e
Implement proper FFmpeg version checking
...
Three routes to determine FFmpeg version:
1) Grab the 'ffmpeg version x.y' from from the -version output. This should work for all pre-built binaries.
2) Compare the library versions against known contents of FFmpeg versions. This is fallback aimed at custom builds.
3) Compare libavcodec version to determine if newer than latest known release. This suggests user is running within latest/HEAD/master build.
2019-02-14 22:08:48 +00:00
Bond_009
1cdcace061
Remove dead code
2019-02-02 15:58:39 +01:00
Bond_009
95ee3c72e3
Properly dispose Tasks
2019-02-02 15:56:54 +01:00
Bond_009
66eabcdd39
Minor changes to encoding code
...
* Don't wait in intervals of 100ms for the file to exist
2019-02-02 15:56:54 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Vasily
91e99effc9
Apply suggestions from code review for flipped conditions.
...
Co-Authored-By: EraYaN <EraYaN@users.noreply.github.com>
2019-01-29 14:45:07 +01:00
Erwin de Haan
b9a111432a
Unwrapped all /(Write|Read)All(Text|Bytes)/ functions.
2019-01-28 22:10:50 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory
, DirectoryExists
, FileExists
& removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
a430568082
Unwrapped OpenRead
and CopyFile
2019-01-28 22:09:58 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Tthecreator
0b80902cc8
Set EnableRaisingEvents correctly for SubtitleEncoder
2019-01-22 16:52:26 +01:00
Andrew Rabert
d16f38dbe1
Merge pull request #623 from wtayl0r/inject-logger-factories
...
Replaced injections of ILogger with ILoggerFactory
2019-01-20 18:12:50 -05:00
Andrew Rabert
a1fcf4ea0d
Merge pull request #613 from MatMaul/mediaencoding-dev
...
Update MediaEncoding
2019-01-20 18:11:51 -05:00
Mathieu Velten
da16de48aa
Revert back to 10e57ce8d21b4516733894075001819f3cd6db6b for MediaEncoding
...
Remove some duplicate code that were causing warnings
2019-01-20 22:50:09 +01:00
William Taylor
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Claus Vium
e8cf72e925
Change CanExtractSubtitles to true to allow conversion during direct streaming
2019-01-20 21:03:18 +01:00
Andrew Rabert
3a6624f701
Merge pull request #629 from cvium/fix_subtitleencoder
...
Fix subtitle converter misinterpreting 0 valued endTimeTicks
2019-01-20 11:35:20 -05:00