Commit graph

787 commits

Author SHA1 Message Date
Shadowghost a8cdf4434b
Fix access to playlists not created by a user (#9746) 2023-05-12 07:11:59 -06:00
AmbulantRex 4a0b135b7a
Merge branch 'jellyfin:master' into whitelist-dlls 2023-04-15 07:11:33 -06:00
JPVenson 3c22d5c970
#7626 Added handling for common FormatExceptions with Skia loading sv… (#9581)
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2023-04-10 21:38:07 +02:00
Stepan Goremykin 910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
Stepan Goremykin b6cfdb8b92 Simplify conditional expression 2023-04-06 19:30:17 +02:00
Stepan Goremykin 19e65269a2 Simplify linq expressions (use All) 2023-04-06 19:27:57 +02:00
elmuffo bb5bf0277a
Implement check to hide all libraries when user has no access (#9536) 2023-04-01 15:01:05 -06:00
AmbulantRex 3a731051ad Correct styling inconsistencies 2023-04-01 05:03:55 -06:00
AmbulantRex a944352aa8 Correct style inconsistencies 2023-04-01 04:59:07 -06:00
AmbulantRex 677b1f8e34 Remove unnecessary using statements in PluginManager 2023-03-30 12:56:57 -06:00
AmbulantRex 891b9f7a99 Add DLL whitelist support for plugins 2023-03-30 08:59:21 -06:00
Cody Robibero dd491ce8ff
Merge pull request #9403 from SenorSmartyPants/ExtraCleanAndNFO
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-20 07:16:03 -06:00
Bond_009 d8ec3a5470 Reduce usage of GetAwaiter().GetResult() 2023-03-14 12:05:49 +01:00
Bond-009 6351d1022b
Merge pull request #9254 from Shadowghost/dvdbdfix 2023-03-10 15:48:35 +01:00
SenorSmartyPants b96420b786 Clean Extra Names
- Adds regular expression to CleanStrings to remove suffix style extra naming from the name presented in JF.
- Override Resolve for Extras to enable parsename
- remove exclusion on parsename of extratypes
2023-03-09 17:44:12 -06:00
Bond_009 891e2495c9 Disable real time monitoring by default 2023-03-07 17:59:29 +01:00
Joe Rogers 361fff3a0c
Fix cases where multiple files are resolved as a single book 2023-03-06 23:27:21 -05:00
Joe Rogers 1c3a97bf6a
Inject IDirectoryService where needed instead of passing it through ItemResolveArgs 2023-03-06 23:00:55 -05:00
Joe Rogers 160baa02fd
Remove some BaseItem references to make ItemResolveArgs more usable for testing. 2023-03-06 22:18:26 -05:00
Bond_009 4b01aaa0f7 Allocate less Lists 2023-03-01 00:44:57 +01:00
Bond_009 48263078b4 Reduce string allocations by regex 2023-02-17 15:00:06 +01:00
Shadowghost 3d4b2f840a Fix BD and DVD folder recognition for tv episodes 2023-02-04 18:39:50 +01:00
Bond-009 769c48c629
Deduplicate media stream ordering code (#9014) 2023-01-07 11:30:55 -07:00
Bond-009 497d8c4957
Use Order() introduced in .NET 7 (#8923) 2022-12-19 09:30:00 -07:00
Joe Rogers e4040ab812
Allow video extras to use owner library options 2022-12-08 01:00:27 -05:00
Claus Vium 2c5573b145
Merge pull request #8868 from Bond-009/priorityqueue
Remove dependency on OptimizedPriorityQueue
2022-12-07 18:32:23 +01:00
Claus Vium 558e3d1333
Merge pull request #8867 from stanionascu/fix-8276
Fix to make sure that UDF streams are opened with Share.Read (#8276)
2022-12-07 18:31:53 +01:00
Bond_009 9bb1bc5a3e Remove dependency on OptimizedPriorityQueue 2022-12-07 18:02:12 +01:00
Stanislav Ionascu 7d6ec0a5bd Fix to make sure that UDF streams are opened with Share.Read (#8276)
Make sure that any subsequent requests to open the file for read will
succeed.
2022-12-07 16:40:26 +00:00
Bond_009 b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009 556cc8062d Investigate some TODO comments 2022-11-27 14:13:31 +01:00
Shadowghost 2e639c77c7 Apply review suggestions 2022-11-17 18:54:35 +01:00
Shadowghost 072651c4be Add xmldocs for TMDb provider, correct provider spelling 2022-11-17 11:16:20 +01:00
Claus Vium 263a1663ae
Merge pull request #8521 from 1337joe/fix-missing-symlink-scan
Skip missing symlink instead of breaking out of directory scan
2022-10-12 22:47:41 +02:00
Claus Vium 99e31846bf
Merge pull request #8541 from Bond-009/minor 2022-10-12 16:36:12 +02:00
Claus Vium fc78a6c35c
Merge pull request #8472 from jgriff6/subs
Fix subtitle selection behaviour
2022-10-12 07:22:47 +02:00
Bond_009 f6af28cf96 Fix some things that slipped through the cracks 2022-10-11 23:37:29 +02:00
jgriff6 a83d4b03dc Make 'Always' subtitle mode prioritise full tracks 2022-10-11 18:36:19 +01:00
Joe Rogers c38052a753
Skip missing symlink instead of breaking out of directory scan 2022-10-09 18:56:25 -04:00
Claus Vium b137d0cc2b
Merge pull request #7514 from Shadowghost/music-extend 2022-10-07 15:21:00 +02:00
jgriff6 fbeec04da7 Polish smart subtitle selection logic 2022-10-07 14:17:20 +01:00
Shadowghost 6c6f89acc3 Apply review suggestions 2022-10-07 14:14:21 +02:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
jgriff6 b9abc004a7 Fix subtitle selection behaviour 2022-09-28 22:26:42 +01:00
Hannes Braun 4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
LogicalPhallacy e8893f3d41 Backport pull request #8399 from jellyfin/release-10.8.z
Respect visibility for people items (rebased)

Original-merge: e6124bc154

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-09-23 23:09:38 -04:00
Shadowghost 42fc02cab6 Add xmldocs 2022-09-13 17:20:22 +02:00
Shadowghost cfd1db1638 Prevent MusicArtist creation for artist subfolders 2022-09-13 17:20:22 +02:00
Shadowghost 61fa325ef0 Extend music parsing 2022-09-13 17:20:22 +02:00
luz paz 9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero 8ba83e41ae
Merge pull request #7845 from utkuozdemir/fix/photos-lib-dir-with-single-video 2022-08-14 09:49:27 -07:00
Joshua Boniface e251f1483f Backport pull request #8167 from jellyfin/release-10.8.z
Add back library scan from library manager

Authored-by: Cody Robibero <cody@robibe.ro>

Merged-by: Bond-009 <bond.009@outlook.com>

Original-merge: f9dffa767f
2022-08-01 14:25:44 -04:00
Utku Ozdemir 9ec42f8cf5 fix: single video folder during photos lib scan
Prevent a directory with a single video file to be detected as a movie directory when the library type is "Photos". Closes jellyfin/jellyfin#7825

Signed-off-by: Utku Ozdemir <uoz@protonmail.com>
2022-06-30 13:36:46 +02:00
Cody Robibero 7f1223016d Merge pull request #7946 from cvium/svg
(cherry picked from commit 4ebe70cf6a)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Cody Robibero b35d608b19 Merge pull request #7892 from cvium/fix_tv_multi
(cherry picked from commit 21afec3225)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-14 19:30:59 -04:00
Bond-009 a881733377
Merge pull request #7682 from 1337joe/test-preferred-audio-language 2022-06-14 15:23:40 +02:00
Bond-009 2b1a915ead Merge pull request #7604 from Jellifi007/fixes-diactritics
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Cody Robibero efcdab116f Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fix
(cherry picked from commit 60affd0965)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
Joe Rogers 644e774040
Fix default audio selection ignoring type 2022-05-17 21:03:51 +02:00
Cody Robibero e086eebb71 Merge pull request #7525 from 1337joe/fix-duplicate-library-media-paths
(cherry picked from commit bebe1808ce)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
jakobkukla 75475285da Fix supportsTranscoding not reflecting user permissions sometimes 2022-03-17 17:24:30 +01:00
Claus Vium 53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Stanislav Ionascu 554d1b2ca8 Fix #7100 by catching the exception on opening invalid UDF images
When an invalid UDF image is opened by the UdfReader, it may throw
and exception. This change is to catch and log the exception.
2022-02-20 13:30:55 +00:00
Bond_009 adad13b865 Remove some dead code 2022-02-17 08:15:26 +01:00
Bond_009 5732e6188c Fix some warnings 2022-02-15 18:59:46 +01:00
Bond_009 5d28c5547e Fix indentation 2022-02-14 16:31:07 +01:00
Bond_009 dbd7be091d Fix MediaStreamSelector 2022-02-14 15:03:08 +01:00
Bond_009 1c14c86b20 Fix some warnings 2022-02-14 14:46:04 +01:00
Cody Robibero b6489e73ab
Merge pull request #7241 from Bond-009/async5 2022-02-06 15:25:48 -07:00
SenorSmartyPants 2b769aae69
TV extras (#7178) 2022-02-04 20:44:38 +01:00
Cody Robibero e5701c396a
Merge pull request #6436 from daullmer/splashscreen 2022-01-28 08:12:21 -07:00
Claus Vium 488ce51032
Remove some allocations (#7246) 2022-01-28 12:21:40 +01:00
Bond_009 e7be01d7a5 Flush to disk async where possible 2022-01-22 23:36:42 +01:00
Cody Robibero a60cb280a3 Properly populate QueryResult 2022-01-20 08:53:06 -07:00
Joe Rogers e762454787
Restore resolver that handles alternate videos
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-01-16 22:59:14 +01:00
Dmitry Lyzo ea1f3fe6bd Fix SA1642 warning 2022-01-15 15:33:54 +03:00
Cody Robibero 0d335082c8 suggestions from review 2022-01-10 10:59:32 -07:00
Cody Robibero 6520ad03f0 Fix release build 2022-01-10 08:30:55 -07:00
Cody Robibero ecb73168b3 Suggestions from review 2022-01-10 08:26:30 -07:00
Joe Rogers a26509a98a
Keep from serializing trailers into database 2022-01-07 22:33:31 +01:00
Bond_009 77c615ba42 Error on SA1316 2022-01-05 10:58:57 +01:00
Bond-009 11d0c6827f
Merge pull request #7058 from cvium/the_most_important_feature 2022-01-02 12:31:20 +01:00
cvium 28c2ac9cc0 Remove file extension filter and fix build 2022-01-01 20:07:03 +01:00
Claus Vium 58b9e5af79
Update Emby.Server.Implementations/Library/Resolvers/GenericVideoResolver.cs
Co-authored-by: Joe Rogers <1337joe@users.noreply.github.com>
2022-01-01 14:52:54 +01:00
Cody Robibero 25abe479eb Add ability to search by - 2021-12-31 08:51:50 -07:00
cvium 2749509f00 Use dedicated resolvers for extras 2021-12-28 00:37:40 +01:00
Cody Robibero 7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009 ea8f40e84a More cleanup 2021-12-27 14:20:05 +00:00
Cody Robibero a615f87680
Merge pull request #7044 from 1337joe/fix-trailers-v2
Fix trailers v2
2021-12-25 23:31:46 +00:00
Joe Rogers c0ab54f0bd Fix resolved type for Trailers 2021-12-24 21:21:19 +00:00
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero 076a13abeb
Merge pull request #7029 from cvium/allocations_maybe 2021-12-24 01:59:25 +00:00
Cody Robibero 00211ca056
Merge pull request #7028 from cvium/everything_went_wrong 2021-12-22 17:57:00 +00:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
cvium 83a94aa612 Fix extras folders 2021-12-20 12:15:20 +01:00
Joe Rogers 077f13ae4c
Increment library number instead of appending 2021-12-18 20:50:36 +01:00
Claus Vium 9a0618552b
Merge branch 'master' into what_could_go_wrong 2021-12-15 08:38:39 +01:00