Commit graph

278 commits

Author SHA1 Message Date
Vasily 668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
Enable nullabe reference types for MediaBrowser.Model
2020-06-03 12:26:54 +03:00
Bond_009 7439e095e2 Merge branch 'master' into nullable3 2020-05-27 20:49:18 +02:00
Bond_009 10e381f66f Fix some 'bugs' flagged by sonarcloud 2020-05-25 23:52:51 +02:00
Mark Monteiro 43c22a5822 Add GetLoopbackHttpApiUrl() helper method to replace forceHttps functionality
Also refactor to use return a Uri instead of a string and use UriBuilder under the hood
2020-05-10 14:36:11 -04:00
Bond_009 fc049caba2 Merge branch 'master' into nullable3 2020-04-15 11:09:14 +02:00
Mark Monteiro 4113288278 Fix style issues 2020-04-11 13:46:31 -04:00
Mark Monteiro 7152b55747 Use a separate line for each property initializer 2020-04-11 13:28:21 -04:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Mark Monteiro 658e963e93 replace 'try-finally' with 'using' where appropriate 2020-04-05 09:23:44 -04:00
Mark Monteiro e0f40f57d8 Merge remote-tracking branch 'upstream/master' into remove-common-process 2020-04-03 20:22:03 -04:00
Bond_009 2be394089e Enable Microsoft.CodeAnalysis.FxCopAnalyzers for Jellyfin.Common 2020-04-02 20:12:18 +02:00
Bond_009 3ab50f5a3f Address comments 2020-04-01 19:05:41 +02:00
Mark Monteiro 7447ea8960 Make sure Process objects are all disposed correctly 2020-03-27 00:49:22 +01:00
Mark Monteiro b947d98266 Delete unnecessary ProcessFactory abstraction 2020-03-27 00:45:48 +01:00
Mark Monteiro ee2f911a2b Remove unnecessary CommonProcess abstraction 2020-03-27 00:10:16 +01:00
Bond-009 94fe9b8f6d
Merge branch 'master' into warn17 2020-03-11 20:26:43 +01:00
Mark Monteiro b67e9cde8c Replace ILogger with ILogger<T> wherever possible
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Bond_009 07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009 7060934792 Fix some warnings in Emby.Server.Implementations 2020-02-06 15:21:38 +01:00
dkanada b7a9900556
Merge pull request #2357 from Bond-009/warn13
Fix warnings
2020-02-03 17:15:03 +09:00
Bond_009 87d2479b78 Fix warnings 2020-01-31 22:26:53 +01:00
dkanada cd13f718fb
Merge pull request #2247 from Bond-009/stringhelper
Remove StringHelper functions
2020-02-01 03:29:16 +09:00
Bond-009 c8409d2ea1 Remove FileSystem.GetStream 2020-01-22 22:20:35 +01:00
Bond_009 e714b9930e Merge branch 'master' into embytv 2020-01-10 21:16:46 +01:00
Bond-009 fdbb329118 Remove StringHelper functions 2020-01-09 17:07:13 +01:00
Bond_009 5a8e972952 Enable TreatWarningsAsErrors for some projects
Analyzers are only run in debug build, so setting TreatWarningsAsErrors
for release build will catch the compiler warnings until we resolve all
analyzer warnings.
2019-12-13 20:11:37 +01:00
Bond-009 a2c35e6dba Merge remote-tracking branch 'upstream/master' into random 2019-12-06 12:06:13 +01:00
Bond_009 5cab79c839 Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs 2019-12-04 21:39:27 +01:00
Bond-009 b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Bond_009 bbc0875387 Don't shuffle some types by default 2019-10-20 16:08:40 +02:00
Bond_009 c9820d30ed Fix multiple mistakes and warnings 2019-09-23 20:32:44 +02:00
Bond_009 8fe7b6551f Rewrite ItemDataProvider to be more robust
* Stop locking 2+ times per operation
* Don't clone the list multiple times
* Keep the lock for the duration of the operation
2019-09-12 21:34:55 +02:00
Anthony Lavado cb393c215a
Merge pull request #1686 from Bond-009/warn7
More warning fixes
2019-09-02 02:07:19 -04:00
Bond_009 e4f893a0eb More warning fixes 2019-08-29 22:28:33 +02:00
Bond_009 0aaaaab7a0 Fix invalid arg for 2019-08-29 20:25:56 +02:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond_009 d405a400aa Fixes issues with HttpClientManager 2019-07-06 20:04:42 +02:00
Bond-009 b44a70ff36 Simplify/remove/clean code
* Remove useless runtime check (we only support one)
* Remove unused args
* Remove a global constant

And ofc fix some warnings ;)
2019-03-25 22:25:32 +01:00
Vasily 1fef8bf266
Merge pull request #1060 from Bond-009/assinfo
Remove redundant class AssemblyInfo
2019-03-12 16:34:21 +03:00
Bond_009 37ea50a572 Reduce the amount of exceptions thrown 2019-03-07 21:42:56 +01:00
Bond-009 e91dd14b31 Remove redundent class AssemblyInfo 2019-03-07 18:10:55 +01:00
PloughPuff 73c1cdb32a Avoid exceptions due to folder and file not found
1) Use function to return path to temp transcode path which has benefit of creating temp folder if not exists, thereby avoiding the exception when GetFilePaths is used.
2) Check json files exists before attempting to read from it.  Avoids having to mask FileNotFound exceptions when debugging.
2019-02-20 13:30:06 +00:00
Bond_009 a6a4cd5667 Removed some unused fields 2019-02-09 15:57:42 +01:00
Claus Vium 0ef2b46106 Remove custom Threading 2019-02-05 16:47:50 +01:00
Vasily 0b3e6548db
Merge pull request #797 from Bond-009/warnings
Fix all warnings
2019-02-04 14:08:21 +03:00
Joshua M. Boniface c4f51e16a5
Merge pull request #736 from Bond-009/startasync
Start startup tasks async
2019-02-03 22:23:54 -05:00
Bond-009 78e4e2ed92 Fix all warnings 2019-02-02 21:45:29 +01:00
Bond_009 5ac6d0ae59 Fix more warnings 2019-02-01 21:56:50 +01:00
Bond-009 1ea219bf3f
Merge branch 'master' into culture 2019-01-30 16:57:15 +01:00
Erwin de Haan 581a7fe078 Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile 2019-01-28 22:10:00 +01:00
Erwin de Haan a430568082 Unwrapped OpenRead and CopyFile 2019-01-28 22:09:58 +01:00
Erwin de Haan d7c6d16250 Unwrapped CreateDirectory and DeleteDirectory 2019-01-28 22:09:56 +01:00
Erwin de Haan 3a831994f6 Unwrapped GetDirectoryName and DirectorySeperatorChar 2019-01-28 22:06:34 +01:00
Bond_009 85a58fd655 Start startup tasks async 2019-01-27 15:40:37 +01:00
Bond_009 a709cbdc64 Fix more analyzer warnings 2019-01-27 12:12:44 +01:00
Bond_009 fd7f420af2 Remove remnants of system events 2019-01-25 22:41:43 +01:00
Bond_009 722120af74 Remove conditions that are always true/false 2019-01-22 23:49:51 +01:00
Erwin de Haan 321c440739 Reformat JustAMan review pt1 changes
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan 49b61f238e Merge branch 'dev' into reformat
# Conflicts:
#	Emby.Server.Implementations/ApplicationHost.cs
#	Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
#	Emby.Server.Implementations/LiveTv/LiveTvManager.cs
#	Emby.Server.Implementations/Security/MBLicenseFile.cs
#	Emby.Server.Implementations/Security/PluginSecurityManager.cs
#	Emby.Server.Implementations/Security/RegRecord.cs
#	MediaBrowser.Api/PluginService.cs
#	MediaBrowser.Api/System/SystemService.cs
#	MediaBrowser.Common/Security/IRequiresRegistration.cs
#	MediaBrowser.Common/Security/ISecurityManager.cs
#	MediaBrowser.Common/Security/PaymentRequiredException.cs
#	MediaBrowser.Model/Entities/MBRegistrationRecord.cs
#	MediaBrowser.Model/Entities/PluginSecurityInfo.cs
#	deployment/win-generic/build-jellyfin.ps1
2019-01-15 17:34:39 +01:00
cvium 22a64f37f5 More cleaning 2019-01-15 16:48:21 +01:00
cvium 0e422a33d6 Some code style clean up 2019-01-15 16:48:21 +01:00
Claus Vium eca3c099d9 removed a bunch of validation, security, registration, premiere, whatever bs 2019-01-15 16:48:21 +01:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan e566d9a231 Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv 2019-01-13 20:54:44 +01:00
Erwin de Haan 39ef1106d7 Visual Studio Reformat: Emby.Server.Implementations Part Liv-P 2019-01-13 20:22:00 +01:00
Erwin de Haan e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Bond_009 c07d5a6963 Remove unused PowerManagement
It isn't up to the application to prevent the system from going to sleep
2019-01-06 12:55:48 +01:00
Bond_009 a997bb609f Remove unnecessary using statements 2019-01-05 01:49:52 +03:00
Bond_009 391b48614d Remove FireEventIfNotNull
It's a pretty useless "helper" class
2019-01-05 01:49:52 +03:00
Bond_009 ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009 b7ebb67cbb Remove the need for NullLogger 2018-12-30 22:44:38 +01:00
Bond_009 0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Anthony Lavado 71b8602a3d Updates all other emby.media links to repo page 2018-12-11 01:31:08 -05:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti 58a7829ecd update library changed notifier 2017-11-25 23:48:12 -05:00
Luke Pulverenti 46be272ec8 fixes #2992 - Dashboard Active Recordings not showing thumbnail 2017-11-20 16:27:49 -05:00
Luke Pulverenti 1dc8ff9e91 allow specification of m3u stream limit 2017-11-17 16:54:33 -05:00
Luke Pulverenti 5cb7469028 support track selection before playback 2017-11-05 16:51:23 -05:00
Luke Pulverenti 76e2482047 reset PrePaddingSeconds on recording retry 2017-10-24 01:19:06 -04:00
Luke Pulverenti 9b71812325 update live stream management 2017-10-23 15:14:11 -04:00
Luke Pulverenti 060215143f improve httpclient resource disposal 2017-10-20 12:16:56 -04:00
Luke Pulverenti 4ef9f68837 support delete per library 2017-10-16 02:10:55 -04:00
Luke Pulverenti e19b8f81c7 update recording conversion 2017-10-07 02:13:26 -04:00
Luke Pulverenti 99c858c338 update recording file names 2017-09-29 02:12:52 -04:00
Luke Pulverenti 2e0e1697a8 rework live stream creation 2017-09-28 13:02:49 -04:00
Luke Pulverenti cdd79ec7e2 update owned items 2017-09-18 12:52:22 -04:00
Luke Pulverenti 1f12ab6658 add yadif setting 2017-09-17 02:42:23 -04:00
Luke Pulverenti adc22b5e81 rework epg storage 2017-09-08 12:13:58 -04:00
Luke Pulverenti 33e31d246f consolidate 2017-09-08 01:39:55 -04:00
Luke Pulverenti 49b799adbe 3.2.30.8 2017-09-05 15:49:02 -04:00
Luke Pulverenti 39c4542cf6 update query objects 2017-09-04 15:28:22 -04:00
Luke Pulverenti ed81591175 update dto methods 2017-08-27 20:33:05 -04:00
Luke Pulverenti e441e2f53d update active recordings 2017-08-24 15:52:19 -04:00
Luke Pulverenti afd94407f9 rework active recordings 2017-08-23 15:45:52 -04:00
Luke Pulverenti 3c1fe6ff83 add experimental warning for folder rip transcoding 2017-08-22 01:41:02 -04:00
Luke Pulverenti b783f317fe update live stream management 2017-08-19 18:37:15 -04:00
Luke Pulverenti 1ad990ad72 update live tv data transfer 2017-08-19 15:43:35 -04:00
Luke Pulverenti b7867214ef update download error handling 2017-08-11 17:55:48 -04:00
Luke Pulverenti 40442f887b consolidate emby.server.core into emby.server.implementations 2017-08-09 15:56:38 -04:00
Luke Pulverenti 4e52c027bc improve nextup queries 2017-08-01 12:45:57 -04:00
Luke Pulverenti d270b10db6 move auto-organize to plugin 2017-07-27 01:18:39 -04:00
Luke Pulverenti 1e5c3db9eb support individual library refreshing 2017-06-23 12:04:45 -04:00
Luke Pulverenti e91f569c15 update live tv startup 2017-06-03 03:36:32 -04:00
Luke Pulverenti 0f1d253278 update DirectRecorder 2017-06-01 01:43:08 -04:00
Luke Pulverenti 3e15b28b18 add IsInterlaced param 2017-05-29 08:35:59 -04:00
Luke Pulverenti 33014f77aa update GetItems method 2017-05-26 02:48:54 -04:00
Luke Pulverenti 54cf0da758 update query fields 2017-05-22 00:54:02 -04:00
Luke Pulverenti da77b05817 update data queries 2017-05-21 03:25:49 -04:00
Luke Pulverenti 7446d2803d update recording 2017-05-15 15:47:16 -04:00
Luke Pulverenti 83c1503333 update recorder 2017-05-15 15:45:39 -04:00
Luke Pulverenti d48496b843 add new search filters 2017-05-06 15:45:23 -04:00
Luke Pulverenti 696a6b34ea improve smb support 2017-05-04 14:14:45 -04:00
Luke Pulverenti 568d769cc8 support omdb episodes by imdb; add more search data 2017-05-03 17:53:33 -04:00
Luke Pulverenti 9212ffb528 update encoded recorder 2017-05-02 08:53:21 -04:00
Luke Pulverenti f53472584e update environment detection 2017-04-29 02:22:33 -04:00
Luke Pulverenti 491886632d update remote control responses 2017-04-25 14:23:20 -04:00
Luke Pulverenti 8755886761 switch to hwaccel auto 2017-04-21 16:03:07 -04:00
Luke Pulverenti eedf62d80d update keep up to deletion 2017-04-15 15:46:07 -04:00
Luke Pulverenti d1e2ccdfec update default library name 2017-03-28 13:30:47 -04:00
Luke Pulverenti 690ab4a2dc update recording mp4 args 2017-03-26 00:22:30 -04:00
Luke Pulverenti e6178a65f9 rework tuner channel id 2017-03-26 00:21:32 -04:00
Luke Pulverenti b2f7352094 improve m3u parsing 2017-03-25 18:08:43 -04:00
Luke Pulverenti c9be9b4141 update hls params 2017-03-24 11:03:49 -04:00
Luke Pulverenti ce1ed2bea7 update hls to support mpeg2video 2017-03-15 15:57:18 -04:00
Luke Pulverenti 296e5bfe32 update handling of new programs for xml tv 2017-03-14 15:44:35 -04:00
Luke Pulverenti a0934e6226 continue with tuner discovery 2017-03-13 16:42:21 -04:00
Luke Pulverenti a8fc480489 rework tuner setup 2017-03-13 14:57:45 -04:00
Luke Pulverenti f05dc08c06 update tuner discovery 2017-03-13 00:49:10 -04:00
Luke Pulverenti a660aa001e re-organize file streaming 2017-03-12 15:27:26 -04:00
Luke Pulverenti a181425e54 omit input container when hw encoding 2017-03-01 15:29:42 -05:00
Luke Pulverenti c33b12ba7d update m3u channel mapping 2017-02-23 14:13:26 -05:00
Luke Pulverenti 6847cac829 update recording conversion 2017-02-22 15:58:02 -05:00
Luke Pulverenti 8d3e94ffb1 update recording conversion 2017-02-21 13:04:35 -05:00
Luke Pulverenti 149d16a314 preserve manual recording overrides 2017-02-20 02:04:03 -05:00
Luke Pulverenti 0ee1a0d7bd fix mapping multiple tuner channels to same epg channel 2017-02-18 22:46:09 -05:00
Luke Pulverenti 36f8eb1149 add db startup error handling 2017-02-17 16:11:13 -05:00
Luke Pulverenti 58fad600c9 restore changes 2017-02-09 19:42:57 -05:00
Luke Pulverenti 9a59d12241 update channel image urls 2017-02-09 19:15:07 -05:00
Luke Pulverenti 35415d6a50 add error handling 2017-02-09 18:59:27 -05:00
Luke Pulverenti 1e28de1098 update channel mapping 2017-02-08 16:29:08 -05:00
Luke Pulverenti 4941aa4d14 assume interlaced for external plugins 2017-02-08 14:59:49 -05:00
Luke Pulverenti fbb1bb319c update wdtv live dlna profile 2017-02-07 13:33:15 -05:00
Luke Pulverenti b35051463b restore features 2017-02-06 01:05:34 -05:00
Luke Pulverenti f94353250f disable input modifiers for now 2017-02-06 01:04:38 -05:00
Luke Pulverenti 851364f84f rework guide mappings 2017-02-04 18:32:16 -05:00
Luke Pulverenti 1d849e3f25 update xmltv parsing 2017-02-01 02:47:12 -05:00