Commit graph

340 commits

Author SHA1 Message Date
cvium f2cba352e5 catch ioexception and include stack trace 2021-04-09 23:30:07 +02:00
cvium 5c4be2416d Remove unused import 2021-04-09 13:48:25 +02:00
cvium 53db1a1ffc ... 2021-04-09 13:47:47 +02:00
cvium 457229c56d Simplification 2021-04-09 13:43:40 +02:00
cvium 69d2368fbc Copy paste error 2021-04-09 13:31:17 +02:00
cvium e7fc18d0f3 Fix type check 2021-04-09 13:28:27 +02:00
cvium 08ccf2a49c Resolve name from episode folder 2021-04-09 13:20:12 +02:00
Claus Vium a21b2714e7
fetching images should not kill the scanner 2021-04-09 12:03:56 +02:00
Bond-009 066c19a26b
Fix possible null ref exception 2021-03-24 21:06:03 +01:00
Claus Vium 90cdd1345d
Merge pull request #5407 from Bond-009/hack 2021-03-08 21:23:14 +01:00
Bond_009 54f81c4da4 Call ToLower on CollectionTypeOptions.ToString 2021-03-08 12:08:17 +01:00
cvium 946411be8e Remove redundant check 2021-03-06 21:18:20 +01:00
cvium 67af30d1ff Remove redundant checks 2021-03-06 20:53:50 +01:00
cvium 37e374d33d make sure network path substitution matches correctly 2021-03-05 14:09:23 +01:00
Bond_009 81f527f808 CollectionType can be null 2021-02-24 11:57:04 +01:00
Bond_009 1c74e2f40e Fix build 2021-02-24 02:57:10 +01:00
Bond_009 914e891689 Fix unchecked input 2021-02-24 02:05:12 +01:00
cvium 3f6e6c4839 Simplify 2020-12-10 14:47:47 +01:00
cvium 3c5bbeb80c Remove ImageFetcherPostScanTask 2020-12-10 13:38:33 +01:00
crobibero b5a7a74e89 Use GetParentItem where applicable 2020-12-01 16:16:17 -07:00
crobibero c083b29e29 Use Guid as API parameter type where possible 2020-12-01 11:07:41 -07:00
Joshua M. Boniface bf54b5579c
Merge branch 'master' into defer_image_fetching 2020-11-21 17:20:31 -05:00
Joshua M. Boniface 7457c4a95d
Merge pull request #4499 from crobibero/more-param
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
2020-11-20 12:34:18 -05:00
crobibero 3cc0dd7e12 Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage. 2020-11-16 20:29:46 -07:00
BaronGreenback 2bbfcc264d
Merge branch 'master' into emby-namig-nullable 2020-11-16 19:47:36 +00:00
crobibero e66d79fc0c Merge remote-tracking branch 'upstream/master' into http-exception 2020-11-15 13:09:05 -07:00
crobibero 95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
Bond_009 ff49a3bb61
Missed some stuff 2020-11-14 20:28:15 +01:00
Stepan c0747512d6 Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable 2020-11-10 12:42:49 +01:00
cvium 584b4fa41f Fix Persons, Genres and Studios endpoints 2020-11-05 12:27:22 +01:00
Stepan 60b49e67ea Re-Sharper inspection issues 2020-11-01 11:19:22 +01:00
Stepan 59619b6ea7 Enable nullable in Emby.Naming 2020-11-01 10:47:31 +01:00
cvium 763862cbd8 Defer image pre-fetching until the end of a refresh/scan 2020-10-03 13:36:53 +02:00
Bond_009 edbd4e0db6 Remove extra return statement 2020-09-11 12:57:57 +02:00
Bond_009 441301069e Fix 2020-09-11 12:56:11 +02:00
Bond_009 48e1cf9fd7 Minor performance improvements to item saving 2020-09-09 13:38:27 +02:00
Bond_009 119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
Bond_009 ab2147751f Make MediaBrowser.MediaEncoding warnings free 2020-08-20 12:16:24 +02:00
cvium 0cf75992a8 Use MemoryCache.Set since SetValue does not flush to cache automatically. 2020-08-07 11:55:22 +02:00
Bond-009 b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
Migrate Display Preferences to EF Core
2020-08-01 21:51:49 +02:00
dkanada e0d2eb8eec
remove useless order step for intros 2020-08-01 02:03:23 +09:00
Patrick Barron e5c6eec642 Use MemoryCache in LibraryManager 2020-07-29 17:28:15 -04:00
Bond-009 3ff110984a
Merge branch 'master' into readonlyspan 2020-07-24 09:40:44 +02:00
Patrick Barron 3d69cea1c9
Merge branch 'master' into displaypreferences-efcore 2020-07-23 23:50:12 +00:00
Joshua M. Boniface 0d446c8755
Merge pull request #3609 from Bond-009/warn21
Fix warnings
2020-07-23 18:06:34 -04:00
Bill Thornton e973757485 Simplify logic 2020-07-22 11:32:29 -04:00
Bond_009 febb6bced6 Review usage of string.Substring (part 1)
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Bill Thornton 2fa2952791 Skip image processing for live tv sources 2020-07-21 16:40:38 -04:00
Bond_009 7324b44c43 Fix warnings 2020-07-20 11:01:37 +02:00
Patrick Barron b53bf2cd16 Remove obsolete network path code 2020-07-18 16:21:01 -04:00
crobibero e152a6c82f Increase delete logging 2020-07-17 15:53:10 -06:00
Patrick Barron ab396225ea Migrate Display Preferences to EF Core 2020-07-17 16:11:53 -04:00
dkanada bb7444db07
Merge pull request #3439 from cvium/ignore_application_folders
Never ignore application folders
2020-06-26 06:14:19 +09:00
crobibero 9eba11379a catch skia errors when getting image dimensions 2020-06-25 12:10:33 -06:00
Claus Vium 0f07b19ca5 Remove AllowIgnorePath 2020-06-25 11:33:10 +02:00
Bond-009 f75024fade Fix scan crashed 2020-06-22 10:06:35 +02:00
telans 8de6452967
fix some documentation periods 2020-06-20 18:13:11 +12:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
telans 3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
Patrick Barron 42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
dkanada 403cd3205f
Merge pull request #3254 from crobibero/ilogger
Use typed logger where possible
2020-06-13 00:29:43 +09:00
Patrick Barron 7a115024aa Merge branch 'master' into userdb-efcore
# Conflicts:
#	MediaBrowser.Controller/Library/ILibraryManager.cs
#	MediaBrowser.Providers/Users/UserMetadataService.cs
2020-06-11 18:23:12 -04:00
crobibero 7ed5cf3dca Force configuration paths to not be ignored. 2020-06-07 20:32:06 -06:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron 06f9cde22f Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Bond-009 2dbb9d4895 Fix build 2020-06-03 11:54:01 +02:00
Vasily 40502a33e0
Merge pull request #3203 from Bond-009/warn18
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
2020-06-03 12:27:59 +03:00
Vasily 26eef1bbf8 Move logic of computing Blurhash components to ImageProcessor
Also rename last few instances of GetImageHash to GetImageBlurHash for clarity
2020-06-01 18:12:49 +03:00
Bond_009 4748105dce Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode 2020-05-29 11:28:19 +02:00
Vasily 9208acd5ae Convert non-local image to local before computing blurhash 2020-05-28 17:55:29 +03:00
Vasily ed791dee46 Do not compute dimensions or blurhash for remote images 2020-05-28 17:30:11 +03:00
Vasily edcfcadcd3 Make sure blurhash is recomputed if image changed or metadata refresh toggled 2020-05-27 17:00:59 +03:00
Vasily 6c9dc04189 Handle errors during blurhash generation so it does not fail the scan 2020-05-27 15:01:03 +03:00
Vasily 29443e3681
Apply suggestions from code review
Co-authored-by: dkanada <dkanada@users.noreply.github.com>
2020-05-26 00:50:29 +03:00
Vasily 1f83a21288 Rename Hash to BlurHash in all properties and methods for clarity 2020-05-21 01:43:19 +03:00
Vasily 8b517e9bef Fix nullref for imageProcessor in LibraryManager 2020-05-21 00:03:22 +03:00
Patrick Barron c464f700db Remove redundant qualifiers 2020-05-20 13:07:53 -04:00
Vasily 186b7f303c More small optimizations 2020-05-19 15:08:43 +03:00
Vasily a226a4ee03 Compute hash only when one is not computed in DB, small optimizations here and there 2020-05-19 14:50:14 +03:00
Vasily bfb644d5f5 Fix nullref exception 2020-05-19 13:45:39 +03:00
Vasily 02da312f8a Fix compilation after rebase 2020-05-19 00:22:52 +03:00
Jesús Higueras fe480caf54 Add endpoint to update all items in library 2020-05-18 23:21:38 +03:00
Jesús Higueras b9fc0d2628 Add BlurHash support to backend 2020-05-18 23:21:37 +03:00
Patrick Barron 9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
Mark Monteiro bc4e72b29b Create ApplicationHost logger correctly 2020-04-20 20:48:39 -04:00
Mark Monteiro f815059698 Merge remote-tracking branch 'upstream/master' into register-services-correctly 2020-04-20 20:11:33 -04:00
Mark Monteiro 1e1295bebf Merge remote-tracking branch 'upstream/master' into register-services-correctly 2020-04-11 10:00:39 -04:00
Bond_009 d8a7462205 DvdLib: remove dependency on MediaBrowser.Model 2020-04-11 12:33:23 +02:00
Vasily 06c5b73c15
Merge pull request #2755 from Bond-009/dbcleanup
Clean up SqliteItemRepository
2020-04-10 00:20:53 +03:00
Mark Monteiro fe9f4e06d1 Register and construct LibraryManager correctly 2020-04-04 18:28:46 -04:00
Bond_009 8e7b15285e Clean up SqliteItemRepository 2020-04-03 20:59:38 +02:00
Mark Monteiro 34204046dd Remove duplicate array of extras directory names 2020-04-01 18:53:53 +02:00
Bond-009 94fe9b8f6d
Merge branch 'master' into warn17 2020-03-11 20:26:43 +01:00
Vasily 13d30a0a79
Merge pull request #2436 from dkanada/music
Add config options for MusicBrainz
2020-03-02 12:54:17 +03:00
Bond_009 07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
dkanada 6715450598
Merge pull request #2427 from Bond-009/minor
Minor improvements
2020-02-23 10:48:47 +09:00
dkanada 65a9d618cc add config options for musicbrainz 2020-02-22 15:04:52 +09:00
Bond_009 adc9fc282c Minor improvements 2020-02-19 23:08:58 +01:00
Ulrich Wagner 3bd7633cbf
Update Emby.Server.Implementations/Library/LibraryManager.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-19 19:47:03 +01:00
Ulrich Wagner a9e744bea0 Curly braces on new lines 2020-02-19 19:41:10 +01:00
Ulrich Wagner 3d9dc59554 Omitting the parameter ExtraChapters 2020-02-19 19:03:42 +01:00
Ulrich Wagner f4d0fa8dc8
Update Emby.Server.Implementations/Library/LibraryManager.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-19 18:58:28 +01:00
Ulrich Wagner d6971581d6
Update Emby.Server.Implementations/Library/LibraryManager.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-19 17:46:50 +01:00
Ulrich Wagner 0f2ee2686d Constructor of the LibraryManager takes the mediaEncoder as parameter 2020-02-19 16:06:30 +01:00
Ulrich Wagner b16ba7d985
Update Emby.Server.Implementations/Library/LibraryManager.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-19 13:40:27 +01:00
Ulrich Wagner 7005326685
Update Emby.Server.Implementations/Library/LibraryManager.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-19 13:40:06 +01:00
Ulrich Wagner 4d0ee3f6cc
Update Emby.Server.Implementations/Library/LibraryManager.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-19 13:39:51 +01:00
Ulrich Wagner 39b6d6586f
Update Emby.Server.Implementations/Library/LibraryManager.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-19 13:37:36 +01:00
Ulrich Wagner 5fed4d10ab Only reading the result of GetMediaInfo if it completed successfully 2020-02-19 08:39:01 +01:00
Ulrich Wagner d7f199bb1c #2407: Prefer MP4-Metadata for episodes 2020-02-17 14:57:07 +01:00
Bond-009 d5fcca3d05
Merge branch 'master' into naming 2020-02-05 23:28:00 +01:00
dkanada 692a9bfdd0
update some comments
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2020-02-01 23:36:40 +09:00
dkanada afe9ed977b improve scan progress and fix a few bugs 2020-02-01 22:44:27 +09:00
Bond_009 dc62e436c4 Clean up Emby.Naming 2020-01-22 22:18:56 +01:00
Bond_009 abf03f7d3a Clean up some more 2020-01-11 22:17:05 +01:00
Vasily dd7feacd34
Merge pull request #2105 from Bond-009/namingtests
Add back all old emby tests
2020-01-11 02:11:13 +03:00
Bond_009 bb236b9591 Merge branch 'master' into warn12 2020-01-10 21:18:16 +01:00
Bond_009 b50c4938e1 Merge branch 'master' into namingtests 2020-01-09 18:26:22 +01:00
dkanada c10cb66169
remove directory check 2020-01-01 14:45:09 +09:00
Bond-009 6b185119aa
Merge branch 'master' into namingtests 2019-12-17 17:35:27 +01:00
dkanada 28e922326d
remove space
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-12-15 13:38:59 +09:00
dkanada 623e85a9e4
add suggested changes
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-12-14 22:34:18 +09:00
dkanada 1b2453b4e9 fix playlist deletion 2019-12-14 12:51:27 +09:00
Bond_009 2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
dkanada 67922dff50
Merge pull request #2041 from Bond-009/warn11
Fix more warnings
2019-12-11 01:14:55 +09:00
Bond_009 35151553e3 Add back all old emby tests 2019-12-06 20:41:39 +01:00
Bond-009 a2c35e6dba Merge remote-tracking branch 'upstream/master' into random 2019-12-06 12:06:13 +01:00
Bond_009 42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
dkanada f51f59d675
Merge pull request #1965 from Bond-009/dbjson
Deserialize with the correct type (and warning fixes)
2019-11-10 16:51:54 +09:00
dkanada 61b9b4046a
Merge pull request #1929 from Narfinger/parser-fix4
[Draft][Help wanted] Fix parsing of certain names and adds a default season if no season was found
2019-11-08 02:14:01 +09:00
Narfinger 9cd62d661f removed restriction to 3 digits in episodenumber and 4 in season numbers 2019-11-07 10:50:02 +09:00
Bond_009 846857b60e Deserialize with the correct type (and warning fixes) 2019-11-01 17:07:42 +01:00
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Narfinger 4a20260a27 add another parser case and allow parsing of seasonless
Add another parser case and we now allow parsing of seasonless series which hopefully should cover more cases of directory structure
2019-10-22 15:46:35 +09:00
Bond_009 bbc0875387 Don't shuffle some types by default 2019-10-20 16:08:40 +02:00
Joshua Boniface baa30b41de Add debug logs and try/catch when creating folder 2019-09-02 23:32:03 -04:00
Bond-009 ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond-009 a6f9ceedd8 Fix more warnings 2019-06-01 11:31:27 +02:00
Bond-009 bf43dc00bb More warning fixes 2019-03-13 22:32:52 +01:00
Bond_009 37ea50a572 Reduce the amount of exceptions thrown 2019-03-07 21:42:56 +01:00
Joshua M. Boniface 89d4ce309d
Merge pull request #848 from Bond-009/perf
Minor changes to reduce allocations
2019-02-19 21:24:51 -05:00
Bond_009 3e6819c718 Don't clone lists 2019-02-12 21:06:47 +01:00
Bond_009 41fb1e5106 Tuple -> ValueTuple 2019-02-12 21:06:47 +01:00
Bond_009 64d5ec12e2 Use HashSets for increased perf 2019-02-12 21:06:47 +01:00
Bond_009 a6a4cd5667 Removed some unused fields 2019-02-09 15:57:42 +01:00
Joshua M. Boniface c713824bf9
Merge pull request #734 from Bond-009/culture
Fix more analyzer warnings
2019-01-31 21:11:13 -05:00