Commit graph

1781 commits

Author SHA1 Message Date
ArabCoders faa036aa7b Added access validation to view item user data. 2023-11-13 15:55:12 +03:00
ArabCoders 2a25c5a2e3 Refactored api call logic handling. 2023-11-13 15:51:06 +03:00
Patrick Barron de0241e975 Move API policies to MediaBrowser.Common 2023-11-12 10:24:35 -05:00
Patrick Barron e463dbda47 Move network configuration to MediaBrowser.Common 2023-11-12 10:24:35 -05:00
ArabCoders 250e795c3b Typo fixes. 2023-11-12 18:12:34 +03:00
ArabCoders bce22fcc2a Added new API endpoint to update User item data 2023-11-12 17:52:24 +03:00
Cody Robibero 892973a9e3
Merge branch 'master' into media-type 2023-11-09 22:03:55 -07:00
Cody Robibero 906f701fa8
Convert CollectionType, SpecialFolderType to enum (#9764)
* Convert CollectionType, SpecialFolderType to enum

* Hide internal enum CollectionType values

* Apply suggestions from code review

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>

* Fix recent change

* Update Jellyfin.Data/Attributes/OpenApiIgnoreEnumAttribute.cs

Co-authored-by: Patrick Barron <barronpm@gmail.com>

---------

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
Co-authored-by: Patrick Barron <barronpm@gmail.com>
2023-11-09 14:00:29 -07:00
Cody Robibero c7a94d48ae
Convert ItemSortBy to enum (#9765)
* Convert ItemSortBy to enum

* Rename Unknown to Default
2023-11-09 14:00:13 -07:00
Bond_009 a9ef103c95 Add IDisposableAnalyzers to more projects 2023-11-05 02:01:14 +01:00
Steve Kowalik 9785b58b85 Correct docstring for /Upcoming
The docstring for /Upcoming looks very similar to /NextUp, also
including the same return value, when it should be slightly different,
correct it.
2023-11-02 22:00:13 +11:00
Claus Vium db4605609c
Merge pull request #10410 from Ch1nkara/add-users-permission-to-edit-subtitles
add EnableSubtitleManagement permission
2023-10-27 09:44:52 +02:00
Nick cd662506a1 Merge branch 'master' into trickplay 2023-10-18 19:27:05 -07:00
chinkara 8ada8dbbac add policy to the subtitle controller 2023-10-18 18:31:32 +02:00
Nick c7feea27fd Avoid unnecessary string -> byte[] conversion (Bond-009) 2023-10-13 16:13:42 -07:00
Stepan Goremykin 38d962242a Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Updates/InstallationManager.cs
#	tests/Jellyfin.Server.Integration.Tests/OpenApiSpecTests.cs
2023-10-14 00:45:52 +02:00
Bond-009 4fc27fa63e
Merge pull request #10390 from Bond-009/streams 2023-10-13 10:45:15 +02:00
Bond-009 5277339982
Merge pull request #10391 from barronpm/dlna-cleanup 2023-10-13 10:44:54 +02:00
Stepan Goremykin 8d7e4229ca Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Net/SocketFactory.cs
#	RSSDP/SsdpCommunicationsServer.cs
#	RSSDP/SsdpDeviceLocator.cs
#	RSSDP/SsdpDevicePublisher.cs
2023-10-12 20:11:16 +02:00
Bond_009 d7748cfa04 Multiple Stream changes
* Remove useless MemoryStream in DlnaHttpClient
* Use HttpContent.ReadFromJsonAsync extension
* Call ConfigureAwait for IAsyncDisposable
* Use HttpContent.CopyToAsync where possible
2023-10-11 18:32:57 +02:00
Patrick Barron 010cf2340a Use DI for MediaReceiverRegistrarService 2023-10-11 11:12:33 -04:00
Patrick Barron e0b089a375 Use DI for ConnectionManagerService 2023-10-11 11:08:19 -04:00
Patrick Barron effc3d488c Use DI for ContentDirectoryService 2023-10-11 11:05:14 -04:00
Bond_009 35d63ec540 Fix regression 2023-10-11 13:43:43 +02:00
Cody Robibero 2920611ffc Convert string MediaType to enum MediaType 2023-10-10 15:57:15 -06:00
lonebyte 74f61fbd79
Fix HLS playback of m4a files with mjpeg stream (#10069) 2023-10-10 22:48:52 +02:00
Bond-009 fc1f0a31a1
Merge pull request #10337 from barronpm/system-manager 2023-10-10 13:12:43 +02:00
Bond-009 d5695efad9
Merge pull request #10067 from lonebyte/flac-hls-fixes 2023-10-09 18:28:49 +02:00
Nyanmisaka aa073748c0
Drop experimental status of flac-in-MP4 for FFmpeg 6+
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-10-09 23:12:41 +08:00
Bond-009 d5e86188a1
Merge pull request #10346 from Bond-009/frombase64 2023-10-08 14:07:44 +02:00
Bond-009 0b31997b2f
Merge pull request #10348 from Bond-009/strings 2023-10-08 14:07:30 +02:00
Stepan Goremykin 160855ffe9 Use switch expression 2023-10-08 00:52:47 +02:00
Stepan Goremykin 47254d6a22 Remove conditional access when it is known to be not null 2023-10-08 00:46:15 +02:00
Bond-009 1141883f77
Merge pull request #10321 from feilongfl/master 2023-10-07 00:15:01 +02:00
Bond_009 b176beb88e Reduce string allocations
Some simple changes to reduce the number of allocated strings
2023-10-06 01:04:25 +02:00
Bond_009 efc4c305a9 Use CryptoStream to convert stream from base64
Should be way more efficient
2023-10-05 23:36:37 +02:00
Patrick Barron 6f7413812f Add SystemManager service 2023-10-04 14:40:00 -04:00
Patrick Barron fa26bcde3a Remove unnecessary ToString in RobotsRedirectionMiddleware 2023-10-03 09:29:06 -04:00
Patrick Barron 1ca9f8b04b Remove unused fields and parameters 2023-10-03 09:26:20 -04:00
Patrick Barron f746db9a54 Re-add shutdown/restart methods 2023-10-02 15:55:26 -04:00
YuLong Yao b83217d1d7
use pcm as ext name when codec is pcm 2023-10-02 13:13:29 +08:00
Patrick Barron 493de3297a Use IHostLifetime to handle restarting and shutting down 2023-09-23 11:57:38 -04:00
Jan Müller 1635d82345 Remove workaround for codec capitalization
This is not required anymore as Shaka Player now supports the correct
codec strings.
2023-09-16 12:57:20 +02:00
Jan Müller fd022ee685 Merge branch 'master' into flac-hls-fixes
# Conflicts:
#	Jellyfin.Api/Controllers/DynamicHlsController.cs
2023-09-16 12:40:05 +02:00
Bill Thornton 9c64f94458 Add option to include resumable items in next up requests 2023-09-06 00:35:32 -04:00
nyanmisaka b2dcc7c90e Fix AV1 playback in LiveTV
AV1 in fMP4 requires global_header data for parsing.
Only disable global_header in TS since it has no global_header.

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-09-02 00:25:40 +08:00
Nyanmisaka c74d3e62d0
Fix the issue that audio bsf only takes effect for remuxing (#10172)
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-08-30 17:18:18 -06:00
Bond_009 18a311d32f == null -> is null 2023-08-22 21:14:54 +02:00
Claus Vium 956e3dab43
fix: accessing Standard* of a Process requires manually disposing them afterwards (#10125) 2023-08-20 20:06:57 +02:00
Nick 65b269c151 Minor code formatting (cvium) 2023-08-16 21:31:34 -07:00
Bond-009 07727e1d63
Merge pull request #9875 from Shadowghost/fixes 2023-08-01 20:26:21 +02:00
Jan Müller 79cff704ff Allow flac inside mp4 for all HLS audio streams
The -strict -2 setting was only added if the encoder was set to 'copy'.
If 'flac' is explicitly requested, we also need to set it, so that
ffmpeg doesn't abort the conversion.

Fixes: #10066
2023-08-01 19:12:52 +02:00
Jan Müller 19fb061381 Correct the HLS Opus codec string
Apple doesn't support Opus via HLS yet, but if they ever do, they will
definitely expect "Opus" instead of "opus".

See https://mp4ra.org/#/codecs

Fixes: #10066
2023-08-01 19:06:30 +02:00
Jan Müller e9f23c61c9 Fix the fLaC/flac HLS issue also for audio-only
I moved the first application of the workaround out of the if block
so that it also applies to audio-only streams. The workaround was
extended likewise.

We should first and foremost adhere to the specifications and apply
workarounds afterwards for software that doesn't follow them. So I
turned around the workaround to first output the fLaC variant and then
the alternative flac variant.

Fixes: #10066
2023-08-01 17:11:32 +02:00
Jan Müller dd75f35a1a Fix the is-local check when resetting the password
This fixes the check whether a warning should be logged when resetting
the password from outside the local network.

Fixes: #10059
2023-07-31 21:49:51 +02:00
MBR-0001 9564248b10
Add ability to upload (and save) SDH subtitles (#10036) 2023-07-29 06:52:35 -06:00
Shadowghost 368f9202ce Apply review suggestions 2023-07-15 20:15:11 +02:00
Shadowghost 05d98fe24c Enforce permissions on websocket connections 2023-07-07 08:50:37 +02:00
Joshua M. Boniface 93b400343e
Merge pull request #8147 from Shadowghost/network-rewrite 2023-07-03 13:16:21 -04:00
Nick 6d9e43cfe0 Merge branch 'master' into trickplay 2023-06-28 21:43:23 -07:00
Bond-009 e53e53eb29
Merge pull request #9907 from nyanmisaka/av1e 2023-06-28 17:34:20 +02:00
Bond-009 4ac07f6c76
Merge pull request #9890 from Shadowghost/videorange-rework 2023-06-28 17:30:26 +02:00
Shadowghost 20a4509991 Migrate VideoRange and VideoRangeType to Enum 2023-06-28 12:02:20 +02:00
Bond-009 1e38bc80de
Merge pull request #9909 from Bond-009/playlist 2023-06-27 16:22:08 +02:00
Shadowghost a6e9824e8a Merge branch 'master' into network-rewrite 2023-06-27 16:15:57 +02:00
Nick ab20ceaad6 Migrate to trickplay table to EF. Rename vars/methods/members to have consistent use of tile and thumbnail 2023-06-26 17:40:10 -07:00
nyanmisaka df880ff785 Apply suggestions from code review
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-06-25 21:39:25 +08:00
Nick 619d1d47f2 Move GetHlsPlaylist to ITrickplayManager 2023-06-23 14:22:00 -07:00
Nick 049361b66c TrickplayController return 404 if playlist doesn't exist. Minor code style/format changes (crobibero) 2023-06-22 16:23:52 -07:00
Nick d338253242 Fix styling for string builder 2023-06-22 16:23:52 -07:00
Nick 98e41d5a14 Styling, format, minor code changes (crobibero) 2023-06-22 16:23:52 -07:00
Nick fe1c9d43ce Fix using order 2023-06-22 16:23:52 -07:00
nicknsy d448cc18ea update 2023-06-22 16:19:59 -07:00
nicknsy b18d6bd356 Trickplay playlist and image controller 2023-06-22 16:19:59 -07:00
nicknsy 515ee90fb9 Hls playlist 2023-06-22 16:19:59 -07:00
Bond-009 a1eb2f6ea8
Merge pull request #9915 from Bond-009/stylecop 2023-06-22 13:26:18 +02:00
Bond-009 3982b0e057
Reduce bottlenecks scan code (#9863) 2023-06-21 21:01:47 -06:00
Bond_009 b84eedd0b9 Update stylecop.analyzers to v1.2.0-beta.507 2023-06-22 00:39:32 +02:00
Shadowghost 67a58df1a3 Merge branch 'master' into network-rewrite 2023-06-21 07:57:00 +02:00
Bond_009 f04cfd6ef4 Don't ignore parentId for playlists 2023-06-20 18:06:30 +02:00
Nyanmisaka f8d7f4acdb
Apply suggestions from code review
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2023-06-20 05:09:22 +08:00
Nyanmisaka 3b12dc6d7a
Apply suggestions from code review
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-06-20 04:18:55 +08:00
nyanmisaka 0df6fd9cf2 Add AV1 support in HLS streaming
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-06-20 03:50:02 +08:00
Dominik 0dffe64489 Add baseUrlParam back in and fix indentation 2023-06-15 19:55:11 +02:00
Dominik 17f1e8d19b
Merge branch 'master' into segment-deletion 2023-06-15 19:38:42 +02:00
Shadowghost 006b04dc0b Merge branch 'master' into network-rewrite 2023-06-07 08:25:32 +02:00
Bond-009 6dca53047f
Merge pull request #9818 from Shadowghost/fixes 2023-05-30 10:00:53 +02:00
Cody Robibero d8f0933f33
Merge pull request #9821 from cvium/admin_must_have_pw 2023-05-29 18:38:01 -06:00
cvium 29ef02af9a do not allow empty admin password during wizard 2023-05-26 21:50:51 +02:00
cvium b33f46560d use 403 instead to avoid compat issues with swagger spec 2023-05-26 19:45:40 +02:00
cvium 716bcc6410 chore: deprecate EasyPassword as it isn't very secure 2023-05-26 19:40:40 +02:00
Shadowghost 81746666de Fix TotalRecordCount calculation 2023-05-26 11:06:04 +02:00
Shadowghost d8d5c86d49 Merge branch 'master' into network-rewrite 2023-05-25 17:07:43 +02:00
Claus Vium d1e52b6ee3
Merge pull request #9771 from Shadowghost/recursive-tags 2023-05-18 10:05:50 +02:00
Bill Thornton 155f3856c0 Use default files to remove index.html from url 2023-05-15 15:28:33 -04:00
Shadowghost eb52af4e6a
Fix playlists library and migration (#9770) 2023-05-15 06:45:33 -06:00
Shadowghost ec32c56d3f Set removed and added tags recursively 2023-05-14 21:45:46 +02:00
Shadowghost a8cdf4434b
Fix access to playlists not created by a user (#9746) 2023-05-12 07:11:59 -06:00
Shadowghost c042f20224 Merge branch 'master' into network-rewrite 2023-05-11 15:41:39 +02:00
Shadowghost d5fec4963e
Fix FirstTimeSetupHandler not failing on invalid user if not in setup mode (#9747) 2023-05-10 14:05:27 -06:00
Shadowghost 6cc1203c1b Merge branch 'master' into network-rewrite 2023-05-09 15:25:41 +02:00
Stepan Goremykin 910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
Stepan Goremykin 26958162d0 Remove unused using directives 2023-04-06 19:17:28 +02:00
Stepan Goremykin e74630a613 Use MinBy and MaxBy 2023-04-01 23:00:51 +02:00
Bond-009 a1eddbb330
Merge pull request #9541 from Bond-009/apikeydelete 2023-03-29 12:20:34 +02:00
Bond-009 9c500bdca3
Merge pull request #9466 from Shadowghost/playlist-fix 2023-03-28 10:58:48 +02:00
Bond_009 8316bd590e Fix #7610 2023-03-27 15:22:21 +02:00
knackebrot e0a7e9baa0 Fix audio VBR calculation
Pass encoder, not codec
2023-03-21 15:01:32 +01:00
Bond-009 2ce08eb184
Merge pull request #9388 from Shadowghost/output-bitrate-channels-master 2023-03-20 17:46:11 +01:00
Shadowghost 82080bd1ef Apply review suggestions 2023-03-17 11:43:53 +01:00
Shadowghost 520c07e8ca Merge branch 'master' into network-rewrite 2023-03-16 11:07:22 +01:00
Bond_009 d8ec3a5470 Reduce usage of GetAwaiter().GetResult() 2023-03-14 12:05:49 +01:00
Shadowghost 76ae599bd3 Fix playlist creation and removal 2023-03-10 19:16:35 +01:00
SenorSmartyPants 369c7f1451
Save TVChannel Height if set (#8777)
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-10 10:03:11 -07:00
Bond-009 6351d1022b
Merge pull request #9254 from Shadowghost/dvdbdfix 2023-03-10 15:48:35 +01:00
Shadowghost 0da5255f12 Apply review suggestions 2023-03-10 15:27:17 +01:00
Shadowghost 47aa07c342 Fix DLNA playback of DVD and BD folders 2023-03-10 15:27:17 +01:00
Shadowghost 2403a0a367 Apply review suggestions 2023-03-10 15:27:05 +01:00
nyanmisaka f21ab50a81 Backport pull request #9422 from jellyfin/release-10.8.z
Fix stream map when using filter_complex with unlabeled output

Original-merge: 6821a2ab35

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: crobibero <cody@robibe.ro>
2023-03-09 19:38:15 -05:00
Róbert Örn Ketilsson ef3868ff50 Backport pull request #9178 from jellyfin/release-10.8.z
Escape the path to pass as a command line argument

Original-merge: 09f1c7f535

Merged-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>

Backported-by: crobibero <cody@robibe.ro>
2023-03-09 19:29:39 -05:00
Shadowghost 80b8661008 Merge branch 'master' into network-rewrite 2023-03-03 10:42:24 +01:00
Shadowghost 1f15724398 Use source audio bitrate if requested codec is lossless 2023-03-02 20:57:59 +01:00
Shadowghost 16f2cca882 Apply review suggestions 2023-02-28 15:12:43 +01:00
Cody Robibero 4873d2a54d
Fix auth endpoints using api key (#9408) 2023-02-27 05:48:37 -07:00
knackebrot aa99aaebc4 Add audio vbr calculation 2023-02-26 22:37:01 +01:00
knackebrot 3e74377036 Calculate output bitrate from output channel count 2023-02-26 22:37:01 +01:00
Bond_009 ab24c0e2cf Enable nullable for more files 2023-02-23 19:09:16 +01:00
Shadowghost c5a363a007 Merge branch 'master' into network-rewrite 2023-02-20 11:58:14 +01:00
Shadowghost 4ed97a4593 Properly check for item visibility in UserLibraryController 2023-02-20 11:53:20 +01:00
Shadowghost 2e315b7f08 Properly build where clause for rating checks 2023-02-20 11:53:20 +01:00
Shadowghost c8d80450e0 Recursively update rating 2023-02-20 11:53:20 +01:00
Bond_009 24a7e210c3 Optimize tryparse
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Cody Robibero a527034ebe
Validate requested user id (#8812) 2023-02-17 23:16:08 +01:00
Shadowghost 20fd05b050 Consistently write IP in upercase 2023-02-17 19:27:36 +01:00
Bond_009 60f41b80f6 Verify ContentType of uploaded images 2023-02-16 15:08:01 +01:00
Shadowghost 87b2bc5dc4
Fix LocalAccessOrRequiresElevationHandler (#9315) 2023-02-14 12:22:07 -07:00
Shadowghost b8ed1f81cd Add back LocalAccessOrRequiresElevationPolicy 2023-02-14 19:06:43 +01:00
Shadowghost eeb0f7af6c Add permissions for LiveTV access and management 2023-02-14 18:48:31 +01:00
Shadowghost b7418d6e9e Add permission for collection management 2023-02-13 15:42:04 +01:00
cvium a5e2ae4979 fix merge conflict 2023-02-12 23:01:30 +01:00
cvium 52e2776d8e Merge branch 'master' into simplify_authz
# Conflicts:
#	Jellyfin.Api/Auth/SyncPlayAccessPolicy/SyncPlayAccessHandler.cs
2023-02-12 22:59:48 +01:00
cvium ac118e10f0 remove unnecessary init 2023-02-09 15:01:04 +01:00
cvium f4a7583c46 fix empty user id check for api keys 2023-02-09 13:51:37 +01:00
cvium f984f31896 admins shouldn't be able to circumvent remote access policies 2023-02-09 13:51:37 +01:00
cvium 209edd38a4 refactor: simplify authz 2023-02-09 13:51:37 +01:00
Bond_009 eb7fee9590 Add more tests 2023-02-04 21:08:30 +01:00
Shadowghost f2b7f664aa Apply review suggestions 2023-02-04 20:16:45 +01:00
Bond_009 52230d1c30 Return NotFound when itemId isn't found 2023-02-04 20:11:08 +01:00
Shadowghost edf3909157 Use FFmpeg concat for DVD and BD folder playback 2023-02-04 18:39:45 +01:00
Shadowghost ddfdec7f46 Fix BD and DVD folder probing and playback 2023-02-04 18:37:57 +01:00