Commit graph

107 commits

Author SHA1 Message Date
Bond-009 8865b3ea3d Remove dead code and improve logging 2020-01-13 20:06:08 +01:00
Bond_009 5ca68f9623 Fix nullref exception and added logging 2020-01-13 20:06:08 +01:00
Bond_009 976459d3e8 Rewrite WebSocket handling code 2020-01-13 20:06:08 +01:00
Bond_009 2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
Bond_009 42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
Claus Vium 27e3cf1558 Move appbuilder and service collection to Jellyfin.Server 2019-11-24 15:27:58 +01:00
Bond-009 b14d6d0417 Fix GetPathValue function 2019-11-13 16:32:33 +01:00
Vasily 6b6fede2e0 Address review comments 2019-10-16 16:13:59 +03:00
Vasily 82f8345aa5 Log to debug all HTTP 500 response urls 2019-10-14 13:22:53 +03:00
Vasily 1176749f14
Merge pull request #1863 from joshuaboniface/fix-baseurl-issues
Fix inconsistent BaseUrl behavior
2019-10-09 19:24:41 +03:00
Joshua Boniface b96079fee6 Make NormalizeUrlPath static 2019-10-09 09:22:55 -04:00
Vasily 03450f383f Fix template for logging 2019-10-09 14:05:32 +03:00
Vasily 8109c7eb30 Always log at least error message when error happens during request processing 2019-10-09 14:00:22 +03:00
Vasily 33b69a7099 Set response length and mime type correctly when reporting an error 2019-10-09 13:54:05 +03:00
Joshua Boniface 2a79ae0a6e Normalize baseUrl behaviour
Fully normalizes the baseUrl behaviour to better match how this sort of
feature works in other programs.

1. The baseUrl is always appended to paths, even the built-in `/emby`
and `/mediabrowser` paths.
2. The baseUrl is set statically at class instance creation, to ensure
it persists through changes until the next restart.
3. Configuration is normalized using a function when set, to ensure it's
in a standard `/mypath` format with leading `/`.
4. Cleans up the conditionals around default redirects. For sanity after
changing the URL, it will match *any* path that doesn't match the
current baseUrl and redirect it back to the main page (with baseUrl).
5. Adds a second method, NormalizeUrlPath, to avoid lots of `+ "/" +`
string manipulations which are unclean - we should always have a leading
slash.
6. Sets the default baseUrl to an empty string to avoid unexpected
behaviour, though this would be worked-around automatically.
7. Adds some debug logs whenever a URL is normalized, to help track down
issues with this code (if any arise).
2019-10-08 18:06:03 -04:00
dkanada b5b7db1f32 add an exception to logging 2019-09-24 23:59:24 +09:00
dkanada ab7e697f30 add mediabrowser route back for now 2019-09-24 23:59:24 +09:00
dkanada 97d6c2db6b keep old base url for now 2019-08-11 00:35:18 -07:00
dkanada d521e5c36a add base url to server configuration 2019-08-11 00:35:18 -07:00
dkanada c987203f5a remove old routes from http server 2019-08-11 00:33:13 -07:00
Bond_009 9fff4b060e Replace custom code with Asp.Net Core code 2019-08-09 22:36:20 +02:00
Bond-009 ce1fa42f9d
Merge branch 'master' into tasks 2019-06-01 17:06:01 +02:00
Bond-009 61d7bed181
Merge pull request #1304 from jellyfin/release-10.3.z
Backmerge 10.3.1
2019-04-25 07:27:37 +02:00
Claus Vium 28c2ac528d Re-add content length, semi revert of changes in #1010 (#1287)
* Re-add content length, semi revert of changes in #1010
2019-04-24 14:06:54 +02:00
Bond-009 a8da122fb3
Merge pull request #1252 from jellyfin/release-10.3.z
Backmerge release 10.3.0
2019-04-20 12:25:29 +02:00
Joshua Boniface 250e0c75df Add MethodNotAllowedException with code 405 2019-04-17 22:31:06 -04:00
Bond-009 a332092769 Reduce complexity http routes 2019-03-26 19:20:40 +01:00
Bond_009 2696ac5eac Lower the amount of running tasks 2019-03-25 21:33:48 +01:00
Claus Vium e3b844b5aa Add urlprefixes during init 2019-03-07 22:49:41 +01:00
Claus Vium 3fa43a1e08 Don't set status code if response is closed 2019-03-07 22:26:23 +01:00
Claus Vium 913e80fd55 Add ProcessWebSocketRequest to IHttpListener 2019-03-05 20:35:07 +01:00
Claus Vium 51648a2a21 Remove unused _listener 2019-03-05 08:05:42 +01:00
Claus Vium 0250204f14 Expand todo 2019-03-04 22:26:57 +01:00
Claus Vium 9020f68ce1 Use QueryHelpers.AddQueryString 2019-03-04 20:08:54 +01:00
Claus Vium e823c11b46 Add certificate to https and minor cleanup 2019-03-03 08:29:23 +01:00
Claus Vium c0b95dbc79 Fix query log for real 2019-02-27 20:11:40 +01:00
Claus Vium 647adc51c8 Fix query log 2019-02-27 19:55:25 +01:00
Claus Vium 27e7e792b3 Replace some usage of QueryParamCollection 2019-02-27 14:23:39 +01:00
Claus Vium 333bd2107a Remove HttpUtility 2019-02-27 12:40:18 +01:00
Claus Vium 848cfc32cc More cleanup 2019-02-26 22:57:59 +01:00
Claus Vium f1c93ae618 Remove SetContentLength and company 2019-02-26 22:11:21 +01:00
Claus Vium 4e8de67aca Remove SocketSharp from Jellyfin.Server and some other cleanup 2019-02-26 22:11:21 +01:00
Claus Vium a85488cd20 Fix websockets array index out of bounds and some cleanup 2019-02-26 22:11:21 +01:00
Claus Vium f3e7bc0573 Replace some todos with http extensions and prepare some socket work 2019-02-26 22:11:21 +01:00
Claus Vium 852460b991 kestrel init 2019-02-26 22:11:21 +01:00
Claus Vium 4db31acff9 Begin removing System.Net sources 2019-02-26 22:11:21 +01:00
Bond-009 0804bed66d Log time in a standardized way 2019-02-26 19:40:23 +01:00
Bond_009 0f9006c81f Use stopwatch for more accurate measurements and reduce log spam
DateTime.Now is suitible for small timespans
Replaced the needlessly complex and verbose logging for the httpserver
2019-02-25 18:26:17 +01:00
William Taylor 18ae107ce4 Removed unnecessary configuration options and reduced primitive dependencies 2019-02-17 14:09:52 +00:00
William Taylor 65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00