Bond_009
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
2020-05-29 11:28:19 +02:00
Patrick Barron
7586c60224
Merge branch 'master' into warnings-cleanup1
2020-04-22 13:44:20 +00:00
Patrick Barron
f26f44acaf
Apply code review suggestions
2020-04-19 13:39:12 -04:00
Patrick Barron
c4e6329e58
Clean up and document ChannelManager.cs and implement suggestions
2020-04-15 15:00:45 -04:00
Patrick Barron
f29e6badb3
Remove unused field and documented RefreshChannelsScheduledTask.cs
2020-04-14 15:48:06 -04:00
Patrick Barron
c8e26b6d46
Document ChannelPostScanTask.cs
2020-04-14 15:36:29 -04:00
Patrick Barron
2c920cff33
Document ChannelImageProvider.cs
2020-04-14 15:29:57 -04:00
Patrick Barron
543c76a8f1
Clean up and document ChannelDynamicMediaSourceProvider.cs
2020-04-14 15:28:02 -04:00
Bond_009
49fe5e0a21
Fix some warnings
2020-04-11 12:03:10 +02:00
ferferga
a9759f6a80
Rename translation keys
2020-03-29 23:46:19 +02:00
ferferga
07f4893ba6
Translated RefreshChannelScheduledTask as well
2020-03-26 22:36:11 +01:00
Bond-009
94fe9b8f6d
Merge branch 'master' into warn17
2020-03-11 20:26:43 +01:00
Mark Monteiro
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Bond_009
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009
87d2479b78
Fix warnings
2020-01-31 22:26:53 +01:00
Bond_009
2ef4ffd698
More warnings (removed)
2019-12-11 00:13:57 +01:00
dkanada
67922dff50
Merge pull request #2041 from Bond-009/warn11
...
Fix more warnings
2019-12-11 01:14:55 +09:00
Bond-009
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
2019-12-06 12:06:13 +01:00
Bond_009
42ffddc269
Fix more warnings
2019-11-27 16:29:56 +01:00
Bond-009
b477b3874e
Fix some warnings
2019-11-22 16:15:31 +01:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Bond_009
bbc0875387
Don't shuffle some types by default
2019-10-20 16:08:40 +02:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Bond-009
6566c91360
Seperate changes from #1023
...
The unrelated changes from #1023 (and more)
2019-03-25 21:27:03 +01:00
Bond-009
9993dafe54
Don't mix LINQ and roreach loops for readability
2019-03-01 17:12:22 +01:00
Joshua M. Boniface
aea7edf0fa
Merge pull request #891 from Bond-009/postsan
...
Reduce the amount of db calls during the post scan event
2019-02-27 00:31:48 -05:00
Claus Vium
21f0a7e020
Make all class implementing dynamically loaded interfaces public
2019-02-15 23:05:14 +01:00
Bond-009
0fbc4545d1
Address comments
2019-02-14 17:02:46 +01:00
Bond-009
bca569da42
Reduce the amount of db calls during the post scan event
2019-02-13 22:10:37 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Bond_009
722120af74
Remove conditions that are always true/false
2019-01-22 23:49:51 +01:00
William Taylor
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Erwin de Haan
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
e867446437
ReSharper format: conform inline 'out' parameters.
2019-01-13 21:46:33 +01:00
Erwin de Haan
e566d9a231
Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv
2019-01-13 20:54:44 +01:00
Erwin de Haan
a5288115a8
Visual Studio Reformat: Emby.Server.Implementations Part A-Da
2019-01-13 20:20:16 +01:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00
Bond_009
3a65fb1da2
Remove obsolete GetMBId
2019-01-02 17:58:44 +03:00
Bond_009
ea4c914123
Fix exception logging
2018-12-30 22:44:39 +01:00
Bond_009
b7ebb67cbb
Remove the need for NullLogger
2018-12-30 22:44:38 +01:00
Bond_009
0f8b3c6347
Use Microsoft.Extensions.Logging abstraction
2018-12-30 22:44:38 +01:00
Bond_009
9ff45cf969
Some voodoo magic to stop a crash
2018-12-30 18:30:29 +01:00
Bond_009
6e5d2aadaa
Remove custom ToArray extension
2018-12-28 16:48:26 +01:00
Andrew Rabert
a86b71899e
Add GPL modules
2018-12-27 18:27:57 -05:00
stefan
48facb797e
Update to 3.5.2 and .net core 2.1
2018-09-12 19:26:21 +02:00
Luke Pulverenti
5cb7469028
support track selection before playback
2017-11-05 16:51:23 -05:00
Luke Pulverenti
7cd1416d27
fix music artists not showing in collections
2017-10-28 00:19:38 -04:00
