Commit graph

1497 commits

Author SHA1 Message Date
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Andrew Mahone 03ecf57548 Store MediaAttachments in DB. 2019-10-22 10:32:40 -04:00
Bond_009 c5995af493 Some style fixes 2019-09-25 17:19:48 +02:00
Bond-009 ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Anthony Lavado cb393c215a
Merge pull request #1686 from Bond-009/warn7
More warning fixes
2019-09-02 02:07:19 -04:00
Anthony Lavado c4eac8b3c6
Merge pull request #1702 from Bond-009/warn8
Fix more warnings
2019-09-02 02:05:20 -04:00
Andrew Rabert 907b3185c2 Use regex to replace multiple spaces with one space
This communicates the intent of the code more clearly than before.
No noticeable performance impact.
2019-09-01 21:44:34 -04:00
Andrew Rabert 6478cd2ea4 Fix infinite looping when scanning TV metadata
It's a possible that name and sb will never be equal. This is caused by
additional replacements before this loop.
Regression introduced in c699c546e4124da8c1978b86d1a424d24d3d77d6a
2019-09-01 21:40:47 -04:00
Bond_009 1616f24cee Fix more warnings 2019-09-01 18:39:23 +02:00
Bond_009 e4f893a0eb More warning fixes 2019-08-29 22:28:33 +02:00
dkanada 21ff63c371 move the transcode path 2019-08-29 00:14:50 -07:00
Claus Vium 058e077422 Add newline after end tag 2019-08-19 12:13:34 +02:00
Claus Vium d2b8672c1c Require latest C# version in Providers project 2019-08-19 12:12:00 +02:00
Claus Vium 82b0015b30 Fix style issues 2019-08-18 14:50:26 +02:00
Claus Vium 78441730a7 Add Writer and Producer to crew list 2019-08-18 14:50:26 +02:00
Claus Vium 5ea1299030 Fix api url 2019-08-18 14:50:26 +02:00
Claus Vium 817d9b3389 Move and rename tmdb providers for better separation 2019-08-18 14:50:26 +02:00
Anthony Lavado 28d707604b
Merge pull request #1629 from cvium/fix_tvdb_guest_stars
Fix tvdb guest stars with multiple roles
2019-08-17 02:22:07 -04:00
Anthony Lavado f1f4b1a184
Merge pull request #1628 from cvium/fix_tvdb_ep_provider_id
Always fetch episode id as EpisodeInfo does not contain it
2019-08-17 02:10:36 -04:00
Claus Vium 9e3f4ac954 Move the first argument to its own line 2019-08-16 21:10:42 +02:00
Claus Vium e4158d9703 Continue 2019-08-16 20:11:01 +02:00
Claus Vium 8d230e67a2 Place args on separate lines 2019-08-16 20:09:30 +02:00
Claus Vium daf29233e6 Invert the second if 2019-08-16 20:07:00 +02:00
Claus Vium 15f7a2078b Invert the if 2019-08-16 19:58:44 +02:00
Claus Vium 26b4fb21fe
Update MediaBrowser.Providers/TV/TheTVDB/TvdbEpisodeProvider.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-08-16 19:53:28 +02:00
Bond_009 c699c546e4 Improve LocalizationManager 2019-08-16 17:31:47 +02:00
dkanada bb04545068
Merge pull request #1614 from Bond-009/docs2
Document all public/internal members of Emby.Drawing
2019-08-15 21:01:44 -07:00
Claus Vium 11504321b5 Handle negative roleStartIndex since not all guest stars have roles 2019-08-15 19:54:01 +02:00
Claus Vium f7f3627bb1 Remove unused import 2019-08-15 14:56:49 +02:00
Claus Vium f4a99beb16 Fix tvdb guest stars loop 2019-08-15 14:54:22 +02:00
Claus Vium 38b0967044 Log episode id and series id when either request fails 2019-08-15 13:43:12 +02:00
Claus Vium 14575f0a06 Always fetch episode id as EpisodeInfo does not contain it 2019-08-15 13:39:56 +02:00
Bond_009 838e5d05d5 Document all public/internal members of Emby.Drawing
Forces all new public/internal members to be documented.
Enables TreatWarningsAsErrors for Emby.Drawing
2019-08-11 16:52:37 +02:00
Bond_009 5eaf5465a5 Check checksum for plugin downloads
* Compare the MD5 checksum when downloading plugins
* Reduced log spam due to http requests
* Removed 'GetTempFileResponse' function from HttpClientManager
* Fixed caching for HttpClientManager
2019-08-11 15:54:58 +02:00
dkanada 1ad67e223f
Merge pull request #1462 from Bond-009/installationmanager
Improvements to InstallationManager
2019-08-11 03:47:10 -07:00
dkanada 4f592e9c33
Merge pull request #1484 from SenorSmartyPants/DVD-Order
Update TVDB provider to search based on series display order
2019-08-09 23:26:42 -07:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
dkanada cf0460c7f9 move comment to separate line 2019-08-07 02:24:56 -07:00
Anthony Lavado cc4bf60092
Merge pull request #1590 from anthonylavado/null_check
Adds null check on studio/network name
2019-08-02 14:12:17 -04:00
Anthony Lavado d05440d267
Update MediaBrowser.Providers/TV/TheTVDB/TvdbSeriesProvider.cs
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
2019-07-31 12:21:46 -04:00
Anthony Lavado d39decf918 Adds null check on studio/network name 2019-07-27 02:30:42 -04:00
Bond-009 82f041d050
Merge branch 'master' into release-10.3.z 2019-07-06 23:08:52 +02:00
SenorSmartyPants 18e6cd429a Update TVDB provider to search based on series display order 2019-06-22 16:11:47 -05:00
Claus Vium c2ab0ad641 Wait for the async authentication to finish when the JTW token expires 2019-06-21 19:08:04 +02:00
Bond_009 5554595255 Update deps 2019-06-14 18:49:57 +02:00
Bond_009 65a0ca2f32 Improvements to InstallationManager 2019-06-14 18:38:14 +02:00
Joshua M. Boniface 687255aa31
Merge pull request #1442 from jellyfin/release-10.3.z
Backmerge for Release 10.3.4 and 10.3.5
2019-06-12 23:30:57 -04:00
dkanada 09dfa071dc move fanart image provider to plugin 2019-05-31 01:48:20 -07:00
Claus Vium a756026962
Fix inverted comparison in the tvdb token refresh logic 2019-05-31 07:24:52 +02:00
Bond-009 682432f55a Iterate over IEnumerable before disposing 2019-04-30 22:18:40 +02:00
Claus Vium 08ed52eb72 Make the TvdbEpisodeProvider class Public 2019-04-30 20:08:59 +02:00
Joshua M. Boniface 59031ee3b8
Merge pull request #1119 from ploughpuff/503retry
MusicBrainz 503 Retry Strategy
2019-03-15 16:47:03 -04:00
PloughPuff d2e408539e MusicBrainz 503 Retry Strategy
Upon receiving back a 503 Service Unavailable from MusicBrainz (indicating throttling), retry the same request a number of times before giving up.
2019-03-15 19:33:26 +00:00
Vasily 11fde02035
Merge pull request #1105 from ploughpuff/ratelimit
Only delay making MusicBrainz request if necessary
2019-03-15 16:01:55 +03:00
PloughPuff d125fbc43d Added contact email to user agent
MusicBrainz request a contact email address is supplied in comment section of user agent field.
2019-03-14 21:34:09 +00:00
Erwin de Haan 21cc38fcf4 Adjusted AssemblyCopyright attribute values. 2019-03-14 22:17:56 +01:00
Erwin de Haan ee7bf86e0f Adjusted the Product Name so the User Agent is correct/better. 2019-03-14 22:11:47 +01:00
PloughPuff f8bb7a7ff4 Increased interval to 1050ms and moved to class scope
Review comments from JustAMan.
2019-03-14 19:01:17 +00:00
PloughPuff 6d3e6d800f Only delay making request if necessary
When requesting data from MusicBrainz, only delay the request if previous request was less than rate limit ago, instead of always delaying for one second at start.
2019-03-14 19:01:17 +00:00
Bond-009 bf43dc00bb More warning fixes 2019-03-13 22:32:52 +01:00
Bond-009 afdef163ea
Fix build by removing non existent namespace
Looks like a wrong auto merge. (We really should fix CI)
2019-03-12 20:49:29 +01:00
Bond-009 3ddbda9aca
Merge branch 'master' into xml 2019-03-12 16:37:18 +01:00
Bond-009 58061a7295 Make MusicBrainz base url configurable 2019-03-08 17:15:52 +01:00
Bond_009 37ea50a572 Reduce the amount of exceptions thrown 2019-03-07 21:42:56 +01:00
Bond_009 ffd6dac03a Remove useless comments 2019-03-07 12:24:44 +01:00
Bond_009 a9302b8b53 Remove useless abstraction around XmlReaderSettings
This removes the amount of stuff that needs to be passed around
Also removes some unneeded `ManagedFileSystem` usage
2019-03-07 12:04:14 +01:00
Bond-009 594b271383
Merge pull request #1024 from jellyfin/release-10.2.z
Backmerge for 10.2.2
2019-03-01 07:49:07 +01:00
Claus Vium 2e9a3d45c2 Fix slow local image validation (#990)
* Check for local image directory existence to avoid tons of exceptions
2019-02-24 10:16:53 -05:00
Claus Vium c597f0de35 Make Tvdb strings const 2019-02-20 19:55:06 +01:00
Bond-009 3965f90236
Update MediaBrowser.Providers/TV/TheTVDB/TvdbSeriesImageProvider.cs
Co-Authored-By: cvium <cvium@users.noreply.github.com>
2019-02-20 19:36:33 +01:00
Claus Vium 8af4417f8f Add ConfigureAwait to awaited calls 2019-02-20 19:35:47 +01:00
Claus Vium 4a5c526ccc Fix logging args and add ilogger with categoryname 2019-02-20 19:08:47 +01:00
Vasily bca7a26ffd
Merge branch 'master' into update_tvdb 2019-02-20 14:46:07 +03:00
Claus Vium 1f30a50f4a Address review comments 2019-02-20 11:03:04 +01:00
Claus Vium dab25a0eeb Remove OptimizedPriorityQueue source and grab it from nuget 2019-02-19 21:17:30 +01:00
Claus Vium 21f0a7e020 Make all class implementing dynamically loaded interfaces public 2019-02-15 23:05:14 +01:00
Claus Vium ce51025e7c Use DI for TvDbClientManager 2019-02-15 20:11:27 +01:00
Claus Vium 5a054e5150 Remove useless doc 2019-02-15 19:33:10 +01:00
Claus Vium 98f003f71a Review comments 2019-02-15 19:33:10 +01:00
Claus Vium b9efcace79 Extract imagetype-to-keytype statements into a utility function and move tvdb specific utils to separate class 2019-02-15 19:33:10 +01:00
Claus Vium 1aaa8de1f9 Use Task.WhenAll properly 2019-02-15 19:33:10 +01:00
Claus Vium 5e2e190f3e Add key delimiter to avoid potential clashes 2019-02-15 19:33:10 +01:00
Claus Vium 828434058f Use language supplied as argument instead of reading from TvDbClient 2019-02-15 19:33:10 +01:00
Claus Vium dfbf5fc9fa Add generic key generation function 2019-02-15 19:33:10 +01:00
Claus Vium 8029cd3ebb Add better language support 2019-02-15 19:33:10 +01:00
Vasily e970d7a6aa Update MediaBrowser.Providers/TV/MissingEpisodeProvider.cs
Co-Authored-By: cvium <cvium@users.noreply.github.com>
2019-02-15 19:33:10 +01:00
Claus Vium 350e795640 Fix namespace in tvdbclientmanager 2019-02-15 19:33:10 +01:00
Claus Vium f5bda652c4 Add support for searching for episodes by premiere date and fixed timezones 2019-02-15 19:33:10 +01:00
Claus Vium e8189cd0f6 Fix namespaces 2019-02-15 19:33:10 +01:00
Claus Vium 18231fedef Add braces to if's and other minor style changes 2019-02-15 19:33:10 +01:00
Claus Vium 935c7231eb Review comments 2019-02-15 19:33:10 +01:00
Vasily da2c7db0df Apply suggestions from code review
Co-Authored-By: cvium <cvium@users.noreply.github.com>
2019-02-15 19:33:10 +01:00
Claus Vium 83d98ac92d Fix episode provider 2019-02-15 19:33:10 +01:00
Claus Vium b997b12d27 Add names to tuple items and reduce list iterations 2019-02-15 19:33:10 +01:00
Claus Vium 6887e790c8 Minor fixes in MissingEpisodeProvider 2019-02-15 19:33:10 +01:00
Claus Vium 373a1f72bf Fix actor image provider 2019-02-15 19:33:10 +01:00
Claus Vium 0d43b06042 Fix MissingEpisodeProvider (almost) 2019-02-15 19:33:10 +01:00
Claus Vium ced9868357 Fix a copy paste mistake and add series end date 2019-02-15 19:33:10 +01:00
Claus Vium 23c867f946 Remove TvdbPrescanTask as it looks like it was used for pre-fetching data, which is no longer relevant 2019-02-15 19:33:10 +01:00
Claus Vium 42c233c74e Add much needed exception handling and logging 2019-02-15 19:33:10 +01:00