Commit graph

62 commits

Author SHA1 Message Date
Bond-009 7d28d08e08
Enable more warnings as errors (#11288) 2024-04-12 17:45:01 -06:00
Cody Robibero 033cfa59c4 Convert CollectionType to use lowercase enum names 2023-12-08 15:45:36 -07:00
Cody Robibero 906f701fa8
Convert CollectionType, SpecialFolderType to enum (#9764)
* Convert CollectionType, SpecialFolderType to enum

* Hide internal enum CollectionType values

* Apply suggestions from code review

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>

* Fix recent change

* Update Jellyfin.Data/Attributes/OpenApiIgnoreEnumAttribute.cs

Co-authored-by: Patrick Barron <barronpm@gmail.com>

---------

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
Co-authored-by: Patrick Barron <barronpm@gmail.com>
2023-11-09 14:00:29 -07:00
Bond_009 b5f0760db8 Use RegexGenerator where possible 2023-06-28 17:07:57 +02:00
Joe Rogers 1c3a97bf6a
Inject IDirectoryService where needed instead of passing it through ItemResolveArgs 2023-03-06 23:00:55 -05:00
Bond_009 48263078b4 Reduce string allocations by regex 2023-02-17 15:00:06 +01:00
Bond-009 497d8c4957
Use Order() introduced in .NET 7 (#8923) 2022-12-19 09:30:00 -07:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Shadowghost 2e639c77c7 Apply review suggestions 2022-11-17 18:54:35 +01:00
Shadowghost 072651c4be Add xmldocs for TMDb provider, correct provider spelling 2022-11-17 11:16:20 +01:00
Bond_009 f6af28cf96 Fix some things that slipped through the cracks 2022-10-11 23:37:29 +02:00
luz paz 9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Utku Ozdemir 9ec42f8cf5 fix: single video folder during photos lib scan
Prevent a directory with a single video file to be detected as a movie directory when the library type is "Photos". Closes jellyfin/jellyfin#7825

Signed-off-by: Utku Ozdemir <uoz@protonmail.com>
2022-06-30 13:36:46 +02:00
Cody Robibero b35d608b19 Merge pull request #7892 from cvium/fix_tv_multi
(cherry picked from commit 21afec3225)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-14 19:30:59 -04:00
Stanislav Ionascu 554d1b2ca8 Fix #7100 by catching the exception on opening invalid UDF images
When an invalid UDF image is opened by the UdfReader, it may throw
and exception. This change is to catch and log the exception.
2022-02-20 13:30:55 +00:00
SenorSmartyPants 2b769aae69
TV extras (#7178) 2022-02-04 20:44:38 +01:00
Joe Rogers e762454787
Restore resolver that handles alternate videos
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-01-16 22:59:14 +01:00
Joe Rogers c0ab54f0bd Fix resolved type for Trailers 2021-12-24 21:21:19 +00:00
cvium 83a94aa612 Fix extras folders 2021-12-20 12:15:20 +01:00
Claus Vium 9a0618552b
Merge branch 'master' into what_could_go_wrong 2021-12-15 08:38:39 +01:00
cvium 6030946d78 Fixes 2021-12-07 19:23:30 +01:00
cvium fde84a1e00 Refactor extras parsing 2021-12-07 15:24:57 +01:00
Claus Vium 065d3fa837 performance++ 2021-11-27 16:10:43 -07:00
cvium 4f45c52674 Remove ILibraryManager as a dependency in resolvers etc. 2021-11-15 15:56:02 +01:00
Bond_009 03f933aaa0 Fix the last few warnings
Enables TreatWarningsAsErrors for all projects
2021-10-06 11:30:45 +02:00
Patrick Barron 876a902356 Fix warnings in Library 2021-10-03 21:41:22 -04:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Bond_009 6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
cvium 42a2cc1747 Remove some unnecessary allocations 2021-05-24 00:30:41 +02:00
Bond_009 7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
Bond_009 bcb4010db6 More improvements 2021-05-05 15:30:32 +02:00
cvium ab0cff8556 do not resolve episode-like files if they are in extras folders 2021-03-14 19:56:45 +01:00
Ian 0f4bbbc63c Fix 3169 and 2879 by making MusicArtistResolver run ahead of MusicAlbumResolver 2021-01-06 10:58:07 -08:00
aled 22a860a806 Fix a small number of compile warnings 2020-06-06 20:17:49 +01:00
Bond_009 adc9fc282c Minor improvements 2020-02-19 23:08:58 +01:00
Bond_009 dc62e436c4 Clean up Emby.Naming 2020-01-22 22:18:56 +01:00
Bond_009 42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
Bond_009 ab7ef9c9cb Fix style issues 2019-07-06 16:15:38 +02:00
bugfixin 0794a3edf4 Adjust detection of 'sample' in filenames to use regex boundaries 2019-04-19 17:53:51 +00:00
Bond_009 a6a4cd5667 Removed some unused fields 2019-02-09 15:57:42 +01:00
Bond_009 722120af74 Remove conditions that are always true/false 2019-01-22 23:49:51 +01:00
Erwin de Haan 58b582bdcb Visual Studio Reformat: Emby.Server.Implementations Part I-Lib 2019-01-13 20:21:32 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009 0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti d06532c602 update rules for samples 2017-11-27 14:09:51 -05:00
Luke Pulverenti b5ab7776f1 3.2.36.11 2017-11-16 16:25:18 -05:00
Luke Pulverenti 47e6530d84 fix file extension being displayed 2017-11-01 15:50:30 -04:00
Luke Pulverenti e7ecd418c4 update home video library support 2017-10-21 12:39:52 -04:00