Commit graph

83 commits

Author SHA1 Message Date
Bond-009 92f6e19a25
Enable nullable for more files (#9310) 2023-02-14 12:09:07 -07:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond_009 5036afd691 Minor cleanup 2022-08-18 13:56:23 +02:00
Cody Robibero 7424f0ca8c Merge pull request #7561 from DMouse10462/named-config-api-fix
Fix NamedConfiguration API Generation

(cherry picked from commit d7c548f3db)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:11 -04:00
Bond_009 ea8f40e84a More cleanup 2021-12-27 14:20:05 +00:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
cvium 76c2775d8c Use static lambdas 2021-12-19 10:27:57 +01:00
Bond_009 9af16fcb6c Remove workaround for dotnet/runtime#42790 2021-10-03 19:52:38 +02:00
Bond-009 cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram 2021-06-12 00:20:54 +02:00
Bond_009 0bc0601442 Fix some warnings 2021-05-28 14:33:54 +02:00
cvium 42a2cc1747 Remove some unnecessary allocations 2021-05-24 00:30:41 +02:00
Bond_009 7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
BaronGreenback bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
David 60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
crobibero dae4541bad Merge remote-tracking branch 'upstream/master' into dotnet-5 2020-11-15 11:56:35 -07:00
Bond-009 331c7f8481
Merge pull request #4253 from BaronGreenback/fordiscussion
DI in plugins
2020-11-15 13:29:04 +01:00
crobibero 73d2cb1c2a Updated based on review feedback 2020-11-13 18:04:06 -07:00
Cody Robibero 24ac5cc353
Update Emby.Server.Implementations/AppBase/ConfigurationHelper.cs
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-13 13:18:31 -07:00
crobibero 95ebb9a55a Use null coalescing when possible 2020-11-13 11:24:46 -07:00
crobibero 5f52a58e78 Convert NullReferenceException to ResourceNotFoundException 2020-11-13 11:14:44 -07:00
crobibero 7bf320922c Fix nullability errors in Emby.Server.Implementations 2020-11-13 09:41:18 -07:00
BaronGreenback caea2bb862
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-11-11 17:00:19 +00:00
BaronGreenback 69790ef6b8
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-09 11:24:53 +00:00
Bond_009 51dd3f1e19 Minor improvements 2020-10-17 16:01:36 +02:00
BaronGreenback a8cee0bd36
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-10-14 19:04:17 +01:00
BaronGreenback 002190f0a3
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-10-14 19:04:09 +01:00
BaronGreenback 0e872ca65c
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-10-14 19:03:54 +01:00
BaronGreenback 387fdb0f13
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-10-11 23:50:36 +01:00
BaronGreenback ed05ae683e
Update Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-10-11 23:49:51 +01:00
Greenback 0b73a1d90f Added extra functionality to support registrar. 2020-10-11 13:19:14 +01:00
Bond_009 e653eef44f Fix some warnings 2020-08-31 22:20:19 +02:00
Bond_009 371a09c60b MemoryStream optimizations 2020-08-09 14:08:55 +02:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron 9cec01d8ce Switch to using declaration 2020-04-14 15:11:21 -04:00
Patrick Barron 0e8f30f64b Documented BaseApplicationPath constructor parameters 2020-04-14 15:08:20 -04:00
Mark Monteiro 05ab61200a Do not call UseContentRoot() on the web host builder
This call has nothing to do with static web content and should not have ever been called with the web content path: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/?view=aspnetcore-3.1&tabs=windows#content-root
Since this call is removed, the ContentRoot property is also removed from ApplicationHost as it is no longer needed.
Finally, move validation of the static content path to the DashboardService where it is actually used.
2020-03-15 17:42:57 +01:00
Mark Monteiro 547f248a62 Update XML documentation for WebPath 2020-03-15 12:59:34 +01:00
Mark Monteiro 26af5ea45a Do not set a static content root if the jellyfin-web directory does not exist or is empty 2020-02-25 16:51:36 +01:00
dkanada 67922dff50
Merge pull request #2041 from Bond-009/warn11
Fix more warnings
2019-12-11 01:14:55 +09:00
Bond-009 affb58ef9e
Apply suggestions from code review
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2019-12-10 16:22:03 +01:00
Bond_009 4a0df15bbd Fix GetTranscodePath function and cache path update logline
* GetTranscodePath returned an empty string after the option was left
blank in the web UI
* Unified the log style for all paths
2019-12-04 22:18:37 +01:00
Bond_009 42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
Joshua M. Boniface 48120d01dc
Merge pull request #1991 from Bond-009/transtemp
Don't append transcodes to transcoding temp path
2019-11-24 15:13:50 -05:00
Bond-009 b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
Bond-009 d4b438791f Don't append transcodes to transcoding temp path 2019-11-21 16:57:49 +01:00
Bond_009 3f7836d9eb Update deps and add MultiThreading analyzer 2019-11-01 17:55:44 +01:00
Bond_009 9d4ce82ab9 Enable TreatWarningsAsErrors for MediaBrowser.Common and Emby.Photos
Adds `#pragma warning disable CS1591` to all files in
MediaBrowser.Common containing undocumented members.
2019-10-09 17:14:15 +02:00
Bond_009 25917db07a Fix doc releated warnings 2019-08-09 23:50:40 +02:00