Commit graph

79 commits

Author SHA1 Message Date
Patrick Barron aa3c33060d Fix warnings in Playlists 2021-10-03 21:41:22 -04:00
Bond_009 79642af3b8 Fix some warnings 2021-09-25 20:32:53 +02:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Cody Robibero 398ca85944 Merge remote-tracking branch 'upstream/master' into baseitemkind-fixes 2021-08-04 06:24:58 -06:00
Cody Robibero 65f8d8c0cd [CA1801] Parameter is never used. Remove the parameter or use it in the method body. 2021-07-10 10:09:02 -06:00
crobibero 23dd6e2d9f Merge remote-tracking branch 'upstream/master' into baseitemkind-fixes 2021-06-20 07:09:24 -06:00
Bond_009 7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
BaronGreenback bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
Luca Benini c4d142eda1 Fix BaseItemKind conversion for PlaylistsFolder
Return the correct ClientTypeName to allow Enum Parse
Added dynamic unit tests to ensure all BaseItem concrete descend
2021-02-14 12:40:08 +01:00
crobibero 3cc0dd7e12 Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage. 2020-11-16 20:29:46 -07:00
Bond_009 2b832de289 Fix build 2020-08-21 22:19:16 +02:00
Bond_009 119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
Bond_009 01e781035f Fix warnings 2020-07-24 16:37:54 +02:00
telans 98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
crobibero 24f54837e1 Switch to M3uContent 2020-06-15 08:34:24 -06:00
Patrick Barron 42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron 06f9cde22f Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
dkanada c9c6fe02ab move most of the image providers to a single directory 2020-06-04 21:32:20 +09:00
dkanada aa66444264 add image provider for artists 2020-06-04 21:30:23 +09:00
Vasily 40502a33e0
Merge pull request #3203 from Bond-009/warn18
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
2020-06-03 12:27:59 +03:00
Bond_009 4748105dce Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode 2020-05-29 11:28:19 +02:00
Patrick Barron c464f700db Remove redundant qualifiers 2020-05-20 13:07:53 -04:00
Patrick Barron 9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Mark Monteiro 9a7875b6f9 Do not check for duplicates if they are allowed in playlist configuration 2020-03-13 23:14:25 +01:00
Mark Monteiro d276e0f8f4 Use Distinct() to filter out duplicates when adding items to playlist 2020-03-11 23:26:55 +01:00
Mark Monteiro 487aa376b4 Merge remote-tracking branch 'upstream/master' into 1914-prevent-duplicates-in-playlists 2020-03-11 23:21:30 +01:00
Mark Monteiro b67e9cde8c Replace ILogger with ILogger<T> wherever possible
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Mark Monteiro 3cb98fba55 Use ToList() instead of ToArray() on sequences of unknown size 2020-03-03 18:18:00 +01:00
Mark Monteiro 6438771212 Exit method early if there are no unique playlist items to add 2020-03-03 17:48:11 +01:00
Mark Monteiro 4d32b59a0b Performance improvements
Use arrays instead of lists; use Array.CopyTo to concat playlist items; only count number of duplicates once
2020-03-03 17:47:16 +01:00
Mark Monteiro 77533fd433 Revert unnecessary style change 2020-03-03 14:40:07 +01:00
Mark Monteiro dde0277050 Check for duplicates when adding items to a playlist 2020-03-02 21:12:35 +01:00
Bond_009 87d2479b78 Fix warnings 2020-01-31 22:26:53 +01:00
dkanada 1b2453b4e9 fix playlist deletion 2019-12-14 12:51:27 +09:00
Bond-009 a2c35e6dba Merge remote-tracking branch 'upstream/master' into random 2019-12-06 12:06:13 +01:00
Bond-009 b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Bond_009 bbc0875387 Don't shuffle some types by default 2019-10-20 16:08:40 +02:00
Bond_009 5edb8159a7 Fix Json serialization error 2019-10-15 17:49:49 +02:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond-009 c5fce647de Cleanup/simplification
* Removed useless copies/allocations
* Reduced unneeded complexity
2019-03-07 21:13:13 +01:00
Bond_009 1385d89df6 Remove MoreLINQ 2019-02-02 12:27:06 +01:00
Erwin de Haan b9a111432a Unwrapped all /(Write|Read)All(Text|Bytes)/ functions. 2019-01-28 22:10:50 +01:00
Erwin de Haan 581a7fe078 Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile 2019-01-28 22:10:00 +01:00
Erwin de Haan d7c6d16250 Unwrapped CreateDirectory and DeleteDirectory 2019-01-28 22:09:56 +01:00
Erwin de Haan 3a831994f6 Unwrapped GetDirectoryName and DirectorySeperatorChar 2019-01-28 22:06:34 +01:00
William Taylor 65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00