Mark Monteiro
1a4d9d4c53
Code review suggestions
2020-04-01 19:41:52 +02:00
Mark Monteiro
cc8294842a
Add ExtraType.Unknown enum value and use it instead of null
2020-04-01 18:10:29 +02:00
Mark Monteiro
e266ad51c5
Simplify logic; remove unnecessary methods
2020-03-28 14:17:33 +01:00
Mark Monteiro
ea306e8f6d
Do not assign an invalid value of zero to ExtraType
2020-03-28 13:54:14 +01:00
Mark Monteiro
5fcbedc194
Display extras with an unknown type
2020-03-28 13:40:56 +01:00
Bond_009
e9d1eabd53
Remove unused usings
2020-03-24 16:12:06 +01:00
Mark Monteiro
6897a19051
Add missing null check when retrieving extras
2020-03-22 15:09:51 +01:00
dkanada
a96c0a72b8
Merge pull request #2549 from dkanada/refactor
...
Refactor some provider classes
2020-03-18 17:43:15 +09:00
Bond-009
008a76cf4d
Merge pull request #2502 from JustAMan/baseitem-equals
...
Adds BaseItem.Equals method that compares items by their Id
2020-03-11 16:00:36 +01:00
dkanada
52fde64f10
remove unused files and fix some future warnings
2020-03-09 23:30:57 +09:00
Vasily
f4ccee5801
Add inheritdoc comment and squash simple method bodies
2020-03-05 15:03:17 +03:00
Vasily
456f571343
Follow code review suggestions
2020-03-05 14:25:50 +03:00
Vasily
007c5b9f67
Implement BaseItem.GetHashCode override
2020-03-04 13:06:13 +03:00
Vasily
f21cd30039
Lower log level for BaseItem.Equals to debug
2020-03-03 19:22:45 +03:00
Vasily
11abe31e0d
Speed up equality comparison of BaseItem
2020-03-02 12:31:31 +03:00
Vasily
d1670f8180
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
2020-02-27 16:02:18 +03:00
Vasily
8e20d2e931
Simplify AlphanumericComparer, reduce code duplication
2020-02-27 14:51:34 +03:00
Bond_009
bb236b9591
Merge branch 'master' into warn12
2020-01-10 21:18:16 +01:00
Bond_009
2ef4ffd698
More warnings (removed)
2019-12-11 00:13:57 +01:00
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
2019-11-04 10:03:18 -05:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Andrew Mahone
f22ca6dd9e
Retrieve media attachments in BaseItem.
2019-10-22 10:36:54 -04:00
Bond_009
5edb8159a7
Fix Json serialization error
2019-10-15 17:49:49 +02:00
Anthony Lavado
bae5e3795e
Fix SetImage to avoid out of range exception ( #1798 )
...
* Fix SetImage to avoid out of range exception
* Actually use the new images we've retrieved
2019-09-26 09:47:48 -04:00
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
2019-09-23 20:32:44 +02:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
SL1288
fdc24ec2ee
Fix LocalTrailers playback.
2019-08-19 18:56:41 +02:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Claus Vium
0ef52c739e
Review changes
...
Untested
2019-05-16 07:27:38 +02:00
Claus Vium
b8a09339cd
Enforce extras folder structure according to Emby's wiki
2019-05-02 08:14:00 +02:00
Claus Vium
c1daea0ec7
Change owner and parent id of extras to the main media item
2019-05-01 07:47:22 +02:00
Bond-009
80fb3dc2cb
Fix error
2019-03-08 06:36:00 +01:00
Bond-009
4625592a83
Quick nullref fix
2019-03-07 22:52:41 +01:00
Bond-009
c5fce647de
Cleanup/simplification
...
* Removed useless copies/allocations
* Reduced unneeded complexity
2019-03-07 21:13:13 +01:00
Torsten
2690ac299b
Only refresh metadata if extras changed
2019-02-20 16:39:49 +01:00
Torsten
9753a76905
Populate video extras again
2019-02-19 22:41:25 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Vasily
8487319374
Merge pull request #726 from EraYaN/remove-wrappers-for-system-io
...
Clean up IFileSystem wrappers around stdlib.
2019-01-29 16:50:01 +03:00
Erwin de Haan
450f246f95
Unwrapped GetFileNameWithoutExtension
2019-01-28 22:10:51 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory
, DirectoryExists
, FileExists
& removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Claus Vium
dc68d61491
Fix default aspect ratio
2019-01-28 21:55:44 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Claus Vium
0e617933f6
Change default aspect ratio to 2/3 from 0
2019-01-26 22:19:14 +01:00
Bond_009
883575893b
Change image dimentions from double to int
...
Rename ImageSize -> ImageDimensions
2019-01-26 13:16:47 +01:00
hawken
3701ce4037
Eliminate some compile warnings ( #600 )
...
* Remove some unused variables
* remove duplicate "using .." by sorting and deduping the list
* Remove things that already exist in the parent class (in one case I moved some documentation to the parent)
* EntityBodyData and and NextSearch were never set (only read), removed
* _timeout was never read, subsequently _timer became unused. part of a TODO timeout functionality that was not implemented yet
2019-01-24 18:56:43 +01:00
Bond_009
35d97dc949
Minor improvements to library scan code
2019-01-20 19:40:37 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
a36658f6f0
ReSharper Reformat: Properties to expression bodied form.
2019-01-13 21:31:14 +01:00
Erwin de Haan
ba610b5094
Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.Controller
2019-01-13 21:01:16 +01:00
Erwin de Haan
26ca4b607b
Visual Studio Reformat: MediaBrowser.Controller
2019-01-13 20:25:32 +01:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00
Bond_009
340a2c6512
Post GPL cleanup
2019-01-03 23:19:02 +01:00
Bond_009
b1ccd6bad9
Fix build post GPL change
2018-12-30 22:44:39 +01:00
Bond_009
ea4c914123
Fix exception logging
2018-12-30 22:44:39 +01:00
Bond_009
b7ebb67cbb
Remove the need for NullLogger
2018-12-30 22:44:38 +01:00
Bond_009
0f8b3c6347
Use Microsoft.Extensions.Logging abstraction
2018-12-30 22:44:38 +01:00
Bond_009
6e5d2aadaa
Remove custom ToArray extension
2018-12-28 16:48:26 +01:00
Andrew Rabert
a86b71899e
Add GPL modules
2018-12-27 18:27:57 -05:00
stefan
48facb797e
Update to 3.5.2 and .net core 2.1
2018-09-12 19:26:21 +02:00
Luke Pulverenti
58a7829ecd
update library changed notifier
2017-11-25 23:48:12 -05:00
Luke Pulverenti
5cb7469028
support track selection before playback
2017-11-05 16:51:23 -05:00
Luke Pulverenti
0d28929e17
update download progress reporting
2017-11-03 14:11:04 -04:00
Luke Pulverenti
fc9de2589c
reset image dimensions on changes
2017-10-30 00:52:30 -04:00
Luke Pulverenti
ac09136a3d
restore GetImageSize method
2017-10-22 17:38:03 -04:00
Luke Pulverenti
7e5036a587
update image aspect ratio detection
2017-10-22 02:22:43 -04:00
Luke Pulverenti
4ef9f68837
support delete per library
2017-10-16 02:10:55 -04:00
Luke Pulverenti
a5b82cd2ec
remove unneeded async signatures
2017-10-03 14:39:37 -04:00
Luke Pulverenti
cdd79ec7e2
update owned items
2017-09-18 12:52:22 -04:00
Luke Pulverenti
38fe239f44
3.2.30.19
2017-09-13 14:41:48 -04:00
Luke Pulverenti
9d78482358
fix skiasharp reference
2017-09-01 15:24:39 -04:00
Luke Pulverenti
e287e3a50d
remove async when there's nothing to await
2017-08-26 20:32:33 -04:00
Luke Pulverenti
6bc2a79792
fix folder rip probe
2017-08-26 03:03:19 -04:00
Luke Pulverenti
e441e2f53d
update active recordings
2017-08-24 15:52:19 -04:00
Luke Pulverenti
1ad990ad72
update live tv data transfer
2017-08-19 15:43:35 -04:00
Luke Pulverenti
d2b86edf05
update hdhr channel ids
2017-08-15 23:40:36 -04:00
Luke Pulverenti
e7425e6205
revert servicestack.text update
2017-08-10 14:01:31 -04:00
Luke Pulverenti
40442f887b
consolidate emby.server.core into emby.server.implementations
2017-08-09 15:56:38 -04:00
Luke Pulverenti
52aeb3c40b
consolidate interfaces
2017-08-07 17:06:13 -04:00
Luke Pulverenti
6d78824c8e
update components
2017-08-06 19:01:00 -04:00
Luke Pulverenti
2ed625d27e
update themes
2017-07-31 01:16:22 -04:00
Luke Pulverenti
dc7a59c73a
ensure custom css is loaded last
2017-07-23 18:29:53 -04:00
Luke Pulverenti
1e5c3db9eb
support individual library refreshing
2017-06-23 12:04:45 -04:00
Luke Pulverenti
e91f569c15
update live tv startup
2017-06-03 03:36:32 -04:00
Luke Pulverenti
5bfcbd4e9e
update dlna profiles
2017-05-31 15:21:32 -04:00
Luke Pulverenti
d8ec7109ab
add FindByPath error handling
2017-05-30 14:24:50 -04:00
Luke Pulverenti
3c82d8540b
update sortname generation
2017-05-29 20:44:48 -04:00
Luke Pulverenti
ffb68b0318
update realtime monitor
2017-05-27 03:19:09 -04:00
Luke Pulverenti
33014f77aa
update GetItems method
2017-05-26 02:48:54 -04:00
Luke Pulverenti
da77b05817
update data queries
2017-05-21 03:25:49 -04:00
Luke Pulverenti
d48496b843
add new search filters
2017-05-06 15:45:23 -04:00
Luke Pulverenti
696a6b34ea
improve smb support
2017-05-04 14:14:45 -04:00
Luke Pulverenti
a9b041a7e6
rework refresh queue
2017-04-29 22:37:51 -04:00
Luke Pulverenti
f53472584e
update environment detection
2017-04-29 02:22:33 -04:00
Luke Pulverenti
04b6f23473
3.2.9.1
2017-03-29 02:26:48 -04:00
Luke Pulverenti
6091e00e18
clean related files when deleting items
2017-02-18 03:32:17 -05:00
Luke Pulverenti
b91f1e4d16
support dummied up image a/r's
2017-02-10 15:06:52 -05:00
Luke Pulverenti
3ff216f05a
update ShortOverview
2017-01-26 15:27:12 -05:00