Commit graph

199 commits

Author SHA1 Message Date
cvium 42bcf171d9 Use sync Serialize when writing scheduled tasks to disk 2021-04-10 23:54:35 +02:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Bond_009 65bab55ca0 Minor improvements 2021-02-13 00:39:18 +01:00
dkanada 54a3ab15a3
Merge pull request #5005 from jellyfin/bytes
JsonSerializer deserialize from bytes where possible
2021-02-05 11:47:06 +09:00
crobibero 6abee2dd22 fix delete log task 2021-01-18 19:42:50 -07:00
Bond_009 1752423e52 Open FileStream with FileMode.Create instead of FileMode.OpenOrCreate
> The OpenWrite method opens a file if one already exists for the file path,
    or creates a new file if one does not exist. For an existing file,
    it does not append the new text to the existing text. Instead,
    it overwrites the existing characters with the new characters.
    If you overwrite a longer string
    (such as "This is a test of the OpenWrite method") with a shorter string
    (such as "Second run"), the file will contain a mix of the strings
    ("Second runtest of the OpenWrite method").

Ref: https://docs.microsoft.com/en-us/dotnet/api/system.io.file.openwrite?view=net-5.0#remarks
2021-01-12 15:51:32 +01:00
Bond_009 1ea2b200c0 JsonSerializer deserialize from bytes where possible
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT

| Method |     Mean |   Error |  StdDev |   Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
|  Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 |     - |     - |  52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 |     - |     - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 |     - |     - |  31.27 KB |
```
2021-01-12 15:28:02 +01:00
obradovichv 0282a1ed09 Fix string culture specificity
Fix bug in SsaParser.cs primary color {\1c} formatting that would leave
behind the {\1c} closing token and instead append </font> token
unconditionally to the dialogue text. Add tests.

Change AlphanumComparatorTests.cs complementary test data generation
from an array shuffle to an array reversal. Although it was previously
using a seeded Random, the shuffle itself could result in no
rearrangement of elements if the seed or test data changed over time.
The reversal guarantees reordering of elements and has the added benefit
of simplifying the test code since no special handling is needed for
arrays of 2 elements.

Change DailyTrigger.cs logging of TriggerDate format to
"yyyy-MM-dd HH:mm:ss.fff zzz" for consistency with configured log
timestamp format and change DueTime format to culture-invariant "c"
format.
2021-01-03 20:17:27 +02:00
Cody Robibero 5c57569692
Merge branch 'master' into PluginDowngrade 2020-12-30 18:11:37 -07:00
David 3dec1fd6b2 Use UTF8 encoding and async correctly 2020-12-29 00:35:59 +01:00
David 21fd124bca Code revie 2020-12-27 11:15:46 +01:00
David 043d045448 Put json serializer options in private field 2020-12-24 11:22:34 +01:00
David e835dfb27d Use sync string instead of file 2020-12-24 10:31:51 +01:00
David 2a574914ea Use streams instead of strings 2020-12-23 19:24:58 +01:00
David f38970cbd3 Remove xml docs 2020-12-23 15:03:14 +01:00
David 196388d607 Remove custom Json serializer from Emby.Server.Implementations 2020-12-23 13:14:40 +01:00
Greenback 7986465cf7 Initial upload 2020-12-14 16:14:39 +00:00
crobibero bf66f57069 Set DeleteTranscodeFileTask to trigger every 24h 2020-11-20 08:12:38 -07:00
Greenback e51ddd326c Fixes spelling. 2020-11-18 13:23:45 +00:00
crobibero e66d79fc0c Merge remote-tracking branch 'upstream/master' into http-exception 2020-11-15 13:09:05 -07:00
crobibero 95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
Bond_009 d4e568c8bf
Replace Task.WaitAll with Task.Wait 2020-11-14 20:30:08 +01:00
Bond_009 ff49a3bb61
Missed some stuff 2020-11-14 20:28:15 +01:00
Anthony Lavado 6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
Minor improvements
2020-11-02 11:10:39 -05:00
crobibero ceecc80bb3 Allow configuration of ActivityLogRetention 2020-11-01 18:32:41 -07:00
Bond_009 49569ca0a0 Use nameof where possible 2020-10-17 16:19:57 +02:00
crobibero 15a7f88e08 Automatically clean activity log database 2020-10-14 11:44:11 -06:00
Jan-Pieter Baert 6f9beef732
Fix SA1012 and SA1013 warnings 2020-10-12 19:22:33 +02:00
Anthony Lavado 959d906c85
Just enable instead 2020-10-05 02:25:09 -04:00
Anthony Lavado 375f849b3e
Simply trigger
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-10-05 02:14:43 -04:00
Anthony Lavado e77040a4fb
Fix Transcode Cleanup Schedule
Sets the default time to midnight, and confirms to the same task
scheduling commands that other tasks use.
2020-10-05 00:15:25 -04:00
Bond_009 e653eef44f Fix some warnings 2020-08-31 22:20:19 +02:00
Patrick Barron 9fa4fff15d Merge branch 'master' into event-rewrite-1
# Conflicts:
#	Emby.Dlna/Emby.Dlna.csproj
#	Emby.Dlna/Eventing/DlnaEventManager.cs
#	Emby.Dlna/Service/BaseService.cs
#	Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
#	MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Bond_009 ab2147751f Make MediaBrowser.MediaEncoding warnings free 2020-08-20 12:16:24 +02:00
Patrick Barron ca1f15af19 Move GenericEventArgs to Jellyfin.Data.Events 2020-08-13 20:52:55 -04:00
Patrick Barron 0aa349fe40 Remove unused dependencies. 2020-07-23 21:42:36 -04:00
telans 8de6452967
fix some documentation periods 2020-06-20 18:13:11 +12:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
telans acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
dkanada fe16c3fad4
Merge branch 'master' into install-plugin 2020-06-04 03:20:48 +09:00
Vasily 40502a33e0
Merge pull request #3203 from Bond-009/warn18
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
2020-06-03 12:27:59 +03:00
Bond_009 4748105dce Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode 2020-05-29 11:28:19 +02:00
Bond_009 7439e095e2 Merge branch 'master' into nullable3 2020-05-27 20:49:18 +02:00
dkanada 7972daaba4 fix a few issues with the plugin manifest 2020-05-24 15:40:27 +09:00
Bond_009 fc049caba2 Merge branch 'master' into nullable3 2020-04-15 11:09:14 +02:00
Mark Monteiro 1e1295bebf Merge remote-tracking branch 'upstream/master' into register-services-correctly 2020-04-11 10:00:39 -04:00
Mark Monteiro 8e3b09a996 Do not use IAsyncEnumerable unnecessarily 2020-04-06 22:04:24 -04:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Mark Monteiro adf0e8d3fd Register and construct ITaskManager and IIsoManager correctly 2020-04-04 21:00:11 -04:00
Bond-009 ddd5d3aaec
Merge branch 'master' into usings 2020-04-01 18:51:44 +02:00
ferferga a9759f6a80 Rename translation keys 2020-03-29 23:46:19 +02:00
ferferga aa98160d70 Add whitespaces 2020-03-27 16:49:01 +01:00
ferferga 797b2fbf1d Restore comments 2020-03-27 11:25:32 +01:00
ferferga 28f07df657 Fix NullReferenceException at startup 2020-03-26 22:26:25 +01:00
ferferga 105fc3dc29 Apply suggestions 2020-03-26 21:40:41 +01:00
ferferga 30c1170a55 Remove comments 2020-03-26 20:29:00 +01:00
ferferga 0778eb20aa Translate Scheduled Tasks (names and descriptions) 2020-03-26 20:28:30 +01:00
Bond_009 e9d1eabd53 Remove unused usings 2020-03-24 16:12:06 +01:00
Mark Monteiro b67e9cde8c Replace ILogger with ILogger<T> wherever possible
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
dkanada ab2349ff3c update task names and descriptions 2020-02-01 22:27:25 +09:00
Bond-009 5f6bca8aeb Merge remote-tracking branch 'upstream/master' into baseurl 2019-12-05 17:49:15 +01:00
dkanada a7ef1aa7ec
Merge pull request #2050 from Bond-009/nullref
Fix possible nullref when updating packages
2019-12-05 15:23:48 +09:00
Bond_009 3221e837f9 * Add support for multi segment base urls
* Make baseurl case-insensitive
2019-11-25 11:55:24 +01:00
Bond-009 a4c2886ac0 Fix master build
I was wrong, it did break...
2019-11-25 11:04:51 +01:00
Joshua M. Boniface 48120d01dc
Merge pull request #1991 from Bond-009/transtemp
Don't append transcodes to transcoding temp path
2019-11-24 15:13:50 -05:00
Bond_009 6a6bfa6da9 Fix possible nullref when updating packages 2019-11-24 17:23:36 +01:00
Bond-009 b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
Bond-009 d4b438791f Don't append transcodes to transcoding temp path 2019-11-21 16:57:49 +01:00
dkanada b1f9b03b17 rename some missed variables and fix warnings 2019-11-21 21:55:10 +09:00
dkanada f3ca37e523 minor changes to transcode cleanup scheduled task 2019-11-21 21:55:10 +09:00
Bond_009 d529f81cd9 Improve IInstallationManager interface 2019-11-01 17:57:19 +01:00
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
dkanada 21ff63c371 move the transcode path 2019-08-29 00:14:50 -07:00
dkanada 685e9e4f58
Merge pull request #1584 from Bond-009/checksum
Check checksum for plugin downloads
2019-08-15 01:00:33 -07:00
Anthony Lavado 35da4ffa3e
Remove unneeded comment 2019-08-14 11:59:14 -04:00
Anthony Lavado 4762e2fc6c Add a task to clean up transcode cache 2019-08-14 01:51:46 -04:00
Bond_009 5eaf5465a5 Check checksum for plugin downloads
* Compare the MD5 checksum when downloading plugins
* Reduced log spam due to http requests
* Removed 'GetTempFileResponse' function from HttpClientManager
* Fixed caching for HttpClientManager
2019-08-11 15:54:58 +02:00
dkanada 1ad67e223f
Merge pull request #1462 from Bond-009/installationmanager
Improvements to InstallationManager
2019-08-11 03:47:10 -07:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond_009 65a0ca2f32 Improvements to InstallationManager 2019-06-14 18:38:14 +02:00
Bond-009 0804bed66d Log time in a standardized way 2019-02-26 19:40:23 +01:00
Bond_009 0f9006c81f Use stopwatch for more accurate measurements and reduce log spam
DateTime.Now is suitible for small timespans
Replaced the needlessly complex and verbose logging for the httpserver
2019-02-25 18:26:17 +01:00
Claus Vium 21f0a7e020 Make all class implementing dynamically loaded interfaces public 2019-02-15 23:05:14 +01:00
dkanada c118f111b6 add suggestions from code review 2019-02-03 19:40:55 +09:00
dkanada 52e91243e5 merge progress calculation into a single line 2019-02-03 19:40:55 +09:00
dkanada aadf7676d1 remove useless comments 2019-02-03 19:40:55 +09:00
dkanada 08ca1337a9 unhide several scheduled tasks and add missing properties 2019-02-03 19:40:55 +09:00
dkanada 07072d9f7b move all scheduled tasks and triggers into folders 2019-02-03 19:40:55 +09:00
dkanada 7e3c45c917 fix build errors and update plugin manifest location 2019-02-03 19:40:55 +09:00
dkanada 548270772c add PluginUpdateTask back into source 2019-02-03 19:37:18 +09:00
Bond-009 d0f2b3a747
Merge branch 'master' into startuptasks 2019-01-30 16:55:07 +01:00
Erwin de Haan 838541b825 Removed loose whitespace and one .ToArray() call. 2019-01-28 22:21:14 +01:00
Erwin de Haan b9a111432a Unwrapped all /(Write|Read)All(Text|Bytes)/ functions. 2019-01-28 22:10:50 +01:00
Erwin de Haan a430568082 Unwrapped OpenRead and CopyFile 2019-01-28 22:09:58 +01:00
Erwin de Haan d7c6d16250 Unwrapped CreateDirectory and DeleteDirectory 2019-01-28 22:09:56 +01:00
Erwin de Haan 3a831994f6 Unwrapped GetDirectoryName and DirectorySeperatorChar 2019-01-28 22:06:34 +01:00
Claus Vium a05d803d4c Fix crash when trying to deserialize a non-existing scheduled task 2019-01-27 21:09:40 +01:00