Marc Brooks
cb292009e0
Merge branch 'master' into sort-nfo-data
2024-03-05 14:55:32 -06:00
Patrick Barron
690e603b90
Use IHostedService for NFO user data
2024-02-07 10:52:36 -05:00
Martin Vandenbussche
27ab3ef029
Removing unnecessary array initialization
2024-01-17 16:46:04 +01:00
Martin Vandenbussche
9ff9c8f0c7
Apply suggestions from code review
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2024-01-16 08:50:39 +01:00
Martin Vandenbussche
7cd60aefb5
Adding support for proper trailer STRM URL format, along with the deprecated format
2024-01-15 16:19:47 +01:00
Marc Brooks
5b98a5cfbe
Merge branch 'master' into sort-nfo-data
2023-11-16 11:19:40 -06:00
Bond_009
b62b0ec2b5
Fix warnings
2023-11-14 21:14:21 +01:00
Bond_009
eb022c49cc
Update to .NET 8
2023-11-14 21:12:16 +01:00
Bond_009
a9ef103c95
Add IDisposableAnalyzers to more projects
2023-11-05 02:01:14 +01:00
Stepan Goremykin
8d7e4229ca
Merge branch 'master' into fix-resharper-warnings
...
# Conflicts:
# Emby.Server.Implementations/Net/SocketFactory.cs
# RSSDP/SsdpCommunicationsServer.cs
# RSSDP/SsdpDeviceLocator.cs
# RSSDP/SsdpDevicePublisher.cs
2023-10-12 20:11:16 +02:00
Patrick Barron
1ce49b4a04
Merge branch 'master' into xml-parsing-cleanup
2023-10-10 12:00:45 -04:00
Bond-009
1279df2032
Merge pull request #10339 from leovan/master
2023-10-10 13:13:14 +02:00
scampower3
305405c9a1
Combine Title and Overview for multi-episodes files for NFO file ( #10080 )
2023-10-10 13:12:09 +02:00
Stepan Goremykin
f84469d500
Remove redundant using directives
2023-10-08 00:50:02 +02:00
Stepan Goremykin
526f9a825c
Make files readonly
2023-10-08 00:40:58 +02:00
Stepan Goremykin
0870af330d
Remove redundant verbatim string prefixes
2023-10-08 00:15:38 +02:00
Patrick Barron
40e1c5f4c6
Remove logger parameter from XmlReaderExtensions.TryReadDateTime
2023-10-06 16:56:50 -04:00
Patrick Barron
1d0ecd3188
More miscellaneous cleanup
2023-10-06 16:18:33 -04:00
Patrick Barron
0e51ffa169
Add TryReadInt to XmlReaderExtensions
2023-10-06 15:35:26 -04:00
Patrick Barron
8a7a1cc723
Add ReadNormalizedString to XmlReaderExtensions
2023-10-06 15:12:49 -04:00
Patrick Barron
99832642ce
Add TryParseDateTime and TryParseDateTimeExact to XmlReaderExtensions
2023-10-06 14:18:56 -04:00
Patrick Barron
1a6ec2c740
Add GetStringArray and GetPersonArray to XmlReaderExtensions
2023-10-06 13:40:08 -04:00
Patrick Barron
bdca4ed322
Add XmlReader.GetPersonFromXmlNode
2023-10-06 12:46:35 -04:00
Leo
cb8a8c3ef4
fix: use movie.nfo first when <filename>.nfo also exists ( jellyfin/jellyfin#1558 )
2023-10-05 11:19:52 +08:00
Marc Brooks
21d8e5438e
Sort embedded collections in Nfo files
...
Because the Nfo files emit the collections as they are in-memory, the
files are not stable in format, genres, tags, albums, people, etc. are emitted in random orders. Add ordering of the collections when emitting the Nfo files so the file remains stable (unchanged) when underlying media information doesn't change.
In the process of this, it became clear that most of the providers and probes don't trim the strings like people's names, genre names, etc. so did a pass of Trim cleanup too.
Specific ordering: (alphabetical/numeric ascending after trimming blanks and defaulting to zero for missing numbers)
BaseItem: Directors, Writers, Trailers (by Url), Production Locations, Genres, Studios, Tags, Custom Provider Data (by key), Linked Children (by Path>LibraryItemId), Backdrop Images (by path), Actors (by SortOrder>Name)
AlbumNfo: Artists, Album Artists, Tracks (by ParentIndexNumber>IndexNumber>Name)
ArtistNfo: Albums (by Production Year>SortName>Name)
MovieNfo: Artists
Fix Debug build lint
Fix CI debug build lint issue.
Fix review issues
Fixed debug-build lint issues.
Emits the `disc` number to NFO for tracks with a non-zero ParentIndexNumber and only emit `position` if non-zero.
Removed the exception filtering I put in for testing.
Don't emit actors for MusicAlbums or MusicArtists
Swap from String.Trimmed() to ?.Trim()
Addressing PR feedback
Can't use ReadOnlySpan in an async method
Removed now-unused namespace
2023-08-02 01:06:34 -05:00
Bond_009
b5f0760db8
Use RegexGenerator where possible
2023-06-28 17:07:57 +02:00
Shadowghost
6ddc449a89
Implement NFO named season parsing
2023-05-20 18:57:56 +02:00
Stepan Goremykin
6ae1903453
Use TryAdd
2023-04-06 19:17:28 +02:00
Cody Robibero
89be3aa37f
Convert Person.Type to use PersonKind enum ( #9487 )
2023-03-25 11:52:02 -06:00
SenorSmartyPants
4f0615452b
Update MediaBrowser.XbmcMetadata/Savers/MovieNfoSaver.cs
...
Apply code review
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-09 17:44:12 -06:00
SenorSmartyPants
99816b07dc
Enable NFO processing for Extras
...
- Change test to prevent owned items from using parent NFO. Test is now in MovieNFOSaver, only movie type will use movie.nfo.
2023-03-09 17:44:12 -06:00
Bond_009
7a93731992
Ignore avg critic rating Rotten Tomatoes
2023-03-07 18:44:59 +01:00
Bond_009
24a7e210c3
Optimize tryparse
...
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Zoltan Csizmadia
e0519189b2
Use Directory.Packages.props ( #9135 )
...
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
2023-02-04 10:15:08 -07:00
ProfessionalismIsMyMiddleName
ffc4cc4a04
Save modified userData after parsing an nfo in case of "watched", "playcount" or "lastplayed" tags.
2023-01-25 07:35:18 +01:00
renovate[bot]
e408da4651
chore(deps): update dependency microsoft.codeanalysis.bannedapianalyzers to v3.3.4 ( #9117 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-18 04:16:59 -07:00
Bond_009
b366dc2e6e
Use ArgumentException.ThrowIfNullOrEmpty
2022-12-07 16:43:59 +01:00
Bond_009
236dd650d0
Update projects to .net7
2022-12-07 16:42:05 +01:00
Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e
Replace == null with is null
2022-12-05 15:00:20 +01:00
Shadowghost
2e639c77c7
Apply review suggestions
2022-11-17 18:54:35 +01:00
Shadowghost
072651c4be
Add xmldocs for TMDb provider, correct provider spelling
2022-11-17 11:16:20 +01:00
luz paz
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
dependabot[bot]
812841d01e
Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 ( #7726 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-09 15:24:09 +02:00
Cody Robibero
834fe85185
Merge pull request #7543 from daullmer/nfo-datefix
...
(cherry picked from commit a280ff603f
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:11 -04:00
dependabot[bot]
dde984bd0e
Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406
...
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers ) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases )
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406 )
---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 12:22:11 +00:00
David Ullmer
7885167f54
Fix nfo thumb tags without aspect
2022-02-08 09:08:35 +01:00
Cody Robibero
b6489e73ab
Merge pull request #7241 from Bond-009/async5
2022-02-06 15:25:48 -07:00
Bond_009
e7be01d7a5
Flush to disk async where possible
2022-01-22 23:36:42 +01:00
Bond_009
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00