Commit graph

560 commits

Author SHA1 Message Date
David a4cac09d5b Use |= 2021-03-23 19:25:32 +01:00
David 60ffa6f514 Use FileShare.None when creating files 2021-03-07 14:43:28 +01:00
cvium ba366118f9 Do not use language or imagelanguages when searching for images
TMDb API returns all images if languages are excluded, which is needed for the All Languages toggle in Identify.
2021-03-05 08:18:04 +01:00
cvium 664c5da317 return false when providerid is null or empty 2021-03-03 09:09:57 +01:00
David 16694b0cfc Add nfo thumb tag support 2021-02-28 15:00:17 +01:00
Bond_009 e9f22303a4 Properly forward cancellationTokens 2021-02-15 14:19:17 +01:00
martinek-stepan cc92f7afe5
Enable nullable for MediaBrowser.XbmcMetadata project (#4612)
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Stepan <ste.martinek+git@gmail.com>
2020-12-31 12:09:25 +01:00
cvium 3f6e6c4839 Simplify 2020-12-10 14:47:47 +01:00
cvium dd238937f4 Remember to await the async task 2020-12-10 13:44:58 +01:00
cvium 3c5bbeb80c Remove ImageFetcherPostScanTask 2020-12-10 13:38:33 +01:00
Claus Vium f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
Increase library scan and metadata refresh speed
2020-12-04 13:17:26 +01:00
Gary Wilber 2b6b2cbf31 Remove Lazy 2020-12-02 23:23:13 -08:00
Gary Wilber f4edca7c27 Move MetadataRefreshThrottler to BaseItemManager 2020-12-02 18:51:53 -08:00
BaronGreenback d3b0080a27
Update MetadataService.cs
added return Task.CompletedTask;
2020-11-21 23:29:52 +00:00
BaronGreenback 79855a76b1
Update MetadataService.cs
removed async line 232
2020-11-21 23:21:15 +00:00
Joshua M. Boniface bf54b5579c
Merge branch 'master' into defer_image_fetching 2020-11-21 17:20:31 -05:00
Joshua M. Boniface 212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
Corrects spelling in comments
2020-11-19 13:08:28 -05:00
Claus Vium 15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
Add BaseItemManager
2020-11-19 14:58:48 +01:00
Greenback 9a323f6df0 More spelling corrections. 2020-11-18 13:46:14 +00:00
Bond_009 4b1c9dc9ea Pass cancellation where possible 2020-11-17 19:43:00 +01:00
crobibero 95a2de757f remove custom HttpException 2020-11-14 14:30:34 -07:00
Fernando Fernández 103d503c15 Removed code as suggested by @cvium 2020-11-10 02:12:47 +01:00
crobibero 64b32d3290 Use BaseItemManager 2020-10-27 18:01:52 -06:00
ferferga 9fd01fade6 Remove "download images in advance" option 2020-10-19 17:28:07 +02:00
cvium 763862cbd8 Defer image pre-fetching until the end of a refresh/scan 2020-10-03 13:36:53 +02:00
Gary Wilber 25d8d85740 Back to HttpException 2020-09-29 01:19:12 -07:00
Gary Wilber e9911b70dd Use EnsureSuccessStatusCode 2020-09-28 18:12:35 -07:00
Gary Wilber 722ec43e25 remove status code from exception message 2020-09-27 23:05:43 -07:00
Gary Wilber 3ca9b13f99 Check response status code before saving images 2020-09-27 21:47:30 -07:00
Bond_009 2dbf73b989 Minor improvements 2020-09-16 14:16:44 +02:00
Bond_009 384ab39f5b Fix some warnings 2020-09-07 13:20:39 +02:00
crobibero dd078e7b82 use named client 2020-08-31 11:05:21 -06:00
Patrick Barron 9fa4fff15d Merge branch 'master' into event-rewrite-1
# Conflicts:
#	Emby.Dlna/Emby.Dlna.csproj
#	Emby.Dlna/Eventing/DlnaEventManager.cs
#	Emby.Dlna/Service/BaseService.cs
#	Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
#	MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
2020-08-24 20:04:13 -04:00
Bond_009 119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
Patrick Barron 98ed90c4a2 Merge branch 'master' into event-rewrite-1 2020-08-19 18:11:17 -04:00
Bond_009 2b400c99ef Fix warnings 2020-08-19 17:50:50 +02:00
crobibero 767c73e5c1 fix usings 2020-08-17 13:22:42 -06:00
crobibero 1325815182 Remove IHttpClient from Providers 2020-08-17 13:10:02 -06:00
crobibero 10ac32569e Remove IHttpClient from ItemImageProvider 2020-08-17 11:54:55 -06:00
crobibero f7dc124b5e Remove IHttpClient from ProviderManager 2020-08-17 11:50:07 -06:00
Patrick Barron ca1f15af19 Move GenericEventArgs to Jellyfin.Data.Events 2020-08-13 20:52:55 -04:00
Anthony Lavado 5480674c4f
Merge pull request #3838 from Bond-009/memorystream
MemoryStream optimizations
2020-08-13 13:01:43 -04:00
Bond-009 bacfbbbd58
Merge pull request #3835 from cvium/fix_tvdb_404_shit_nginx_failure
Throw HttpException when tvdb sends us crap data
2020-08-10 10:50:21 +02:00
Bond_009 371a09c60b MemoryStream optimizations 2020-08-09 14:08:55 +02:00
cvium 23dfadd430 Throw HttpException when tvdb sends us crap data 2020-08-06 23:43:19 +02:00
Anthony Lavado da14c306b8
Merge pull request #3809 from Bond-009/minor4
Minor improvements
2020-08-04 17:35:12 -07:00
cvium 52d409101b Change OnRefreshStart and OnRefreshComplete logging levels to debug 2020-08-04 09:05:51 +02:00
Bond_009 2b355c36ff Minor improvements
OFC I reduced some allocations
2020-08-03 20:32:45 +02:00
E.Smith f50348ca0b Log path on lookup errors
If the lookup fails (due to a bad id in an nfo file for example), then
we had no indication of which directory failed, so the user can not
fix the problem.

Now we include the path in the error message such as:

MediaBrowser.Providers.TV.SeriesMetadataService: Error in
DummySeasonProvider for /media/x/y/z

and

MediaBrowser.Providers.Manager.ProviderManager:
TvdbSeriesImageProvider failed in GetImageInfos for type Series at
/media/x/y/z
2020-07-22 18:22:52 +01:00
Patrick Barron 6e11f77922 Add missing documentation. 2020-07-19 22:30:25 -04:00
Patrick Barron 3fdbdf4078 Clean up ProviderManager.cs 2020-07-19 20:54:57 -04:00
Patrick Barron 6d1b00da64 Use Array.Empty 2020-07-04 11:54:25 -04:00
Mark Monteiro 0e9164351b Merge remote-tracking branch 'upstream/master' into external-id-type 2020-06-26 10:12:22 -04:00
Bond-009 f75024fade Fix scan crashed 2020-06-22 10:06:35 +02:00
Anthony Lavado bb947718ea
Merge pull request #3380 from Bond-009/warn20
Enable TreatWarningsAsErrors in Release for MediaBrowser.Providers
2020-06-20 12:26:02 -04:00
telans 98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
telans afe09612e8
fix SA1119 2020-06-20 18:13:11 +12:00
Bond_009 eba488a0f8 Enable TreatWarningsAsErrors in Release for MediaBrowser.Providers 2020-06-19 20:24:13 +02:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
telans 3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
Patrick Barron 42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
dkanada 403cd3205f
Merge pull request #3254 from crobibero/ilogger
Use typed logger where possible
2020-06-13 00:29:43 +09:00
Patrick Barron 7a115024aa Merge branch 'master' into userdb-efcore
# Conflicts:
#	MediaBrowser.Controller/Library/ILibraryManager.cs
#	MediaBrowser.Providers/Users/UserMetadataService.cs
2020-06-11 18:23:12 -04:00
aled 299e49f39d Fix a small number of compile warnings 2020-06-09 23:12:53 +01:00
crobibero 57d1dbfe7b undo erroneous changes 2020-06-05 18:29:58 -06:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron 06f9cde22f Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Bond_009 7439e095e2 Merge branch 'master' into nullable3 2020-05-27 20:49:18 +02:00
ferferga ba03ed65fe Remove "download images in advance" option 2020-05-27 19:13:41 +02:00
Patrick Barron 1d1a145ad4 Fix issues and add profile image support 2020-05-20 10:04:00 -04:00
Mark Monteiro d06fee75b6 Rename Name to ProviderName 2020-05-17 17:36:36 -04:00
Mark Monteiro 67edf1b7f5 Do not convert 'Type' value to string unnecessarily, and do not replace 'General' type with null 2020-05-17 15:59:13 -04:00
Mark Monteiro e5c857ac36 Rename external id type 'None' to 'General' 2020-05-17 15:29:53 -04:00
Mark Monteiro 96acd6481e Merge branch 'master' into externalid-type 2020-05-17 13:50:44 -04:00
Patrick Barron 9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Mark Monteiro 3d8b81039d Log refresh progress at Debug level 2020-04-04 15:08:04 -04:00
Mark Monteiro 51b9a6e94b Register IProviderManager correctly 2020-04-04 14:56:50 -04:00
Bond_009 3ab50f5a3f Address comments 2020-04-01 19:05:41 +02:00
Bond_009 787049f35f Merge branch 'master' into minor 2020-04-01 18:53:22 +02:00
Luke Foust 0fb78cf54b Add documentation around Name, Id, and Type. Changed ExternalIdType to ExternalIdMediaType 2020-03-26 14:26:12 -07:00
Luke Foust 9bdb99fe92 Add type to externalids to distinguish them in the UI 2020-03-22 12:58:53 -07:00
dkanada 4f195f289c remove useless interface 2020-03-10 00:10:02 +09:00
dkanada 52fde64f10 remove unused files and fix some future warnings 2020-03-09 23:30:57 +09:00
Bond_009 e699e5d405 Fix possible race condition 2020-02-28 20:34:10 +01:00
Bond_009 d1e1aef5f7 Fix possible race condition 2020-02-26 18:19:34 +01:00
Bond_009 a07ee65365 Minor improvements 2020-02-23 10:53:51 +01:00
Bond_009 87d2479b78 Fix warnings 2020-01-31 22:26:53 +01:00
Bond-009 c8409d2ea1 Remove FileSystem.GetStream 2020-01-22 22:20:35 +01:00
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Bond-009 ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Anthony Lavado cb393c215a
Merge pull request #1686 from Bond-009/warn7
More warning fixes
2019-09-02 02:07:19 -04:00
Bond_009 e4f893a0eb More warning fixes 2019-08-29 22:28:33 +02:00
dkanada 21ff63c371 move the transcode path 2019-08-29 00:14:50 -07:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Bond-009 bf43dc00bb More warning fixes 2019-03-13 22:32:52 +01:00
Bond-009 594b271383
Merge pull request #1024 from jellyfin/release-10.2.z
Backmerge for 10.2.2
2019-03-01 07:49:07 +01:00
Claus Vium 2e9a3d45c2 Fix slow local image validation (#990)
* Check for local image directory existence to avoid tons of exceptions
2019-02-24 10:16:53 -05:00
Claus Vium dab25a0eeb Remove OptimizedPriorityQueue source and grab it from nuget 2019-02-19 21:17:30 +01:00
Erwin de Haan f1ef0b0b4c Fix namespacing so it lines up properly with file names and paths (#715)
* Fix stupid namespacing so it lines up properly with file names and paths.
2019-02-09 10:10:33 +01:00
Joshua M. Boniface 56dcc45dc0
Merge pull request #732 from Bond-009/locale
Reworked LocalizationManager to load data async
2019-02-03 22:08:20 -05:00
Joshua M. Boniface c713824bf9
Merge pull request #734 from Bond-009/culture
Fix more analyzer warnings
2019-01-31 21:11:13 -05:00
Claus Vium 8985fb8d58 Remove support for games as a media type 2019-01-31 19:04:47 +01:00
Bond-009 2a1f6361a5
Merge branch 'master' into locale 2019-01-31 18:44:36 +01:00
Bond-009 1ea219bf3f
Merge branch 'master' into culture 2019-01-30 16:57:15 +01:00
Erwin de Haan 450f246f95 Unwrapped GetFileNameWithoutExtension 2019-01-28 22:10:51 +01:00
Erwin de Haan 581a7fe078 Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile 2019-01-28 22:10:00 +01:00
Erwin de Haan d7c6d16250 Unwrapped CreateDirectory and DeleteDirectory 2019-01-28 22:09:56 +01:00
Erwin de Haan 3a831994f6 Unwrapped GetDirectoryName and DirectorySeperatorChar 2019-01-28 22:06:34 +01:00
Bond_009 a709cbdc64 Fix more analyzer warnings 2019-01-27 12:12:44 +01:00
Bond_009 51edd5d067 Reworked LocalizationManager to load data async 2019-01-27 10:36:05 +01:00
Erwin de Haan 38f96af079 Reformat JustAMan review pt2 changes
Refs #575
2019-01-17 20:24:39 +01:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan a36658f6f0 ReSharper Reformat: Properties to expression bodied form. 2019-01-13 21:31:14 +01:00
Erwin de Haan b062577d81 Find+Sed BOM removal *.cs: MediaBrowser.Providers-SocketHttpListener 2019-01-13 21:03:10 +01:00
Erwin de Haan aacafee1de EditorConfig reformat: MediaBrowser.Providers, MediaBrowser.Tests, SocketHttpListener 2019-01-13 20:31:48 +01:00
Erwin de Haan 587bb85b41 Visual Studio Reformat: MediaBrowser.Providers 2019-01-13 20:26:31 +01:00
Erwin de Haan e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
hawken ba1794f64b Remove tabs and trailing whitespace 2019-01-07 23:24:34 +00:00
Bond_009 c99b45dbe0 Remove some warnings 2019-01-02 02:35:40 +03:00
Bond_009 ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009 b7ebb67cbb Remove the need for NullLogger 2018-12-30 22:44:38 +01:00
Bond_009 0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
Bond_009 6e5d2aadaa Remove custom ToArray extension 2018-12-28 16:48:26 +01:00
stefan 48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti b5ab7776f1 3.2.36.11 2017-11-16 16:25:18 -05:00
Luke Pulverenti 9f46122d91 3.2.36.10 2017-11-15 16:33:04 -05:00
Luke Pulverenti 5cb7469028 support track selection before playback 2017-11-05 16:51:23 -05:00
Luke Pulverenti fc9de2589c reset image dimensions on changes 2017-10-30 00:52:30 -04:00
Luke Pulverenti 93676f6838 revise unknown audio stream handling 2017-10-28 23:52:05 -04:00
Luke Pulverenti 060215143f improve httpclient resource disposal 2017-10-20 12:16:56 -04:00
Luke Pulverenti 12adc7ae4c add additional info to timer infos 2017-10-18 21:19:48 -04:00
Luke Pulverenti 164e7dc896 improve live tv direct play 2017-10-14 02:52:56 -04:00
Luke Pulverenti 851c62a940 update image magick orientation function 2017-10-11 02:24:22 -04:00
Luke Pulverenti 43eec485e9 fix book providers 2017-10-06 11:49:22 -04:00
Luke Pulverenti 51ca72ab5d adjust default provider order 2017-10-05 14:10:07 -04:00
Luke Pulverenti a5b82cd2ec remove unneeded async signatures 2017-10-03 14:39:37 -04:00
Luke Pulverenti 085470394e update home screen sections 2017-10-01 13:26:09 -04:00
Luke Pulverenti cdd79ec7e2 update owned items 2017-09-18 12:52:22 -04:00
Luke Pulverenti 38fe239f44 3.2.30.19 2017-09-13 14:41:48 -04:00
Luke Pulverenti 49b799adbe 3.2.30.8 2017-09-05 15:49:02 -04:00
Luke Pulverenti e287e3a50d remove async when there's nothing to await 2017-08-26 20:32:33 -04:00
Luke Pulverenti e441e2f53d update active recordings 2017-08-24 15:52:19 -04:00
Luke Pulverenti 1ad990ad72 update live tv data transfer 2017-08-19 15:43:35 -04:00