Commit graph

447 commits

Author SHA1 Message Date
Stepan Goremykin 910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
Stepan Goremykin 7d7e177265 Remove redundant casts 2023-04-06 19:17:28 +02:00
Bond-009 2ce08eb184
Merge pull request #9388 from Shadowghost/output-bitrate-channels-master 2023-03-20 17:46:11 +01:00
Shadowghost e57c33c442 Add DCA and TrueHD to fMP4 audio codecs to support remuxing 2023-03-19 15:07:01 +01:00
Bond_009 d8ec3a5470 Reduce usage of GetAwaiter().GetResult() 2023-03-14 12:05:49 +01:00
Bond-009 6351d1022b
Merge pull request #9254 from Shadowghost/dvdbdfix 2023-03-10 15:48:35 +01:00
Shadowghost 0da5255f12 Apply review suggestions 2023-03-10 15:27:17 +01:00
Shadowghost 47aa07c342 Fix DLNA playback of DVD and BD folders 2023-03-10 15:27:17 +01:00
Shadowghost 2403a0a367 Apply review suggestions 2023-03-10 15:27:05 +01:00
Shadowghost 65090ac817 Backport pull request #9351 from jellyfin/release-10.8.z
Fix EqualsAny condition check for int and double

Original-merge: e8b0ae07af

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: crobibero <cody@robibe.ro>
2023-03-09 19:33:51 -05:00
Bond_009 dab75d35d2 Enable nullable for more files 2023-03-07 21:51:48 +01:00
Shadowghost c760a50d59 Apply review suggestions 2023-02-27 16:03:12 +01:00
Shadowghost 9880a2b3e1 Enforce HLS codec restrictions 2023-02-27 10:38:50 +01:00
Bond_009 24a7e210c3 Optimize tryparse
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Telepathic Walrus 06b40980f4 Fix transcoded audio not playing (#9251) 2023-02-05 19:27:50 +00:00
Shadowghost 979964ef4b Force transcode/remux for DVDs and BDs 2023-02-05 12:00:29 +01:00
Dmitry Lyzo 28b98cacc8 Backport pull request #9051 from jellyfin/release-10.8.z
Fix transcode reasons

Original-merge: 1dea309ae4

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 14:05:37 -05:00
Bond-009 817996da4b
Merge pull request #7494 from Shadowghost/streambuilder-cleanup 2022-12-29 15:21:28 +01:00
Shadowghost 81a7261980
Default to no bitrate limit if no maxBitrate is set (#8850)
Fixes https://github.com/jellyfin/jellyfin/issues/3277
2022-12-14 22:04:05 +01:00
Shadowghost 0834dc58c1 Fix .Net 7 compatibility 2022-12-07 18:06:04 +01:00
Shadowghost 8e8a085b7e Prefer var in StreamBuilder 2022-12-07 18:00:44 +01:00
Shadowghost 08a5c71b90 Add xmldoc for MediaOptions 2022-12-07 18:00:03 +01:00
Shadowghost 1cd7da8889 Apply review suggestions 2022-12-07 18:00:03 +01:00
Shadowghost 697efec86e Cleanup and refactor streambuilder 2022-12-07 18:00:01 +01:00
Bond_009 b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Dmitry Lyzo 2eb00bf3c0 fix secondary audio
Browsers (Chrome, Firefox) can only play the first track,
even if the second track is the default.

Ignore default flag when testing on secondary audio.

External audio tracks are not secondary.
2022-10-31 15:49:34 +03:00
Maxr1998 bf059d5b58 Backport pull request #8411 from jellyfin/release-10.8.z
Allow direct play even if no audio stream is available

Original-merge: bf129ab9b8

Merged-by: Claus Vium <cvium@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-28 22:38:56 -04:00
Claus Vium 719e5eae16
Merge pull request #8503 from Bond-009/ThrowIfNull 2022-10-07 07:50:39 +02:00
Jan Sommer 87d460909f Fix minor warnings in MediaBrowser.Model/Configuration (#2149) 2022-10-06 21:44:12 +02:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Hannes Braun 4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
luz paz 9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero 38102499cb Merge pull request #7947 from nyanmisaka/video-range-condition
(cherry picked from commit f1d56aa5ce)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Joshua M. Boniface 47d150565d Merge pull request #7712 from jellyfin/fix-hevc-disable-option
(cherry picked from commit 5a9e5e0d5d)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Joshua M. Boniface 2d8f7b46f1 Merge pull request #7699 from Shadowghost/streambuilder-fix
(cherry picked from commit b46d61dfdf)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Cody Robibero 688553b9a8 Merge pull request #7537 from dmitrylyzo/fix-streambuilder
(cherry picked from commit 5833c70725)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:10 -04:00
Cody Robibero 1960b5bdce Merge pull request #7523 from crobibero/null-stream
Allow media without streams to playback 

(cherry picked from commit 577325b788)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
Shadowghost 4e91c3ebdc Fix DLNA DirectPlay 2022-03-25 18:02:31 +01:00
Dmitry Lyzo e4137a6279 Fix remuxing 2022-03-20 09:11:46 +03:00
Dmitry Lyzo 1fe82d0deb Add TranscodingProfile conditions 2022-03-20 09:11:46 +03:00
Cody Robibero b9c3a497d5 Use requested bitrate for calculations 2022-03-19 12:08:42 -06:00
Cody Robibero d29c7c1d9e Revert using Math.Clamp 2022-03-13 12:46:13 -06:00
Cody Robibero e6df698df1
Merge pull request #7325 from eyezak/issue/6450 2022-03-12 09:08:25 -07:00
Cody Robibero 3ea4174d12 Fix flipped Clamp args 2022-03-12 07:17:59 -07:00
Claus Vium 53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Cody Robibero da41cd365c Suggestions from review 2022-03-06 18:17:49 -07:00
Cody Robibero bbd5d11d3b Remove TranscodeReason.None, Add JsonFlagEnum tests 2022-03-06 18:13:54 -07:00
Cody Robibero c331e11c24 Clean up EnumFlags serialization 2022-03-06 18:13:54 -07:00