Backupppert/jellyfin
0
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2024-07-08 23:00:51 +02:00
Code Issues Packages Projects Releases Wiki Activity
24423 commits 29 branches 75 tags 1.3 GiB
Commit graph

67 commits

Author SHA1 Message Date
Shadowghost eb52af4e6a
Fix playlists library and migration (#9770) 2023-05-15 06:45:33 -06:00
Shadowghost a8cdf4434b
Fix access to playlists not created by a user (#9746) 2023-05-12 07:11:59 -06:00
Shadowghost 9211a73e40
Apply suggestions from code review 
Co-authored-by: Cody Robibero <cody@robibe.ro>
 2023-03-25 18:41:09 +01:00
Shadowghost eba24d188d Update Emby.Server.Implementations/Playlists/PlaylistManager.cs 
Co-authored-by: Joe Rogers <1337joe@users.noreply.github.com>
 2023-03-18 10:49:52 +01:00
Shadowghost 82080bd1ef Apply review suggestions 2023-03-17 11:43:53 +01:00
Shadowghost 8d158df678 Add migration to properly set playlist owner 2023-03-10 19:16:57 +01:00
Shadowghost 76ae599bd3 Fix playlist creation and removal 2023-03-10 19:16:35 +01:00
Bond_009 b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009 f50a250cd9 Optimize Guid comparisons 
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
 2022-02-21 14:15:09 +01:00
Cody Robibero 7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009 474b035d99 Fix some warnings 2021-11-15 15:57:07 +01:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Cody Robibero 65f8d8c0cd [CA1801] Parameter is never used. Remove the parameter or use it in the method body. 2021-07-10 10:09:02 -06:00
Bond_009 7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
BaronGreenback bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
crobibero 3cc0dd7e12 Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage. 2020-11-16 20:29:46 -07:00
Bond_009 2b832de289 Fix build 2020-08-21 22:19:16 +02:00
Bond_009 119f64f5e7 Make some methods async 2020-08-21 22:01:19 +02:00
Bond_009 01e781035f Fix warnings 2020-07-24 16:37:54 +02:00
telans 98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
crobibero 24f54837e1 Switch to M3uContent 2020-06-15 08:34:24 -06:00
Patrick Barron 42b4f0aa2e Merge branch 'master' into userdb-efcore 
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
 2020-06-13 19:41:05 -04:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron 06f9cde22f Merge branch 'master' into userdb-efcore 
# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
 2020-06-04 16:52:23 -04:00
Vasily 40502a33e0
Merge pull request #3203 from Bond-009/warn18 
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
 2020-06-03 12:27:59 +03:00
Bond_009 4748105dce Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode 2020-05-29 11:28:19 +02:00
Patrick Barron c464f700db Remove redundant qualifiers 2020-05-20 13:07:53 -04:00
Patrick Barron 9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
Bond_009 30ce346f34 Enable nullabe reference types for MediaBrowser.Model 2020-04-05 18:10:56 +02:00
Mark Monteiro 9a7875b6f9 Do not check for duplicates if they are allowed in playlist configuration 2020-03-13 23:14:25 +01:00
Mark Monteiro d276e0f8f4 Use Distinct() to filter out duplicates when adding items to playlist 2020-03-11 23:26:55 +01:00
Mark Monteiro 487aa376b4 Merge remote-tracking branch 'upstream/master' into 1914-prevent-duplicates-in-playlists 2020-03-11 23:21:30 +01:00
Mark Monteiro b67e9cde8c Replace ILogger with ILogger<T> wherever possible 
Log entries will contain additional class context when using this interface
 2020-03-03 23:07:10 +01:00
Mark Monteiro 3cb98fba55 Use ToList() instead of ToArray() on sequences of unknown size 2020-03-03 18:18:00 +01:00
Mark Monteiro 6438771212 Exit method early if there are no unique playlist items to add 2020-03-03 17:48:11 +01:00
Mark Monteiro 4d32b59a0b Performance improvements 
Use arrays instead of lists; use Array.CopyTo to concat playlist items; only count number of duplicates once
 2020-03-03 17:47:16 +01:00
Mark Monteiro 77533fd433 Revert unnecessary style change 2020-03-03 14:40:07 +01:00
Mark Monteiro dde0277050 Check for duplicates when adding items to a playlist 2020-03-02 21:12:35 +01:00
dkanada 1b2453b4e9 fix playlist deletion 2019-12-14 12:51:27 +09:00
Bond_009 d9a03c9bb1 Fix more warnings 2019-10-29 17:55:16 +01:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Erwin de Haan b9a111432a Unwrapped all /(Write|Read)All(Text|Bytes)/ functions. 2019-01-28 22:10:50 +01:00
Erwin de Haan 581a7fe078 Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile 2019-01-28 22:10:00 +01:00
Erwin de Haan d7c6d16250 Unwrapped CreateDirectory and DeleteDirectory 2019-01-28 22:09:56 +01:00
Erwin de Haan 3a831994f6 Unwrapped GetDirectoryName and DirectorySeperatorChar 2019-01-28 22:06:34 +01:00
William Taylor 65cd3ed597 Replaced injections of ILogger with ILoggerFactory 
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
 2019-01-20 21:05:12 +00:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00