Commit graph

87 commits

Author SHA1 Message Date
Cody Robibero e1a30a4aef
Merge pull request #8598 from Neuheit/ipv4fallback 2023-05-11 07:12:34 -06:00
Stepan Goremykin 910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
Stepan Goremykin e74630a613 Use MinBy and MaxBy 2023-04-01 23:00:51 +02:00
Bond_009 d280dc6554 Reduce log spam
Fixes #7801
2023-03-01 16:43:55 +01:00
Bond_009 24a7e210c3 Optimize tryparse
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Zoltan Csizmadia e0519189b2
Use Directory.Packages.props (#9135)
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
2023-02-04 10:15:08 -07:00
Bond-009 e448797df0
Merge pull request #9066 from barronpm/reduce-logspam
Change log level for bind address usage to debug
2023-01-20 13:29:05 +01:00
renovate[bot] e408da4651
chore(deps): update dependency microsoft.codeanalysis.bannedapianalyzers to v3.3.4 (#9117)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-18 04:16:59 -07:00
Patrick Barron dfc5a4373f Change log level for bind address usage to debug
Fixes #9024
2023-01-10 19:58:54 -05:00
Bond-009 3462676a8f
Fix debug builds (#8909) 2022-12-14 22:03:03 +01:00
Neuheit 93fe47c7cb
Clarify code comment.
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-12-08 16:16:06 -05:00
Neuheit 292c4ebe72
Clarify code comment.
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2022-12-08 16:15:36 -05:00
Neuheit a7fc5e6e12
Add additional awaiter code comment. 2022-12-08 00:17:46 -05:00
Neuheit 9e791a92c3
Add comments explaining GetAwaiter() 2022-12-08 00:16:18 -05:00
Bond_009 236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Stefan Hendricks 6621121c1b
Add .NET MIT License 2022-10-29 18:54:11 -04:00
Neuheit 6caabe68ff Change method to call IPv6 and IPv4 in parallel. 2022-10-24 17:17:41 -04:00
Neuheit 6c479dfb36 Ensure IPv6 property is threadsafe. 2022-10-20 16:38:28 -04:00
Neuheit c9a387943f Add IPv4 fallback from IPv6 failure.
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2022-10-20 16:17:56 -04:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
luz paz 9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
dependabot[bot] 812841d01e
Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 (#7726)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-09 15:24:09 +02:00
Cody Robibero 94a69c8a8b Merge pull request #7549 from cvium/fix_isinlocalnetwork
(cherry picked from commit bdb85aeecf)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
dependabot[bot] dde984bd0e
Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases)
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406)

---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 12:22:11 +00:00
Bond_009 3cb49d6df0 Fix option to disable server discovery 2022-02-14 14:39:33 +01:00
Bond_009 2dcb2f8a9f Ban the usage of Task.Result
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
cvium 0485ff1899 Create a store key constant for network 2021-11-24 13:42:14 +01:00
cvium 1c47211a9e Merge remote-tracking branch 'BaronGreenback/TVFix' into TVFix 2021-11-08 10:58:28 +01:00
cvium f03e77a4d5 Merge branch 'master' into TVFix 2021-11-08 10:38:08 +01:00
Claus Vium 5eda5eb636
Merge pull request #6486 from fredriklindberg/support-forwarded-headers-for-api-url 2021-10-25 22:41:32 +02:00
Bond_009 13fbfe6091 Target net6.0 2021-09-24 20:15:46 +02:00
Fredrik Lindberg 90174f68e2 Dynamically populate LocalAddress based on HTTP request
Support populating the LocalAddress field in the system info
endpoint based on the x-forwarded-host and x-forwarded-proto header.

The x-forwarded-host header must contain both the host and port for
the url to be properly constructed.

Behind network configuration option that is disabled by default.
2021-09-14 21:38:11 +02:00
Claus Vium 4f51a22081
Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-09-07 19:52:17 +02:00
cvium ffe5ae8056 Merge branch 'master' into TVFix 2021-09-05 10:11:17 +02:00
Rich Lander c07e83fdf8
Invert code and style analysis configuration (#6334)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-07-30 09:49:28 +02:00
BaronGreenback 7936ea59eb Changed selection method 2021-05-03 17:27:23 +01:00
Bond-009 eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
Code Clean up: Group Methods
2021-04-29 21:14:57 +02:00
BaronGreenback 5741fa7dfa Fix url for LiveTV 2021-04-26 17:13:45 +01:00
BaronGreenback bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
BaronGreenback bb6fddde9a Group Methods 2021-04-17 11:19:09 +01:00
BaronGreenback 0b774eac12
Enables the ability to bind to loopback address. (#5773) 2021-04-14 11:26:05 +02:00
Joshua M. Boniface 19e7ebb279
Merge pull request #5416 from BaronGreenback/SubnetOverlappFix 2021-04-11 13:29:00 -04:00
BaronGreenback 5d16d1f66d
Merge branch 'master' into RemoteAccessFix 2021-03-22 17:05:44 +00:00
BaronGreenback 4c7680e186 Merge remote-tracking branch 'upstream/master' into SubnetOverlappFix 2021-03-14 18:40:44 +00:00
BaronGreenback 6087831aa6 Fixed selection of correct interface ip 2021-03-14 17:30:25 +00:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
BaronGreenback 4cf88f67ba
Update NetworkManager.cs 2021-03-12 14:58:04 +00:00