Commit graph

478 commits

Author SHA1 Message Date
cvium b99519898d Remove duplicate /Similar endpoints and add poor matching for artists and albums 2020-11-09 20:15:15 +01:00
cvium 584b4fa41f Fix Persons, Genres and Studios endpoints 2020-11-05 12:27:22 +01:00
Anthony Lavado 6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
Minor improvements
2020-11-02 11:10:39 -05:00
Bond_009 49569ca0a0 Use nameof where possible 2020-10-17 16:19:57 +02:00
Jan-Pieter Baert ec91d3893d
Fix SA 1116 warnings 2020-10-12 20:05:11 +02:00
Jan-Pieter Baert 6f9beef732
Fix SA1012 and SA1013 warnings 2020-10-12 19:22:33 +02:00
Matt Montgomery 53d5f64e03 Fix SA1513, SA1514, SA1507, and SA1508 2020-09-28 15:04:31 -05:00
Bond_009 2dbf73b989 Minor improvements 2020-09-16 14:16:44 +02:00
Bond_009 15be11fca8 Fix build 2020-09-09 14:22:27 +02:00
Bond_009 48e1cf9fd7 Minor performance improvements to item saving 2020-09-09 13:38:27 +02:00
crobibero 5f64ab02a0 bump System.Text.Json 2020-08-25 07:33:58 -06:00
crobibero 340f83c3f5 Ignore null json values 2020-08-23 07:48:12 -06:00
Bond_009 ab2147751f Make MediaBrowser.MediaEncoding warnings free 2020-08-20 12:16:24 +02:00
Bond_009 2b400c99ef Fix warnings 2020-08-19 17:50:50 +02:00
Bond_009 4980db1594 Fix spelling 2020-08-03 20:42:01 +02:00
Bond_009 2b355c36ff Minor improvements
OFC I reduced some allocations
2020-08-03 20:32:45 +02:00
Claus Vium 996d0c07d0
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs 2020-08-02 23:34:28 +02:00
Claus Vium 85e43d657f
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-08-02 23:33:45 +02:00
cvium aa32aba0f8 Remove some unnecessary string allocations. 2020-08-02 23:30:34 +02:00
Bond-009 b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
Migrate Display Preferences to EF Core
2020-08-01 21:51:49 +02:00
Bond_009 01e781035f Fix warnings 2020-07-24 16:37:54 +02:00
Patrick Barron 3d69cea1c9
Merge branch 'master' into displaypreferences-efcore 2020-07-23 23:50:12 +00:00
Bond_009 4d681e3cad Optimize StringBuilder.Append calls 2020-07-22 14:34:51 +02:00
Patrick Barron ab396225ea Migrate Display Preferences to EF Core 2020-07-17 16:11:53 -04:00
telans 98db8f72e0
fix SA1503 for one line if statements 2020-06-20 20:35:29 +12:00
telans 8de6452967
fix some documentation periods 2020-06-20 18:13:11 +12:00
Bond-009 9af6eda0b4
Merge pull request #3343 from telans/comment-stops
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans 247f9c61e6
fix SA1513/SA1516 2020-06-16 16:11:30 +12:00
telans 9018f8d8be
Add full stop at end of comments (SA1629) 2020-06-16 10:37:52 +12:00
telans 3d9049ef08
fix SA1508 2020-06-15 10:45:55 +12:00
telans acd4389653
fix SA1005 2020-06-15 10:41:00 +12:00
Patrick Barron 42b4f0aa2e Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2020-06-13 19:41:05 -04:00
dkanada 403cd3205f
Merge pull request #3254 from crobibero/ilogger
Use typed logger where possible
2020-06-13 00:29:43 +09:00
Patrick Barron 7a115024aa Merge branch 'master' into userdb-efcore
# Conflicts:
#	MediaBrowser.Controller/Library/ILibraryManager.cs
#	MediaBrowser.Providers/Users/UserMetadataService.cs
2020-06-11 18:23:12 -04:00
aled 299e49f39d Fix a small number of compile warnings 2020-06-09 23:12:53 +01:00
aled 22a860a806 Fix a small number of compile warnings 2020-06-06 20:17:49 +01:00
crobibero 44957c5a9a Use typed logger where possible 2020-06-05 18:15:56 -06:00
Patrick Barron 06f9cde22f Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Vasily 40502a33e0
Merge pull request #3203 from Bond-009/warn18
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
2020-06-03 12:27:59 +03:00
Bond_009 4748105dce Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode 2020-05-29 11:28:19 +02:00
Vasily 58f099c0e2 Fix naming per code review 2020-05-28 19:12:08 +03:00
Vasily 1f83a21288 Rename Hash to BlurHash in all properties and methods for clarity 2020-05-21 01:43:19 +03:00
Patrick Barron 3eeb6576d8 Migrate User DB to EF Core 2020-05-20 10:04:00 -04:00
Vasily a226a4ee03 Compute hash only when one is not computed in DB, small optimizations here and there 2020-05-19 14:50:14 +03:00
Jesús Higueras b9fc0d2628 Add BlurHash support to backend 2020-05-18 23:21:37 +03:00
Patrick Barron b7621d762c 2nd half of changes 2020-05-13 00:00:57 -04:00
Patrick Barron c1360a1dc3 Merge branch 'master' into userdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Data/SqliteUserDataRepository.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Entities/User.cs
#	Jellyfin.Data/ISavingChanges.cs
#	Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj
#	Jellyfin.Server.Implementations/JellyfinDb.cs
#	Jellyfin.Server/Migrations/MigrationRunner.cs
#	MediaBrowser.Model/Notifications/NotificationOptions.cs
#	MediaBrowser.sln
2020-05-12 22:22:20 -04:00
Patrick Barron 9ad839c776 Initial migration code 2020-05-12 22:10:35 -04:00
Mark Monteiro daf79b8aeb Do not double dispose write lock and connection in user data repository 2020-05-02 15:45:03 -04:00
Bond_009 118f30059c Merge branch 'master' into nullable4 2020-04-23 11:29:19 +02:00
Mark Monteiro f815059698 Merge remote-tracking branch 'upstream/master' into register-services-correctly 2020-04-20 20:11:33 -04:00
Bond_009 72219795d1 Remove dead function 2020-04-15 14:29:12 +02:00
Bond_009 10afa4509d Log exception 2020-04-15 11:14:54 +02:00
Mark Monteiro 1e1295bebf Merge remote-tracking branch 'upstream/master' into register-services-correctly 2020-04-11 10:00:39 -04:00
Vasily 06c5b73c15
Merge pull request #2755 from Bond-009/dbcleanup
Clean up SqliteItemRepository
2020-04-10 00:20:53 +03:00
Bond_009 c2b5fb78ce Address comments 2020-04-09 19:27:03 +02:00
Bond_009 2fcbc2a5b8 Enable nullabe reference types for Emby.Drawing and Jellyfin.Drawing.Skia 2020-04-05 21:19:04 +02:00
Mark Monteiro f91f2ef328 Merge remote-tracking branch 'upstream/master' into register-services-correctly 2020-04-05 10:07:17 -04:00
Mark Monteiro 735d6c8ad5 Convert properties in ApplicationHost to private readonly fields, where possible 2020-04-04 23:18:47 -04:00
Mark Monteiro 07cebbeae2 Register and construct IImageProcessor, SqliteItemRepository and IImageEncoder correctly 2020-04-04 17:12:24 -04:00
Bond-009 0b21494999
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
2020-04-03 23:13:04 +02:00
Bond-009 cbb6797043
Update SqliteItemRepository.cs 2020-04-03 22:41:14 +02:00
Bond_009 8e7b15285e Clean up SqliteItemRepository 2020-04-03 20:59:38 +02:00
Bond_009 3161e85f76 Address comments 2020-04-03 17:30:01 +02:00
Bond-009 f31efce52d
Merge branch 'master' into usings 2020-04-01 22:42:43 +02:00
Bond_009 787049f35f Merge branch 'master' into minor 2020-04-01 18:53:22 +02:00
Bond-009 ddd5d3aaec
Merge branch 'master' into usings 2020-04-01 18:51:44 +02:00
Vasily 0d2a355c00 Make variables binding correspond with column names 2020-03-26 17:40:28 +03:00
Bond_009 7915c6ca73 Remove extra ; 2020-03-24 16:16:13 +01:00
Bond_009 e9d1eabd53 Remove unused usings 2020-03-24 16:12:06 +01:00
dkanada 0d9787dfb4
Merge pull request #2478 from JustAMan/fix-search-order
Fix ordering of search results
2020-03-23 02:30:41 +09:00
dkanada 7270997e76
add code suggestions
Co-Authored-By: Mark Monteiro <marknr.monteiro@protonmail.com>
2020-03-23 00:59:22 +09:00
Bond-009 94fe9b8f6d
Merge branch 'master' into warn17 2020-03-11 20:26:43 +01:00
Mark Monteiro b67e9cde8c Replace ILogger with ILogger<T> wherever possible
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Vasily a9f3b5dacb Fix ordering of search results 2020-02-26 10:54:29 +03:00
Bond_009 07cc4be6a7 Fix some warnings
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009 a07ee65365 Minor improvements 2020-02-23 10:53:51 +01:00
Bond_009 adc9fc282c Minor improvements 2020-02-19 23:08:58 +01:00
Bond_009 bb236b9591 Merge branch 'master' into warn12 2020-01-10 21:18:16 +01:00
dkanada 73fac50e57 rename two properties based on code suggestions 2020-01-08 10:52:48 +09:00
Bond_009 8a0ef41036 Minor improvements 2020-01-08 01:24:12 +09:00
Bond_009 a253fa616d Fix build and address comments 2020-01-08 01:23:57 +09:00
dkanada aca31457c0 merge branch master into media-attachments 2020-01-08 01:21:09 +09:00
Neil Burrows d9c0721e3d Reformatting code 2019-12-14 17:48:30 +00:00
Neil Burrows 55317b5c74 Fixing index error & split out code for readability 2019-12-13 13:45:20 +00:00
Neil Burrows 12bb4a92eb Tidying up code 2019-12-13 11:08:19 +00:00
Neil Burrows 554c967dd6 Add Excluded Tags using SQLite parameters 2019-12-13 10:29:38 +00:00
Bond_009 2ef4ffd698 More warnings (removed) 2019-12-11 00:13:57 +01:00
dkanada 67922dff50
Merge pull request #2041 from Bond-009/warn11
Fix more warnings
2019-12-11 01:14:55 +09:00
Bond-009 affb58ef9e
Apply suggestions from code review
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
2019-12-10 16:22:03 +01:00
Bond-009 a2c35e6dba Merge remote-tracking branch 'upstream/master' into random 2019-12-06 12:06:13 +01:00
Bond_009 42ffddc269 Fix more warnings 2019-11-27 16:29:56 +01:00
Bond-009 b477b3874e Fix some warnings 2019-11-22 16:15:31 +01:00
dkanada f51f59d675
Merge pull request #1965 from Bond-009/dbjson
Deserialize with the correct type (and warning fixes)
2019-11-10 16:51:54 +09:00
Andrew Mahone d6aa02ff09
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
formatting

Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-07 11:22:07 -05:00
Andrew Mahone f60e9b0b62
formatting
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-07 11:20:29 -05:00
Andrew Mahone 6defe80b62 Check for cancellation between each batch of MediaAttachment inserts. 2019-11-07 08:38:36 -05:00
Andrew Mahone 74fb63a898 Use block rather than local using statement. 2019-11-06 10:43:14 -05:00
Andrew Mahone 8505ee9d6c Extract the prefix for MediaAttachment insertions to a static member instead of generating it per-query. 2019-11-05 14:53:46 -05:00
Andrew Mahone cc7741efd4 Merge branch 'media-attachments' of github.com:Unhelpful/jellyfin into media-attachments 2019-11-05 08:35:42 -05:00
Andrew Mahone 3602251cf5
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-05 08:36:17 -05:00
Andrew Mahone e5b65ed034
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
formatting

Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-05 08:19:07 -05:00
Andrew Mahone 25bc7b81c3
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
formatting

Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-05 08:13:35 -05:00
Andrew Mahone 24a460dc93
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
formatting

Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-11-05 08:13:22 -05:00
Andrew Mahone b936c530aa Merge branch 'media-attachments' of github.com:Unhelpful/jellyfin into media-attachments 2019-11-05 08:13:15 -05:00
Andrew Mahone bd4da93d1e Throw ArgumentException instead of ArgumentNullException on empty Guid. 2019-11-05 07:48:32 -05:00
Andrew Mahone ad2101ce52 Rename "limit" to "insertAtOnce" in InsertMediaAttachments. 2019-11-04 10:33:50 -05:00
Andrew Mahone c2d8f210b1 Check for cancellation in SaveMediaAttachments. 2019-11-04 10:31:32 -05:00
Andrew Mahone 0dde5e46df Flatten using connection in GetMediaAttachments/SaveMediaAttachments 2019-11-04 10:28:33 -05:00
Andrew Mahone 4573fb5301 Use ToByteArray instead of ToGuidBlob. 2019-11-04 10:19:53 -05:00
Andrew Mahone 1600d5b53f Merge remote-tracking branch 'origin/master' into media-attachments-clean 2019-11-04 10:03:18 -05:00
Andrew Mahone 90dfe729bb
Add space when building query string for attachments.
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
2019-11-04 08:48:27 -05:00
Bond_009 846857b60e Deserialize with the correct type (and warning fixes) 2019-11-01 17:07:42 +01:00
Bond_009 10ae815bb4 Address comments 2019-10-29 17:56:06 +01:00
Bond_009 016be02cd6 More warning fixes 2019-10-29 17:56:05 +01:00
Andrew Mahone 03ecf57548 Store MediaAttachments in DB. 2019-10-22 10:32:40 -04:00
Bond_009 bbc0875387 Don't shuffle some types by default 2019-10-20 16:08:40 +02:00
Bond_009 516933aab5 Move to netcore3.0 2019-10-11 18:32:13 +02:00
Vasily 79f9887625
Merge pull request #1854 from Bond-009/json
Use System.Text.Json api for databases
2019-10-10 18:15:48 +03:00
Bond_009 ac93a5a85c Change slow query time logging to debug 2019-10-08 22:17:15 +02:00
Bond_009 e553eba31e Use System.Text.Json api 2019-10-08 20:59:53 +02:00
Joshua M. Boniface 9aec21f6b5
Nicer link format for comment
Co-Authored-By: Bond-009 <bond.009@outlook.com>
2019-09-29 16:18:05 -04:00
Joshua Boniface 72edf5b555 Change PRAGMA mode from WAL to TRUNCATE 2019-09-29 15:53:35 -04:00
Bond-009 ee637e8fec Fix warnings, improve performance (#1665)
* Fix warnings, improve performance

`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)

* Update Providers .csproj to latest C#

* Remove extra newline from DtoService.cs

* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Bond_009 e4f893a0eb More warning fixes 2019-08-29 22:28:33 +02:00
Joshua M. Boniface dc1782d049
Merge pull request #1646 from Bond-009/lock
Return DB lock immediately
2019-08-21 18:24:47 -04:00
Bond_009 3fd489d1cb Upgrade SQLitePCL to v2 2019-08-19 17:03:21 +02:00
Bond_009 f70a63d575 Return DB asap 2019-08-18 22:05:06 +02:00
Joshua M. Boniface 4bb0c2d053
Merge pull request #1642 from cvium/fix_slow_db
Speed up BaseItem deserialization
2019-08-18 13:42:08 -04:00
Claus Vium f48eaccc51 Use reader.GetString instead of indexing 2019-08-18 17:32:41 +02:00
Claus Vium e7c05dcfaf Speed up BaseItem deserialization 2019-08-18 17:22:45 +02:00
Bond_009 8d3b5c851d Improvements to UserManager 2019-08-16 21:06:11 +02:00
Bond_009 d62a3f0e57 Fix master 2019-08-15 00:00:21 +02:00
Bond_009 2fdf7f1098 Properly dispose DisplayPreferencesRepository 2019-08-14 20:35:36 +02:00
Bond-009 6032f31aa6 Use CultureInvariant string conversion for Guids 2019-08-09 23:17:54 +02:00
Erwin de Haan 0dbc294836
Move VACUUM command to fix merge error
This fixes a syntax error.
2019-07-06 23:50:06 +02:00
Bond-009 82f041d050
Merge branch 'master' into release-10.3.z 2019-07-06 23:08:52 +02:00
Erwin de Haan acf52b9b55
Cleanup extra spaces. 2019-07-04 20:55:49 +02:00
Erwin de Haan 7587fe56d8
Moved VACUUM down to the end of the list. 2019-07-04 20:54:57 +02:00
Bond_009 29ae7b9aeb Add docs 2019-07-01 18:24:35 +02:00
Bond_009 45c13141f9 Address comments 2019-07-01 17:59:01 +02:00
Bond_009 d961278b3d Reduce amount of raw sql 2019-06-28 12:14:27 +02:00
Bond_009 db2765aae5 Last bit of cleanup 2019-06-28 12:14:27 +02:00
Bond_009 7898af4ceb Reworked PRAGMA statements use 2019-06-28 12:14:27 +02:00
Bond_009 edfd2d0cd9 Fix startup 2019-06-28 12:14:27 +02:00
Bond_009 d00ad28efd Address comments 2019-06-28 12:14:27 +02:00
Bond-009 e88ebd748d Final fixes 2019-06-28 12:14:27 +02:00
Bond-009 b6954f3bfd More 2019-06-28 12:14:27 +02:00
Bond-009 27c29bbb4c Back to a single connection 2019-06-28 12:13:34 +02:00
Bond-009 30842656a7 Properly dispose 2019-06-28 12:12:54 +02:00
Bond-009 e5248cfaa2 Properly dispose 2019-06-28 12:12:54 +02:00
Bond-009 c30ba14c1f Use a connection pool instead of creating new connections 2019-06-28 12:12:54 +02:00
Bond-009 cec22ad10d Simplify db code 2019-06-28 12:12:54 +02:00
ferferga b136f14084 Vacuum databases at startup 2019-06-10 11:31:38 +02:00
Joshua M. Boniface 89537abdc4
Merge pull request #1293 from Bond-009/query-time
Fix query time logging
2019-05-10 09:19:05 -04:00
Bond_009 a9337033c1 Fix query time logging 2019-04-24 15:25:22 +02:00
Claus Vium 764c6d5461 Fix comparison for empty password migration 2019-04-20 17:50:34 +02:00
Bond-009 b44a70ff36 Simplify/remove/clean code
* Remove useless runtime check (we only support one)
* Remove unused args
* Remove a global constant

And ofc fix some warnings ;)
2019-03-25 22:25:32 +01:00
redSpoutnik 480a6607e2
Merge branch 'master' into subtitle-display-title 2019-03-16 17:54:57 +01:00
redSpoutnik 427688a0a0 Change subtitles DisplayTitle behavior 2019-03-14 22:31:51 +01:00
Vasily 1fef8bf266
Merge pull request #1060 from Bond-009/assinfo
Remove redundant class AssemblyInfo
2019-03-12 16:34:21 +03:00
Bond-009 ae0ecc1b10
Merge pull request #870 from LogicalPhallacy/betterauth
Better default authentication
2019-03-07 19:11:36 +01:00
Bond-009 e91dd14b31 Remove redundent class AssemblyInfo 2019-03-07 18:10:55 +01:00
Joshua M. Boniface aba22b92bc
Merge pull request #735 from Bond-009/loop
Readability changes
2019-03-04 00:27:48 -05:00
Lynxy 5368112d90 Correct the list of series types 2019-03-01 22:28:25 -05:00
Bond-009 9993dafe54 Don't mix LINQ and roreach loops for readability 2019-03-01 17:12:22 +01:00
Bond-009 0804bed66d Log time in a standardized way 2019-02-26 19:40:23 +01:00
Phallacy 098de6b050 made newlines into linux newlines 2019-02-20 01:17:30 -08:00
Phallacy a0d31a49a0 merging with master to clear merge conflict 2019-02-20 00:46:13 -08:00
Phallacy 6bbb968b57 minor changes and return to netstandard 2019-02-20 00:00:26 -08:00
Joshua M. Boniface 89d4ce309d
Merge pull request #848 from Bond-009/perf
Minor changes to reduce allocations
2019-02-19 21:24:51 -05:00
LogicalPhallacy 9f3aa2cead
Apply suggestions from code review
Adding minor stylistic suggestions from Bond-009

Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-02-18 00:31:03 -08:00
Bond-009 5835c4b21d
Remove comment 2019-02-13 12:58:46 +01:00
Phallacy 77602aff88 Minor fixes re:PR870, added null checks from PR876 2019-02-13 00:33:00 -08:00
Bond_009 da9418c1b2 Useless copy 2019-02-12 21:06:47 +01:00
Bond_009 9dba930a85 Warn faster for slow requests 2019-02-12 21:06:47 +01:00
Bond_009 7722cb3ffa Some Lists -> IEnumerable 2019-02-12 21:06:47 +01:00
Bond_009 3e6819c718 Don't clone lists 2019-02-12 21:06:47 +01:00
Bond_009 41fb1e5106 Tuple -> ValueTuple 2019-02-12 21:06:47 +01:00
Bond_009 64d5ec12e2 Use HashSets for increased perf 2019-02-12 21:06:47 +01:00
Bond_009 a6a4cd5667 Removed some unused fields 2019-02-09 15:57:42 +01:00
Joshua M. Boniface c713824bf9
Merge pull request #734 from Bond-009/culture
Fix more analyzer warnings
2019-01-31 21:11:13 -05:00
Claus Vium 8985fb8d58 Remove support for games as a media type 2019-01-31 19:04:47 +01:00
Bond_009 a709cbdc64 Fix more analyzer warnings 2019-01-27 12:12:44 +01:00
Claus Vium 64b6cfa3dc Add Size to TypedBaseItem 2019-01-26 21:59:06 +01:00
Bond_009 d8d6c6f254 Address comments 2019-01-26 19:46:30 +01:00
Bond_009 2ffab720fb Fix ctor 2019-01-26 18:36:38 +01:00
Bond_009 07f163a4c3 Minor improvements to db code 2019-01-26 18:21:41 +01:00
hawken 490e22c790 Add comments to SqliteItemRepository to help out whoever is next 2019-01-22 12:20:36 +00:00
William Taylor 65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Erwin de Haan 321c440739 Reformat JustAMan review pt1 changes
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan e867446437 ReSharper format: conform inline 'out' parameters. 2019-01-13 21:46:33 +01:00
Erwin de Haan 65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan a36658f6f0 ReSharper Reformat: Properties to expression bodied form. 2019-01-13 21:31:14 +01:00
Erwin de Haan e566d9a231 Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv 2019-01-13 20:54:44 +01:00
Erwin de Haan a5288115a8 Visual Studio Reformat: Emby.Server.Implementations Part A-Da 2019-01-13 20:20:16 +01:00
Erwin de Haan e2751d42e8 Merge branch 'dev' into code-cleanup 2019-01-11 12:50:36 +01:00
Erwin de Haan ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken bd169e4fd4 remove trailing whitespace 2019-01-07 23:27:46 +00:00
Bond_009 ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00