Commit graph

20258 commits

Author SHA1 Message Date
Claus Vium
e64f9f2f66
Merge pull request #5613 from accek/accek-samsung-dlna-fix 2021-03-24 23:04:28 +01:00
Szymon Acedański
b1e8a8565f
Update Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-24 22:46:08 +01:00
Szymon Acedański
136136dea9 Fix incorrect responses for HEAD /audio/<id>/stream
Without this fix my Samsung Soundbar (HW-Q80R) fails to play using DLNA
and returns "Error: Resource not found (716)" instead.

I had a look on tcpdump network logs between Jellyfin and the soundbar
and noticed that the device performs a HEAD request for the media before
responding to the DLNA UPNP control request from Jellyfin (or BubbleUPNP
Android App).

Jellyfin retuns 204 No Content response, which is unusual.  Common web
servers generally return 200 OK if the GET would return content, and
this is not-very-clearly suggested [in HTTP
spec](https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.1)

The other patch is to ensure, that invalid Content-Length: 0 is not
returned with the HEAD response in the streaming case.

I think in both cases we still don't return the same headers with HEAD
as with GET (e.g. Content-Length or Accept-Ranges), but at least we
don't return anything misleading.
2021-03-24 20:43:54 +01:00
Bond-009
8410a9a266
Merge pull request #5586 from nyanmisaka/disable-autorotate 2021-03-22 22:59:01 +01:00
Kenneth SB
4637bbc723 Translated using Weblate (Danish)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/da/
2021-03-22 13:34:36 -04:00
Nyanmisaka
0853d1265c
Disable auto rotation for some HWA methods (#5586)
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-22 17:59:57 +01:00
Bond-009
f6671e05fd
Merge pull request #5580 from Bond-009/integrationtests2 2021-03-22 17:57:14 +01:00
Bond_009
5253483ce4 Improve naming 2021-03-22 13:49:00 +01:00
Nyanmisaka
fab4bf184e
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-22 19:47:05 +08:00
Nyanmisaka
a6bc191607
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-22 19:25:41 +08:00
nyanmisaka
fcb070abf7 disable auto rotation for some HWA methods 2021-03-22 18:36:04 +08:00
Joshua M. Boniface
fe8cf29cad
Merge pull request from GHSA-wg4c-c9g9-rxhx
Fix issues 1 through 5 from GHSL-2021-050
2021-03-21 19:12:14 -04:00
Joshua M. Boniface
890a490776
Merge pull request #5532 from cvium/fix_episode_extras_questionmark 2021-03-21 15:13:56 -04:00
Bond_009
c5079ebed5 Add tests for GetFirstUser, UpdateStartupUser and CompleteWizard 2021-03-21 03:59:31 +01:00
Bond_009
849ced470a Add StartupControllerTests 2021-03-21 03:26:51 +01:00
Bill Thornton
9fe3ca7a92
Merge pull request #5476 from jellyfin/EraYaN-nuget-ci
Remove BuildPackage dependency for PublishNuget in CI
2021-03-19 20:50:42 -04:00
Erwin de Haan
1f3aa3fe6f Apply review suggestions 2021-03-20 01:28:14 +01:00
Erwin de Haan
470305f75e Authenticated arbitrary file overwrite in SubtitleController -> SubtitleManager
GHSL-2021-050: Issue 5 Arbitrary file overwrite.
2021-03-20 01:14:59 +01:00
Erwin de Haan
239a7156cc Fix arbitrary image file reads in ImageByNameController
GHSL-2021-050: Issue 4 Arbitrary image file read and directory traversal.
2021-03-20 01:14:59 +01:00
Erwin de Haan
f61d18612b Fix directory traversal in the HlsSegmentController in a fairly rudimentary but working way.
GHSL-2021-050: Issue 1,2,3 Arbitrary file read and directory traversal.
The segment id's can probably just be verified to be an actual ID or to not contain any forward or backward slashes
2021-03-20 01:14:59 +01:00
Bond-009
1a0ce16f4d
Merge pull request #5504 from crobibero/json-string-converter 2021-03-20 00:48:41 +01:00
Claus Vium
9360fecb31
Merge pull request #5559 from cvium/fix-tmdb-search-clean
Clean the entity name for non-words before searching
2021-03-19 09:24:20 +01:00
Claus Vium
e1c6bb0482
Merge pull request #5561 from barronpm/permissions-fix 2021-03-19 09:23:32 +01:00
andrewthemeow
9857c21717 Translated using Weblate (Lithuanian)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/lt/
2021-03-19 02:50:08 -04:00
Patrick Barron
85da0b50e2 Fix user mocking 2021-03-17 21:24:14 -04:00
Patrick Barron
12b8e29aef Fix duplicate permissions 2021-03-17 17:42:45 -04:00
cvium
151156f227 Clean the entity name for non-words before searching 2021-03-17 10:29:45 +01:00
Vitorvlv
37aa3e8735 Translated using Weblate (Portuguese (Brazil))
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/pt_BR/
2021-03-16 23:19:43 -04:00
Alyssa Ross
e14311ca8b Translated using Weblate (Esperanto)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/eo/
2021-03-16 15:19:34 -04:00
Bond-009
f42cee4790
Merge pull request #5550 from cvium/revert_underscore_multiversion 2021-03-16 14:38:29 +01:00
cvium
23c3188501 revert underscore as a multiversion separator 2021-03-15 23:24:59 +01:00
Claus Vium
94820f569b
Merge pull request #5512 from crobibero/api-spec-version 2021-03-15 18:01:20 +01:00
Claus Vium
baa43c6b41
Merge pull request #5475 from BaronGreenback/SSDPFix 2021-03-15 09:06:15 +01:00
cvium
025e351f61 add unit tests 2021-03-15 08:25:20 +01:00
cvium
ab0cff8556 do not resolve episode-like files if they are in extras folders 2021-03-14 19:56:45 +01:00
Bond-009
f2125da9f9
Merge pull request #5395 from barronpm/ef-cleanup 2021-03-14 19:08:50 +01:00
Patrick Barron
e5380c653b Merge branch 'master' into ef-cleanup
# Conflicts:
#	Jellyfin.Data/Entities/Libraries/MediaFileStream.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2021-03-14 10:19:35 -04:00
Claus Vium
109f24514f
Merge pull request #5510 from BaronGreenback/DlnaFirstFix
Fix: Streaming crashing due to no deviceProfileId match.
2021-03-14 15:07:31 +01:00
Claus Vium
bd70f56218
Merge pull request #5324 from danieladov/master
Fix duplicated movies when group movies into collections is enabled
2021-03-14 13:37:00 +01:00
Bond-009
0e5d4a3bcf
Merge pull request #5422 from Bond-009/warn51 2021-03-14 00:41:40 +01:00
Bond-009
5c0c205bed
Merge pull request #5522 from Bond-009/integrationtests
Fix integration test project
2021-03-14 00:21:51 +01:00
Bond_009
72d3eed15c Fix integration test project 2021-03-14 01:07:53 +01:00
Bond-009
8bb2420a25
Merge pull request #5518 from crobibero/missing-endpoints
Add missing InstantMix endpoints
2021-03-13 22:59:47 +01:00
Bond_009
01dfa8801a Fix GetDaysOfWeek behavior 2021-03-13 22:40:23 +01:00
Bond_009
46a41ecba6 Sunday isn't a weekend 2021-03-13 22:33:28 +01:00
Bond_009
a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Mister Rajoy
8883aa4a37 Merge branch 'master' of https://github.com/danieladov/jellyfin 2021-03-13 20:35:52 +01:00
Mister Rajoy
4cc3b938fa Change Guid.Parse to Guid.TryParse 2021-03-13 20:33:05 +01:00
Daniel
7a3109104b
Remove empty line
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-13 19:24:02 +01:00
Daniel
4b17648df3
Remove empty line
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-13 19:23:52 +01:00