Commit graph

620 commits

Author SHA1 Message Date
BaronGreenback 4bd345fbab DLNA Exception catching 2021-03-22 17:21:12 +00:00
BaronGreenback 5d16d1f66d
Merge branch 'master' into RemoteAccessFix 2021-03-22 17:05:44 +00:00
BaronGreenback 7fa525c83b Added more tests 2021-03-22 17:04:09 +00:00
Bond-009 f6671e05fd
Merge pull request #5580 from Bond-009/integrationtests2 2021-03-22 17:57:14 +01:00
Bond_009 5253483ce4 Improve naming 2021-03-22 13:49:00 +01:00
Joshua M. Boniface 890a490776
Merge pull request #5532 from cvium/fix_episode_extras_questionmark 2021-03-21 15:13:56 -04:00
Bond_009 c5079ebed5 Add tests for GetFirstUser, UpdateStartupUser and CompleteWizard 2021-03-21 03:59:31 +01:00
Bond_009 849ced470a Add StartupControllerTests 2021-03-21 03:26:51 +01:00
Bond-009 1a0ce16f4d
Merge pull request #5504 from crobibero/json-string-converter 2021-03-20 00:48:41 +01:00
David 840eeff2af Apply suggestions from code review 2021-03-18 11:25:58 +01:00
Patrick Barron 85da0b50e2 Fix user mocking 2021-03-17 21:24:14 -04:00
David 14cbd22fbe Use Helper Methods for provider url parsing 2021-03-16 21:45:12 +01:00
cvium 23c3188501 revert underscore as a multiversion separator 2021-03-15 23:24:59 +01:00
cvium 025e351f61 add unit tests 2021-03-15 08:25:20 +01:00
BaronGreenback 4c7680e186 Merge remote-tracking branch 'upstream/master' into SubnetOverlappFix 2021-03-14 18:40:44 +00:00
Patrick Barron e5380c653b Merge branch 'master' into ef-cleanup
# Conflicts:
#	Jellyfin.Data/Entities/Libraries/MediaFileStream.cs
#	Jellyfin.Data/Jellyfin.Data.csproj
2021-03-14 10:19:35 -04:00
Bond-009 0e5d4a3bcf
Merge pull request #5422 from Bond-009/warn51 2021-03-14 00:41:40 +01:00
Bond_009 72d3eed15c Fix integration test project 2021-03-14 01:07:53 +01:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Bond_009 d9eb7ae6dc Fix invalid crc in TryGetReturnValueOfGetSet_InvalidPacketType test 2021-03-13 21:28:04 +01:00
Bond_009 f9640f4366 Rewrite HdHomerunManager.ParseReturnMessage 2021-03-13 21:12:11 +01:00
Bond_009 e8b18e5f8f Add test for HdHomerunManager.ParseReturnMessage 2021-03-13 19:32:40 +01:00
Bond_009 7fb3a354fd Add test for HdHomerunManager.WriteSetMessage with lockkey 2021-03-13 19:24:47 +01:00
Bond_009 f5789483fd Add test for HdHomerunManager.WriteSetMessage 2021-03-13 19:21:29 +01:00
Bond-009 b755c25217
Merge pull request #5220 from Bond-009/hdhomerun 2021-03-13 15:05:18 +01:00
BaronGreenback b7fb152faf
Update tests/Jellyfin.Networking.Tests/NetworkParseTests.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-12 14:44:05 +00:00
crobibero e814d8e2cf Add JsonStringConverter 2021-03-12 06:43:57 -07:00
Bond-009 d7f0aaaec1
Merge pull request #5417 from Bond-009/codeanal
Add code analysis attributes where appropriate
2021-03-12 00:15:12 +01:00
BaronGreenback e5914fd28c split tests 2021-03-11 22:47:37 +00:00
BaronGreenback 3fdf0de6e3 Fix remote access 2021-03-11 21:36:58 +00:00
Bond-009 d967267cef
Merge pull request #5461 from cvium/fix_multiversion 2021-03-11 22:31:06 +01:00
cvium 7d69c2550c fix copy/paste error in test 2021-03-10 19:30:23 +01:00
cvium b0af11c34e make the eligibility check more strict wrt. brackets 2021-03-10 19:29:52 +01:00
David 954148eb6d Fix Radarr url nfo files 2021-03-10 17:08:24 +01:00
cvium 3824c09e77 fix multiversion eligibility check for complex folder names 2021-03-10 10:47:35 +01:00
Bond_009 a618d6053f Move TestPluginWithoutPages to the correct project 2021-03-09 14:24:19 +01:00
Bond_009 37eb7d6d49 Perform static initialization only once 2021-03-09 14:24:19 +01:00
Bond_009 b9577d0fd9 Check for specific status code instead of success 2021-03-09 14:24:19 +01:00
Bond_009 fa8bfece4e Split integration tests from unit tests 2021-03-09 14:17:59 +01:00
Bond_009 d202df6e8a Remove useless line 2021-03-09 03:22:51 +01:00
Bond_009 9ed7f429c0 FxCop -> Net Analyzers (part 1) 2021-03-09 03:04:47 +01:00
Bond_009 5241bd41ef Add code analysis attributes where appropriate 2021-03-09 01:28:21 +01:00
BaronGreenback a031f7e410 Fix for multiple ip's in the same subnet per interface. 2021-03-09 00:07:21 +00:00
Joshua M. Boniface 3c46f10e3d
Merge pull request #5315 from BaronGreenback/FixFor5280Part2 2021-03-08 18:06:40 -05:00
Joshua M. Boniface 0ef8bea125
Merge pull request #5406 from cvium/trycleanstring-dont-die-on-me 2021-03-08 16:54:26 -05:00
Claus Vium 90cdd1345d
Merge pull request #5407 from Bond-009/hack 2021-03-08 21:23:14 +01:00
Bond_009 2e62c09f2e Fix casing CollectionType 2021-03-08 02:16:35 +01:00
cvium e0db17a935 do not throw ArgumentNullException in TryCleanString 2021-03-07 22:49:31 +01:00
Patrick Barron f638ee6b09 Enable nullable for Jellyfin.Data and remove unnecessary attributes 2021-03-06 17:43:01 -05:00
Bond-009 497ea57fd2
Merge pull request #5381 from cvium/fix-network-substitution 2021-03-06 21:38:32 +01:00
cvium bc661c16e1 simplify 2021-03-06 14:01:37 +01:00
Cody Robibero df1951cfe2
Apply suggestions from code review
Co-authored-by: dkanada <dkanada@users.noreply.github.com>
2021-03-05 08:30:49 -07:00
crobibero fd0b3ca5ef Add JsonVersionConverter and tests 2021-03-05 07:48:45 -07:00
cvium 37e374d33d make sure network path substitution matches correctly 2021-03-05 14:09:23 +01:00
cvium 8b72b902f5 fix HasProviderId and add tests 2021-03-03 12:28:40 +01:00
cvium a49f5d2a44 revert removal of null check 2021-03-03 09:37:21 +01:00
Claus Vium e858e5f0b8
Merge pull request #5339 from Bond-009/hasproviderids
Revert breaking change to HasProviderId
2021-03-02 09:35:51 +01:00
Bond_009 ba62d9d1fe Revert breaking change 2021-03-01 20:35:38 +01:00
Bond_009 ed0267252f Remove tests that are upstreamed
libse (the SSA parser we use) has these same tests now
2021-03-01 20:00:00 +01:00
Bond-009 c2af32d035
Merge pull request #5299 from Bond-009/tests13 2021-03-01 18:51:09 +01:00
dependabot[bot] b0d391427b
Bump Moq from 4.16.0 to 4.16.1
Bumps [Moq](https://github.com/moq/moq4) from 4.16.0 to 4.16.1.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.16.0...v4.16.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-01 14:06:48 +00:00
dependabot[bot] 829442c419
Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-01 12:00:38 +00:00
David 16694b0cfc Add nfo thumb tag support 2021-02-28 15:00:17 +01:00
BaronGreenback 8836242559 fixed tests 2021-02-28 10:25:14 +00:00
BaronGreenback 80ca3da55c Merge remote-tracking branch 'upstream/master' into FixFor5280Part2 2021-02-28 10:12:14 +00:00
BaronGreenback f666b7e102 fix 2021-02-27 23:32:22 +00:00
Claus Vium f8c9c37c29
Merge pull request #5181 from BaronGreenback/Fix_IPHostIP6Parsing 2021-02-27 22:52:24 +01:00
Claus Vium 14605280a0
Merge pull request #5274 from BaronGreenback/bindfix 2021-02-27 22:51:45 +01:00
Bond-009 bc7e31a1bc
Merge pull request #5285 from Bond-009/tests11 2021-02-24 12:15:06 +01:00
Bond_009 032d72a8a7 Pls fix race condition 2021-02-23 17:30:24 +01:00
Bond_009 acac21d8dc Improve tests 2021-02-23 16:45:10 +01:00
Bond_009 aff0aea60f Improve branch coverage 2021-02-23 14:14:02 +01:00
Bond-009 92e5a5c6e8
Merge pull request #5166 from netpok/index-number-end-from-nfo 2021-02-23 13:00:16 +01:00
Bond-009 e09e67deae
Merge branch 'master' into tests11 2021-02-23 12:54:05 +01:00
Joshua M. Boniface 7ece3c5523
Merge pull request #5273 from Bond-009/warn31 2021-02-22 21:00:46 -05:00
Joshua M. Boniface c0c4aff8a6
Merge pull request #5276 from Bond-009/minor12 2021-02-22 21:00:34 -05:00
Joshua M. Boniface da55462d92
Merge pull request #5291 from Bond-009/tests12 2021-02-22 21:00:15 -05:00
Joshua M. Boniface 5ce4df4178
Merge pull request #5270 from Bond-009/imdb 2021-02-22 20:59:57 -05:00
Joshua M. Boniface 23ff1fab46
Merge pull request #4984 from Bond-009/subtitleedit 2021-02-22 20:59:49 -05:00
Bond_009 baadc48f43 Address comments 2021-02-22 16:27:02 +01:00
Bond_009 ec3237ba55 Fix tests 2021-02-22 13:46:40 +01:00
Bond_009 57102090d3 Add tests for DashboardController 2021-02-22 13:15:29 +01:00
dependabot[bot] d033c30cd7
Bump coverlet.collector from 3.0.2 to 3.0.3
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 12:00:42 +00:00
Bond_009 ff10dd9e12 Update deps Jellyfin.Model.Tests 2021-02-22 09:58:23 +01:00
BaronGreenback 7bfc59b562 Fixed test data. 2021-02-21 13:41:37 +00:00
Bond_009 eba859e33e Minor improvements 2021-02-21 02:49:52 +01:00
BaronGreenback 5756c6dbad
Merge branch 'master' into bindfix 2021-02-21 00:44:14 +00:00
BaronGreenback b03bd7a299 Fix testing 2021-02-21 00:41:14 +00:00
Bond_009 141efafd3d Enable TreatWarningsAsErrors for MediaBrowser.Model 2021-02-20 23:29:33 +01:00
Bond_009 2b131ddaac Cover all branches 2021-02-19 17:26:34 +01:00
Bond_009 941d3f6217 Add tests for ProviderIdsExtensions 2021-02-19 17:01:52 +01:00
Bond-009 ae30eaf320
Merge pull request #5255 from cvium/fix_renameuser 2021-02-18 17:52:25 +01:00
cvium 2112d2a9a0 Restructure tests 2021-02-17 11:51:15 +01:00
cvium 442e770688 Validate the new username when renaming 2021-02-17 11:30:14 +01:00
Bond_009 54eee41207 Fix broken test 2021-02-17 10:38:44 +01:00
David 9379f535c2 Merge remote-tracking branch 'jellyfin/master' into nfo-tests 2021-02-15 12:00:51 +01:00
David e924545ae2 Fix tests for UNIX 2021-02-15 11:39:00 +01:00
Bond-009 30372fcd68
Merge pull request #5194 from Ullmie02/nfo-watched 2021-02-14 18:25:41 +01:00
David fc7377fb9b Merge remote-tracking branch 'jellyfin/master' into nfo-tests
# Conflicts:
#	tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs
#	tests/Jellyfin.XbmcMetadata.Tests/Parsers/SeriesNfoParserTests.cs
2021-02-13 22:55:33 +01:00
David 7f12b27319 Add nfo location tests 2021-02-13 22:48:29 +01:00
David 36d91a1601 Add test for music video nfo 2021-02-13 22:41:38 +01:00
David eecdc3c110 Add more tags to nfo tests 2021-02-13 22:41:12 +01:00
Bond_009 dc9e2ad1a4 Add some more Crc32 tests 2021-02-13 11:46:38 +01:00
Bond_009 e1bc322b70 Add test for WriteGetMessage 2021-02-12 18:35:54 +01:00
Bond_009 3a9fcb6abd Rewrite packet writing code for HdHomerun 2021-02-12 17:34:51 +01:00
Bond_009 97935d2cd2 Add tests for RequestHelpers.GetItemTypeStrings 2021-02-11 18:21:08 +01:00
David Ullmer ab5fb1b1f2 Merge branch 'master' of github.com:jellyfin/jellyfin into nfo-watched 2021-02-11 13:48:58 +01:00
David Ullmer ae57ed4ac7 Add nfo user data tests 2021-02-11 13:36:35 +01:00
crobibero 407c35f087 Update to dotnet 5.0.3 2021-02-09 19:02:02 -07:00
Bond_009 9e5c4439b9 Comment out broken tests 2021-02-09 15:12:43 +01:00
Bond_009 f81bcf7f35 Fix tests on windows 2021-02-09 15:12:43 +01:00
Bond_009 be965e35b6 Log subtitle errors 2021-02-09 15:12:43 +01:00
Bond_009 ed8fce2dce Use SubtitleEdit to parse subtitles 2021-02-09 15:12:41 +01:00
David 3a4c33ca5f Add nfo parsing for watched, playcount and lastplayed 2021-02-09 12:42:55 +01:00
David Ullmer 086254821f Add test for generic nfo provider id parsing 2021-02-09 11:19:19 +01:00
Balázs Váradi 7ba53548a2 Fix typos in nfo tests 2021-02-09 07:21:08 +01:00
dkanada 7f1243978c
Merge pull request #5012 from jellyfin/ws
Improve WebSocket Message Deserialization
2021-02-09 11:10:52 +09:00
Balázs Váradi 351d61a318 Add test for multiepisode nfo parsing 2021-02-08 19:40:17 +01:00
Bond_009 13c1c2815f Add regression test for PluginManager.SaveManifest 2021-02-08 17:10:20 +01:00
BaronGreenback 053063fd47 Fixed IP6 host parsing 2021-02-07 17:42:23 +00:00
dkanada 2e9661c415
Merge pull request #5043 from senritsu/improve-episode-number-parsing-with-digits-in-names
adjust episode path expression to allow digits in series names
2021-02-05 11:43:32 +09:00
dkanada bfbbee0bc9
Merge pull request #5085 from Ullmie02/nfo-actor-type
Process actor type in nfo files
2021-02-04 23:27:34 +09:00
Bond_009 80e22d9670 Add test for ShuffleExtensions 2021-01-26 20:21:07 +01:00
dependabot[bot] 09471a206a
Bump coverlet.collector from 3.0.1 to 3.0.2
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-25 12:00:44 +00:00
Claus Vium 98a4e1b840
Merge pull request #5095 from Bond-009/sortorder 2021-01-24 19:04:12 +01:00
Bond_009 f6b293203a
Restore weird behaviour 2021-01-24 17:55:25 +01:00
Bond-009 3806cc5b3f
Merge pull request #5074 from jellyfin/cov
100% branch coverage for Jellyfin.Naming
2021-01-24 14:11:48 +01:00
Bond_009 d24e7f60c7
Fix GetOrderBy and add tests 2021-01-24 11:43:05 +01:00
Joshua M. Boniface 3bf7e18886
Merge pull request #5031 from crobibero/5.0.2
Update to dotnet 5.0.2
2021-01-23 14:41:03 -05:00
David 454d82c52c Process actor type in nfo files 2021-01-23 18:06:26 +01:00
dependabot[bot] 1bc1d1c07b
Bump Moq from 4.15.2 to 4.16.0
Bumps [Moq](https://github.com/moq/moq4) from 4.15.2 to 4.16.0.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.15.2...v4.16.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-23 13:43:41 +00:00
Bond-009 7c3db79535
Merge pull request #5053 from jellyfin/dependabot/nuget/coverlet.collector-3.0.1
Bump coverlet.collector from 3.0.0 to 3.0.1
2021-01-23 14:43:11 +01:00
Bond_009 956ca0e5aa 100% branch coverage for Jellyfin.Naming 2021-01-21 15:46:10 +01:00
David d71dce50ca Add music album nfo parser test 2021-01-20 20:02:35 +01:00
David ccea02fbb2 Add season nfo parser test 2021-01-20 20:02:03 +01:00
David dbd70bd394 Add episode nfo parser test 2021-01-20 19:47:31 +01:00
David 0279af5f6b Move existing tests to correct namespace 2021-01-20 19:46:44 +01:00
Claus Vium 14bd4a110f
Merge pull request #4978 from BaronGreenback/MultipeProxies 2021-01-19 20:55:21 +01:00
BaronGreenback 25eaf21a8f renamed func in test 2021-01-19 19:32:46 +00:00
BaronGreenback 82d365045a Removed systemIp6 functionality. 2021-01-19 12:50:11 +00:00
BaronGreenback dd089fd27a Changed test 2021-01-19 10:50:17 +00:00
BaronGreenback 6a7623da02 Simplified Code 2021-01-19 10:36:37 +00:00
dependabot[bot] 0cb80d3815
Bump coverlet.collector from 3.0.0 to 3.0.1
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-18 12:01:03 +00:00
senritsu 4e21b49994 adjust episode path expression to allow digits in series names
The previous expression was too greedy to consume digits, because the hyphen was optional. This lead to incorrect episode numbers for certain series with digits in their names, in those cases each episode was recognized as the same episode number (the digit from the series name).

The rule, which matches most standard  anime filenames, also had a lower priority than one of the Kodi rules, leading to incorrect recognition for absolute numbered episodes with triple digits and higher (first digit was used as season number, rest of digits as episode number). This also resolves one of the TODO test cases.

Additional test cases were added to ensure that both hyphens in different parts of the filename, as well as names without hyphens, still work correctly. All previous test cases still pass.

Unfortunately another TODO (EpisodeNumberTests.cs@L76, Uchuu Senkan Yamato 2199) with the same issue (digits in the series name) could not be trivially fixed in the same change, due to the significantly different formatting. Attempts to resolve this case did not work out for now.
2021-01-17 20:24:23 +01:00
BaronGreenback b9f0f4f53b reverted 2021-01-17 13:35:30 +00:00
Joshua M. Boniface fe9096be94
Merge pull request #4970 from BaronGreenback/networkTestCorrection 2021-01-16 13:28:34 -05:00
crobibero a087ab389a dotnet 5.0.2 2021-01-16 10:17:33 -07:00
BaronGreenback bced1eab54 Assert.True 2021-01-13 21:16:04 +00:00
Bond_009 9a5ceb34d1 Improve WebSocket Deserialization 2021-01-13 01:11:25 +01:00
BaronGreenback 2979c8dd37 Fixed test on Mac 2021-01-12 13:23:10 +00:00